[INFO] fetching crate unftp-sbe-fs 0.2.5... [INFO] checking unftp-sbe-fs-0.2.5 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate unftp-sbe-fs 0.2.5 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate unftp-sbe-fs 0.2.5 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate unftp-sbe-fs 0.2.5 [INFO] finished tweaking crates.io crate unftp-sbe-fs 0.2.5 [INFO] tweaked toml for crates.io crate unftp-sbe-fs 0.2.5 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate unftp-sbe-fs 0.2.5 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d6a7c573781ff4b782c39515a25081ebc129146a38c92dd2308f04c583f04ee4 [INFO] running `Command { std: "docker" "start" "-a" "d6a7c573781ff4b782c39515a25081ebc129146a38c92dd2308f04c583f04ee4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d6a7c573781ff4b782c39515a25081ebc129146a38c92dd2308f04c583f04ee4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d6a7c573781ff4b782c39515a25081ebc129146a38c92dd2308f04c583f04ee4", kill_on_drop: false }` [INFO] [stdout] d6a7c573781ff4b782c39515a25081ebc129146a38c92dd2308f04c583f04ee4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b179ae9a2d710457c04d66332aebc4a80e6c964c665514a09c84d5ca374a426d [INFO] running `Command { std: "docker" "start" "-a" "b179ae9a2d710457c04d66332aebc4a80e6c964c665514a09c84d5ca374a426d", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.82 [INFO] [stderr] Compiling libc v0.2.154 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling thiserror v1.0.60 [INFO] [stderr] Compiling cc v1.0.97 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Compiling typenum v1.15.0 [INFO] [stderr] Checking smallvec v1.13.1 [INFO] [stderr] Compiling parking_lot_core v0.9.9 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Compiling slog v2.7.0 [INFO] [stderr] Checking bytes v1.6.0 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Compiling rustix v0.38.31 [INFO] [stderr] Compiling semver v1.0.18 [INFO] [stderr] Compiling io-lifetimes v2.0.3 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Compiling generic-array v0.14.5 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Checking nom v7.1.1 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Compiling num-bigint v0.4.3 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Compiling syn v2.0.63 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling io-extras v0.18.1 [INFO] [stderr] Compiling oid-registry v0.7.0 [INFO] [stderr] Compiling serde v1.0.202 [INFO] [stderr] Compiling rustls v0.21.12 [INFO] [stderr] Compiling cfg_aliases v0.1.1 [INFO] [stderr] Compiling nix v0.28.0 [INFO] [stderr] Checking regex-automata v0.4.5 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking crossbeam-channel v0.5.8 [INFO] [stderr] Checking crypto-common v0.1.3 [INFO] [stderr] Checking block-buffer v0.10.2 [INFO] [stderr] Checking arc-swap v1.5.0 [INFO] [stderr] Compiling moka v0.11.3 [INFO] [stderr] Compiling cap-primitives v2.0.1 [INFO] [stderr] Compiling prometheus v0.13.4 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling rstest_macros v0.18.2 [INFO] [stderr] Checking scheduled-thread-pool v0.2.7 [INFO] [stderr] Checking rusticata-macros v4.1.0 [INFO] [stderr] Checking slog-scope v4.4.0 [INFO] [stderr] Checking uuid v1.8.0 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking is-terminal v0.4.12 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking thread_local v1.1.7 [INFO] [stderr] Checking data-encoding v2.3.2 [INFO] [stderr] Checking tagptr v0.2.0 [INFO] [stderr] Compiling convert_case v0.4.0 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Checking maybe-owned v0.3.4 [INFO] [stderr] Compiling cap-std v2.0.1 [INFO] [stderr] Checking ambient-authority v0.0.2 [INFO] [stderr] Checking triomphe v0.1.11 [INFO] [stderr] Checking dirs-next v2.0.0 [INFO] [stderr] Checking slog-stdlog v4.1.1 [INFO] [stderr] Checking md-5 v0.10.6 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling slog-async v2.8.0 [INFO] [stderr] Compiling relative-path v1.9.2 [INFO] [stderr] Compiling serde_json v1.0.117 [INFO] [stderr] Compiling glob v0.3.1 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking std_prelude v0.2.12 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Checking term v0.7.0 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking dashmap v5.5.3 [INFO] [stderr] Checking sharded-slab v0.1.4 [INFO] [stderr] Checking yansi v0.5.1 [INFO] [stderr] Checking ryu v1.0.17 [INFO] [stderr] Checking diff v0.1.13 [INFO] [stderr] Checking take_mut v0.2.2 [INFO] [stderr] Checking fastrand v2.0.1 [INFO] [stderr] Checking futures-timer v3.0.2 [INFO] [stderr] Checking nix v0.26.4 [INFO] [stderr] Checking slog-term v2.9.1 [INFO] [stderr] Checking more-asserts v0.3.1 [INFO] [stderr] Checking pretty_assertions v1.4.0 [INFO] [stderr] Checking regex v1.10.4 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking stfu8 v0.2.5 [INFO] [stderr] Checking env_logger v0.10.2 [INFO] [stderr] Checking fs-set-times v0.20.1 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Checking pretty_env_logger v0.5.0 [INFO] [stderr] Compiling synstructure v0.13.1 [INFO] [stderr] Compiling thiserror-impl v1.0.60 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling asn1-rs-derive v0.5.0 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling asn1-rs-impl v0.2.0 [INFO] [stderr] Compiling serde_derive v1.0.202 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling async-trait v0.1.80 [INFO] [stderr] Checking sct v0.7.1 [INFO] [stderr] Checking rustls-webpki v0.101.7 [INFO] [stderr] Checking tokio v1.37.0 [INFO] [stderr] Compiling displaydoc v0.2.3 [INFO] [stderr] Compiling snafu-derive v0.6.10 [INFO] [stderr] Compiling pin-project-internal v1.0.10 [INFO] [stderr] Compiling derive_more v0.99.17 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking asn1-rs v0.6.1 [INFO] [stderr] Checking pin-project v1.0.10 [INFO] [stderr] Checking snafu v0.6.10 [INFO] [stderr] Checking proxy-protocol v0.5.0 [INFO] [stderr] Checking der-parser v9.0.0 [INFO] [stderr] Checking x509-parser v0.16.0 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking rstest v0.18.2 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking tokio-rustls v0.24.1 [INFO] [stderr] Checking tokio-stream v0.1.15 [INFO] [stderr] Checking async_ftp v6.0.0 [INFO] [stderr] Checking libunftp v0.20.0 [INFO] [stderr] Checking path_abs v0.5.1 [INFO] [stderr] Checking unftp-sbe-fs v0.2.5 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:130:17 [INFO] [stdout] | [INFO] [stdout] 128 | .and_then(|dirent| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 129 | let entry_path: PathBuf = dirent.file_name().into(); [INFO] [stdout] 130 | cap_fs::symlink_metadata(self.root_fd.clone(), path.join(entry_path.clone())).map_ok(move |meta| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:142:158 [INFO] [stdout] | [INFO] [stdout] 142 | async fn get + Send + Debug>(&self, _user: &User, path: P, start_pos: u64) -> Result> { [INFO] [stdout] | ______________________________________________________________________-------_________________________________________________________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 143 | | let path = strip_prefixes(path.as_ref()); [INFO] [stdout] 144 | | let file = cap_fs::open(self.root_fd.clone(), path).await?; [INFO] [stdout] 145 | | let mut file = tokio::fs::File::from_std(file.into_std()); [INFO] [stdout] ... | [INFO] [stdout] 150 | | Ok(Box::new(tokio::io::BufReader::with_capacity(4096, file)) as Box) [INFO] [stdout] 151 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:159:22 [INFO] [stdout] | [INFO] [stdout] 156 | bytes: R, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 157 | path: P, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 158 | start_pos: u64, [INFO] [stdout] 159 | ) -> Result { [INFO] [stdout] | ______________________^ [INFO] [stdout] 160 | | // TODO: Add permission checks [INFO] [stdout] 161 | | [INFO] [stdout] 162 | | let path = strip_prefixes(path.as_ref()); [INFO] [stdout] ... | [INFO] [stdout] 174 | | Ok(bytes_copied) [INFO] [stdout] 175 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ext.rs:20:38 [INFO] [stdout] | [INFO] [stdout] 18 | fn with_fs + Send + 'static>(path: P) -> ServerBuilder { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | let p = path.into(); [INFO] [stdout] 20 | libunftp::ServerBuilder::new(Box::new(move || { [INFO] [stdout] | ______________________________________^ [INFO] [stdout] 21 | | let p = &p.clone(); [INFO] [stdout] 22 | | Filesystem::new(p) [INFO] [stdout] 23 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:130:17 [INFO] [stdout] | [INFO] [stdout] 128 | .and_then(|dirent| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 129 | let entry_path: PathBuf = dirent.file_name().into(); [INFO] [stdout] 130 | cap_fs::symlink_metadata(self.root_fd.clone(), path.join(entry_path.clone())).map_ok(move |meta| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:142:158 [INFO] [stdout] | [INFO] [stdout] 142 | async fn get + Send + Debug>(&self, _user: &User, path: P, start_pos: u64) -> Result> { [INFO] [stdout] | ______________________________________________________________________-------_________________________________________________________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 143 | | let path = strip_prefixes(path.as_ref()); [INFO] [stdout] 144 | | let file = cap_fs::open(self.root_fd.clone(), path).await?; [INFO] [stdout] 145 | | let mut file = tokio::fs::File::from_std(file.into_std()); [INFO] [stdout] ... | [INFO] [stdout] 150 | | Ok(Box::new(tokio::io::BufReader::with_capacity(4096, file)) as Box) [INFO] [stdout] 151 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:159:22 [INFO] [stdout] | [INFO] [stdout] 156 | bytes: R, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 157 | path: P, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 158 | start_pos: u64, [INFO] [stdout] 159 | ) -> Result { [INFO] [stdout] | ______________________^ [INFO] [stdout] 160 | | // TODO: Add permission checks [INFO] [stdout] 161 | | [INFO] [stdout] 162 | | let path = strip_prefixes(path.as_ref()); [INFO] [stdout] ... | [INFO] [stdout] 174 | | Ok(bytes_copied) [INFO] [stdout] 175 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ext.rs:20:38 [INFO] [stdout] | [INFO] [stdout] 18 | fn with_fs + Send + 'static>(path: P) -> ServerBuilder { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | let p = path.into(); [INFO] [stdout] 20 | libunftp::ServerBuilder::new(Box::new(move || { [INFO] [stdout] | ______________________________________^ [INFO] [stdout] 21 | | let p = &p.clone(); [INFO] [stdout] 22 | | Filesystem::new(p) [INFO] [stdout] 23 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `unftp-sbe-fs` (lib test) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `unftp-sbe-fs` (lib) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "b179ae9a2d710457c04d66332aebc4a80e6c964c665514a09c84d5ca374a426d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b179ae9a2d710457c04d66332aebc4a80e6c964c665514a09c84d5ca374a426d", kill_on_drop: false }` [INFO] [stdout] b179ae9a2d710457c04d66332aebc4a80e6c964c665514a09c84d5ca374a426d