[INFO] fetching crate undo 0.51.0... [INFO] checking undo-0.51.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate undo 0.51.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate undo 0.51.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate undo 0.51.0 [INFO] finished tweaking crates.io crate undo 0.51.0 [INFO] tweaked toml for crates.io crate undo 0.51.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate undo 0.51.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1a7907d8c9c5f835564a2d46b4c8e4a823808cf24ee77ba0329da2f1aaadcc99 [INFO] running `Command { std: "docker" "start" "-a" "1a7907d8c9c5f835564a2d46b4c8e4a823808cf24ee77ba0329da2f1aaadcc99", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1a7907d8c9c5f835564a2d46b4c8e4a823808cf24ee77ba0329da2f1aaadcc99", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1a7907d8c9c5f835564a2d46b4c8e4a823808cf24ee77ba0329da2f1aaadcc99", kill_on_drop: false }` [INFO] [stdout] 1a7907d8c9c5f835564a2d46b4c8e4a823808cf24ee77ba0329da2f1aaadcc99 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d419bf3969cab67cd61ec79243f5ca9302b1764facb2e7c57badbe90d304de61 [INFO] running `Command { std: "docker" "start" "-a" "d419bf3969cab67cd61ec79243f5ca9302b1764facb2e7c57badbe90d304de61", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Checking iana-time-zone v0.1.57 [INFO] [stderr] Checking undo v0.51.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/entry.rs:59:15 [INFO] [stdout] | [INFO] [stdout] 55 | pub(crate) fn merge(&mut self, other: Self) -> Merged [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | match self.edit.merge(other.edit) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/history.rs:243:14 [INFO] [stdout] | [INFO] [stdout] 233 | let mut dest = self.branches.remove(&to)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 234 | let mut i = dest.parent.root; [INFO] [stdout] 235 | let mut path = alloc::vec![(to, dest)]; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 243 | Some(path.into_iter().rev()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/history.rs:417:23 [INFO] [stdout] | [INFO] [stdout] 411 | fn from(record: Record) -> Self { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 417 | branches: BTreeMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/history/builder.rs:23:17 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn capacity(self, capacity: usize) -> Builder { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | Builder(self.0.capacity(capacity)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/history/builder.rs:31:17 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn limit(self, limit: usize) -> Builder { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | Builder(self.0.limit(limit)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/history/builder.rs:37:17 [INFO] [stdout] | [INFO] [stdout] 36 | pub fn saved(self, saved: bool) -> Builder { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | Builder(self.0.saved(saved)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/history/builder.rs:42:17 [INFO] [stdout] | [INFO] [stdout] 41 | pub fn connect(self, slot: S) -> Builder { [INFO] [stdout] | ---- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | Builder(self.0.connect(slot)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/history/builder.rs:47:23 [INFO] [stdout] | [INFO] [stdout] 46 | pub fn build(self) -> History { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | History::from(self.0.build()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/history/queue.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 67 | pub fn commit(self, target: &mut E::Target) -> Vec { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | / self.entries [INFO] [stdout] 69 | | .into_iter() [INFO] [stdout] 70 | | .filter_map(|entry| match entry { [INFO] [stdout] 71 | | QueueEntry::Edit(edit) => Some(self.history.edit(target, edit)), [INFO] [stdout] 72 | | QueueEntry::Undo => self.history.undo(target), [INFO] [stdout] 73 | | QueueEntry::Redo => self.history.redo(target), [INFO] [stdout] 74 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/record.rs:117:29 [INFO] [stdout] | [INFO] [stdout] 116 | pub fn connect(&mut self, slot: S) -> Option { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 117 | self.socket.connect(Some(slot)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/record/builder.rs:65:22 [INFO] [stdout] | [INFO] [stdout] 59 | pub fn build(self) -> Record { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | entries: VecDeque::with_capacity(self.capacity), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/record/checkpoint.rs:60:9 [INFO] [stdout] | [INFO] [stdout] 59 | pub fn cancel(self, target: &mut E::Target) -> Vec { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | / self.entries [INFO] [stdout] 61 | | .into_iter() [INFO] [stdout] 62 | | .rev() [INFO] [stdout] 63 | | .filter_map(|entry| match entry { [INFO] [stdout] ... | [INFO] [stdout] 72 | | CheckpointEntry::Redo => self.record.undo(target), [INFO] [stdout] 73 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/record/queue.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 67 | pub fn commit(self, target: &mut E::Target) -> Vec { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | / self.entries [INFO] [stdout] 69 | | .into_iter() [INFO] [stdout] 70 | | .filter_map(|entry| match entry { [INFO] [stdout] 71 | | QueueEntry::Edit(edit) => Some(self.record.edit(target, edit)), [INFO] [stdout] 72 | | QueueEntry::Undo => self.record.undo(target), [INFO] [stdout] 73 | | QueueEntry::Redo => self.record.redo(target), [INFO] [stdout] 74 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/socket.rs:17:16 [INFO] [stdout] | [INFO] [stdout] 16 | pub const fn new(slot: S) -> Socket { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | Socket(Some(slot)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 14 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `undo` (lib) due to 15 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "d419bf3969cab67cd61ec79243f5ca9302b1764facb2e7c57badbe90d304de61", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d419bf3969cab67cd61ec79243f5ca9302b1764facb2e7c57badbe90d304de61", kill_on_drop: false }` [INFO] [stdout] d419bf3969cab67cd61ec79243f5ca9302b1764facb2e7c57badbe90d304de61