[INFO] fetching crate ultraman 0.3.2... [INFO] checking ultraman-0.3.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ultraman 0.3.2 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate ultraman 0.3.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ultraman 0.3.2 [INFO] finished tweaking crates.io crate ultraman 0.3.2 [INFO] tweaked toml for crates.io crate ultraman 0.3.2 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate ultraman 0.3.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2e24865a10517f9a43c8e16cba0218dd39a83b72e42724fa90ac1f87b112abad [INFO] running `Command { std: "docker" "start" "-a" "2e24865a10517f9a43c8e16cba0218dd39a83b72e42724fa90ac1f87b112abad", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2e24865a10517f9a43c8e16cba0218dd39a83b72e42724fa90ac1f87b112abad", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2e24865a10517f9a43c8e16cba0218dd39a83b72e42724fa90ac1f87b112abad", kill_on_drop: false }` [INFO] [stdout] 2e24865a10517f9a43c8e16cba0218dd39a83b72e42724fa90ac1f87b112abad [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3d0e0483c35aeb017d503a0b87073859dba1f2c659819cddde9bab7e4daa923c [INFO] running `Command { std: "docker" "start" "-a" "3d0e0483c35aeb017d503a0b87073859dba1f2c659819cddde9bab7e4daa923c", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling proc-macro2 v1.0.36 [INFO] [stderr] Compiling libc v0.2.121 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling syn v1.0.89 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Compiling crossbeam-utils v0.8.8 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling ucd-trie v0.1.3 [INFO] [stderr] Compiling serde v1.0.136 [INFO] [stderr] Compiling maplit v1.0.2 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling log v0.4.16 [INFO] [stderr] Compiling crossbeam-queue v0.3.5 [INFO] [stderr] Compiling unicode-segmentation v1.9.0 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking unicode-width v0.1.9 [INFO] [stderr] Compiling serde_json v1.0.79 [INFO] [stderr] Checking ryu v1.0.9 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling signal-hook v0.3.13 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Compiling pest v2.1.3 [INFO] [stderr] Checking itoa v1.0.1 [INFO] [stderr] Compiling serde_derive v1.0.136 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling crossbeam-epoch v0.9.8 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking crossbeam-channel v0.5.4 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking quick-error v2.0.1 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Checking linked-hash-map v0.5.4 [INFO] [stderr] Compiling anyhow v1.0.56 [INFO] [stderr] Checking dotenv v0.15.0 [INFO] [stderr] Checking fastrand v1.7.0 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Compiling pest_meta v2.1.3 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Checking crossbeam-deque v0.8.1 [INFO] [stderr] Compiling quote v1.0.17 [INFO] [stderr] Checking crossbeam v0.8.1 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking nix v0.23.1 [INFO] [stderr] Checking tempfile v3.3.0 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking colored v2.0.0 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking regex v1.5.5 [INFO] [stderr] Checking shellwords v1.1.0 [INFO] [stderr] Compiling pest_generator v2.1.3 [INFO] [stderr] Compiling pest_derive v2.1.0 [INFO] [stderr] Compiling structopt-derive v0.4.18 [INFO] [stderr] Checking handlebars v4.2.2 [INFO] [stderr] Checking structopt v0.3.26 [INFO] [stderr] Checking ultraman v0.3.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: method `chown` is never used [INFO] [stdout] --> src/cmd/export/base.rs:75:8 [INFO] [stdout] | [INFO] [stdout] 27 | pub trait Exportable { [INFO] [stdout] | ---------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 75 | fn chown(&self, username: &str, dir: &PathBuf) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `opts` is never read [INFO] [stdout] --> src/process.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 17 | pub struct Process { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 21 | pub opts: Option, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmd/export/base.rs:72:32 [INFO] [stdout] | [INFO] [stdout] 72 | .unwrap_or_else(|| env::current_dir().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/process.rs:66:5 [INFO] [stdout] | [INFO] [stdout] 62 | pub fn build_exec_and_output_thread(yielder: F) -> JoinHandle<()> [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 66 | / thread::Builder::new() [INFO] [stdout] 67 | | .name(String::from("handle exec and output")) [INFO] [stdout] 68 | | .spawn(move || { [INFO] [stdout] 69 | | yielder(); [INFO] [stdout] 70 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/process.rs:78:5 [INFO] [stdout] | [INFO] [stdout] 75 | procs: Arc>>>>, [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | / thread::Builder::new() [INFO] [stdout] 79 | | .name(String::from(format!("check child terminated"))) [INFO] [stdout] 80 | | .spawn(move || { [INFO] [stdout] 81 | | loop { [INFO] [stdout] ... | [INFO] [stdout] 91 | | } [INFO] [stdout] 92 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/signal.rs:24:13 [INFO] [stdout] | [INFO] [stdout] 17 | procs: Arc>>>>, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | trap_signal_at_multithred(procs, timeout, opts).expect("failed trap signals") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream_read.rs:26:20 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn new(mut stream: Box) -> PipeStreamReader { [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | PipeStreamReader { [INFO] [stdout] 26 | lines: { [INFO] [stdout] | ____________________^ [INFO] [stdout] 27 | | let (tx, rx) = unbounded(); [INFO] [stdout] 28 | | [INFO] [stdout] 29 | | spawn(move || { [INFO] [stdout] ... | [INFO] [stdout] 63 | | rx [INFO] [stdout] 64 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ultraman` (bin "ultraman") due to 6 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: method `chown` is never used [INFO] [stdout] --> src/cmd/export/base.rs:75:8 [INFO] [stdout] | [INFO] [stdout] 27 | pub trait Exportable { [INFO] [stdout] | ---------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 75 | fn chown(&self, username: &str, dir: &PathBuf) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `opts` is never read [INFO] [stdout] --> src/process.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 17 | pub struct Process { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 21 | pub opts: Option, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmd/export/base.rs:72:32 [INFO] [stdout] | [INFO] [stdout] 72 | .unwrap_or_else(|| env::current_dir().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/process.rs:66:5 [INFO] [stdout] | [INFO] [stdout] 62 | pub fn build_exec_and_output_thread(yielder: F) -> JoinHandle<()> [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 66 | / thread::Builder::new() [INFO] [stdout] 67 | | .name(String::from("handle exec and output")) [INFO] [stdout] 68 | | .spawn(move || { [INFO] [stdout] 69 | | yielder(); [INFO] [stdout] 70 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/process.rs:78:5 [INFO] [stdout] | [INFO] [stdout] 75 | procs: Arc>>>>, [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | / thread::Builder::new() [INFO] [stdout] 79 | | .name(String::from(format!("check child terminated"))) [INFO] [stdout] 80 | | .spawn(move || { [INFO] [stdout] 81 | | loop { [INFO] [stdout] ... | [INFO] [stdout] 91 | | } [INFO] [stdout] 92 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/signal.rs:24:13 [INFO] [stdout] | [INFO] [stdout] 17 | procs: Arc>>>>, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | trap_signal_at_multithred(procs, timeout, opts).expect("failed trap signals") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/signal.rs:225:13 [INFO] [stdout] | [INFO] [stdout] 223 | let procs2 = Arc::clone(&procs); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 224 | let thread_trap_signal = thread::spawn(move || { [INFO] [stdout] 225 | / trap_signal_at_multithred( [INFO] [stdout] 226 | | procs2, [INFO] [stdout] 227 | | 5, [INFO] [stdout] 228 | | DisplayOpts { [INFO] [stdout] ... | [INFO] [stdout] 231 | | }, [INFO] [stdout] 232 | | ) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream_read.rs:26:20 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn new(mut stream: Box) -> PipeStreamReader { [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | PipeStreamReader { [INFO] [stdout] 26 | lines: { [INFO] [stdout] | ____________________^ [INFO] [stdout] 27 | | let (tx, rx) = unbounded(); [INFO] [stdout] 28 | | [INFO] [stdout] 29 | | spawn(move || { [INFO] [stdout] ... | [INFO] [stdout] 63 | | rx [INFO] [stdout] 64 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ultraman` (bin "ultraman" test) due to 7 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "3d0e0483c35aeb017d503a0b87073859dba1f2c659819cddde9bab7e4daa923c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3d0e0483c35aeb017d503a0b87073859dba1f2c659819cddde9bab7e4daa923c", kill_on_drop: false }` [INFO] [stdout] 3d0e0483c35aeb017d503a0b87073859dba1f2c659819cddde9bab7e4daa923c