[INFO] fetching crate ulog 0.3.0... [INFO] checking ulog-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ulog 0.3.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate ulog 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ulog 0.3.0 [INFO] finished tweaking crates.io crate ulog 0.3.0 [INFO] tweaked toml for crates.io crate ulog 0.3.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 5 packages to latest compatible versions [INFO] [stderr] Adding log v0.3.9 (latest: v0.4.22) [INFO] [stderr] Adding thread_local v0.3.6 (latest: v1.1.8) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8cb54b743e50df09d74b5d0710231a953176443e07a2e4d2512969f23891a914 [INFO] running `Command { std: "docker" "start" "-a" "8cb54b743e50df09d74b5d0710231a953176443e07a2e4d2512969f23891a914", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8cb54b743e50df09d74b5d0710231a953176443e07a2e4d2512969f23891a914", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8cb54b743e50df09d74b5d0710231a953176443e07a2e4d2512969f23891a914", kill_on_drop: false }` [INFO] [stdout] 8cb54b743e50df09d74b5d0710231a953176443e07a2e4d2512969f23891a914 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 23cd2848d88adecdc3fdb75e49f57ce71df77a57f1298940e42dc34e8b0d58f2 [INFO] running `Command { std: "docker" "start" "-a" "23cd2848d88adecdc3fdb75e49f57ce71df77a57f1298940e42dc34e8b0d58f2", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Checking log v0.3.9 [INFO] [stderr] Checking ulog v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused `#[macro_use]` import [INFO] [stdout] --> src/lib.rs:37:1 [INFO] [stdout] | [INFO] [stdout] 37 | #[macro_use] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `#[macro_use]` import [INFO] [stdout] --> src/lib.rs:37:1 [INFO] [stdout] | [INFO] [stdout] 37 | #[macro_use] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:104:10 [INFO] [stdout] | [INFO] [stdout] 102 | let (tx, rx) = sync_channel(bufsize); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | [INFO] [stdout] 104 | (AsyncLogger { [INFO] [stdout] | __________^ [INFO] [stdout] 105 | | failures: AtomicUsize::new(0), [INFO] [stdout] 106 | | sender: Mutex::new(tx), [INFO] [stdout] 107 | | local_sender: ThreadLocal::new(), [INFO] [stdout] 108 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:175:21 [INFO] [stdout] | [INFO] [stdout] 158 | pub fn init(bufsize: usize, mut handle: F) -> Result<(), log::SetLoggerError> [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 162 | let (logger, rx) = AsyncLogger::new(bufsize); [INFO] [stdout] | ------ -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 175 | log::set_logger(move |max_log_level| { [INFO] [stdout] | _____________________^ [INFO] [stdout] 176 | | // FIXME: max_log_level ignored? [INFO] [stdout] 177 | | max_log_level.set(LogLevelFilter::Debug); [INFO] [stdout] 178 | | Box::new(logger) [INFO] [stdout] 179 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:104:10 [INFO] [stdout] | [INFO] [stdout] 102 | let (tx, rx) = sync_channel(bufsize); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | [INFO] [stdout] 104 | (AsyncLogger { [INFO] [stdout] | __________^ [INFO] [stdout] 105 | | failures: AtomicUsize::new(0), [INFO] [stdout] 106 | | sender: Mutex::new(tx), [INFO] [stdout] 107 | | local_sender: ThreadLocal::new(), [INFO] [stdout] 108 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:175:21 [INFO] [stdout] | [INFO] [stdout] 158 | pub fn init(bufsize: usize, mut handle: F) -> Result<(), log::SetLoggerError> [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 162 | let (logger, rx) = AsyncLogger::new(bufsize); [INFO] [stdout] | ------ -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 175 | log::set_logger(move |max_log_level| { [INFO] [stdout] | _____________________^ [INFO] [stdout] 176 | | // FIXME: max_log_level ignored? [INFO] [stdout] 177 | | max_log_level.set(LogLevelFilter::Debug); [INFO] [stdout] 178 | | Box::new(logger) [INFO] [stdout] 179 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ulog` (lib) due to 3 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ulog` (lib test) due to 3 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "23cd2848d88adecdc3fdb75e49f57ce71df77a57f1298940e42dc34e8b0d58f2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "23cd2848d88adecdc3fdb75e49f57ce71df77a57f1298940e42dc34e8b0d58f2", kill_on_drop: false }` [INFO] [stdout] 23cd2848d88adecdc3fdb75e49f57ce71df77a57f1298940e42dc34e8b0d58f2