[INFO] fetching crate uggo-ugg-api 0.3.0... [INFO] checking uggo-ugg-api-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate uggo-ugg-api 0.3.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate uggo-ugg-api 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate uggo-ugg-api 0.3.0 [INFO] finished tweaking crates.io crate uggo-ugg-api 0.3.0 [INFO] tweaked toml for crates.io crate uggo-ugg-api 0.3.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 163 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding base64 v0.21.7 (latest: v0.22.1) [INFO] [stderr] Adding cacache v11.7.1 (latest: v13.0.0) [INFO] [stderr] Adding core-foundation v0.9.4 (latest: v0.10.0) [INFO] [stderr] Adding foreign-types v0.3.2 (latest: v0.5.0) [INFO] [stderr] Adding foreign-types-shared v0.1.1 (latest: v0.3.1) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding memmap2 v0.5.10 (latest: v0.9.4) [INFO] [stderr] Adding miette v5.10.0 (latest: v7.2.0) [INFO] [stderr] Adding miette-derive v5.10.0 (latest: v7.2.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b20fdd22c3c90e11290d18a234980cfba3bb2da503ff077b12c16d1bc7503fd4 [INFO] running `Command { std: "docker" "start" "-a" "b20fdd22c3c90e11290d18a234980cfba3bb2da503ff077b12c16d1bc7503fd4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b20fdd22c3c90e11290d18a234980cfba3bb2da503ff077b12c16d1bc7503fd4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b20fdd22c3c90e11290d18a234980cfba3bb2da503ff077b12c16d1bc7503fd4", kill_on_drop: false }` [INFO] [stdout] b20fdd22c3c90e11290d18a234980cfba3bb2da503ff077b12c16d1bc7503fd4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d2efe2a76f9d6bbf634a9d3b5a9ff521665c832995b1e1a4857d96b895f29ede [INFO] running `Command { std: "docker" "start" "-a" "d2efe2a76f9d6bbf634a9d3b5a9ff521665c832995b1e1a4857d96b895f29ede", kill_on_drop: false }` [INFO] [stderr] Compiling shlex v1.3.0 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling vcpkg v0.2.15 [INFO] [stderr] Compiling pkg-config v0.3.30 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking tinyvec_macros v0.1.1 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking cpufeatures v0.2.13 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Checking ahash v0.8.11 [INFO] [stderr] Checking lexical-util v0.8.5 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking rustls-pki-types v1.8.0 [INFO] [stderr] Compiling cc v1.1.15 [INFO] [stderr] Checking tinyvec v1.8.0 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking foreign-types-shared v0.1.1 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking untrusted v0.9.0 [INFO] [stderr] Compiling openssl v0.10.66 [INFO] [stderr] Checking foreign-types v0.3.2 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Compiling native-tls v0.2.12 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Checking percent-encoding v2.3.1 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Compiling rustls v0.23.12 [INFO] [stderr] Checking alloc-no-stdlib v2.0.4 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Compiling ref-cast v1.0.23 [INFO] [stderr] Checking alloc-stdlib v0.2.2 [INFO] [stderr] Checking openssl-probe v0.1.5 [INFO] [stderr] Checking fastrand v2.1.1 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking base64 v0.21.7 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking xxhash-rust v0.8.12 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking brotli-decompressor v4.0.1 [INFO] [stderr] Checking webpki-roots v0.26.5 [INFO] [stderr] Checking memmap2 v0.5.10 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Checking simdutf8 v0.1.4 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking levenshtein v1.0.5 [INFO] [stderr] Checking lexical-write-integer v0.8.5 [INFO] [stderr] Checking lexical-parse-integer v0.8.6 [INFO] [stderr] Checking lru v0.12.4 [INFO] [stderr] Checking lexical-write-float v0.8.5 [INFO] [stderr] Checking float-cmp v0.9.0 [INFO] [stderr] Checking lexical-parse-float v0.8.5 [INFO] [stderr] Compiling openssl-sys v0.9.103 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking lexical-core v0.8.5 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking sha-1 v0.10.1 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking reflink-copy v0.1.19 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling miette-derive v5.10.0 [INFO] [stderr] Compiling ref-cast-impl v1.0.23 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking miette v5.10.0 [INFO] [stderr] Checking rustls-webpki v0.102.7 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking tokio-stream v0.1.15 [INFO] [stderr] Checking ssri v9.2.0 [INFO] [stderr] Checking halfbrown v0.2.5 [INFO] [stderr] Checking ugg-types v0.6.0 [INFO] [stderr] Checking value-trait v0.8.1 [INFO] [stderr] Checking cacache v11.7.1 [INFO] [stderr] Checking simd-json v0.13.10 [INFO] [stderr] Checking ureq v2.10.1 [INFO] [stderr] Checking ddragon v0.8.2 [INFO] [stderr] Checking uggo-ugg-api v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:79:12 [INFO] [stdout] | [INFO] [stdout] 69 | let mut client_builder = ClientBuilder::new(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 80 | | agent: Agent::new(), [INFO] [stdout] 81 | | ddragon: client_builder.build()?, [INFO] [stdout] 82 | | overview_cache: RefCell::new(LruCache::new(cache_size)), [INFO] [stdout] 83 | | matchup_cache: RefCell::new(LruCache::new(cache_size)), [INFO] [stdout] 84 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:210:20 [INFO] [stdout] | [INFO] [stdout] 210 | .ok_or(UggError::MissingRole) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:269:20 [INFO] [stdout] | [INFO] [stdout] 269 | .ok_or(UggError::MissingRole) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:310:12 [INFO] [stdout] | [INFO] [stdout] 275 | let mut inner_api = DataApi::new(version, cache_dir.clone())?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 310 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 311 | | api: inner_api, [INFO] [stdout] 312 | | allowed_versions: versions_ugg_supports, [INFO] [stdout] 313 | | ugg_api_versions, [INFO] [stdout] ... | [INFO] [stdout] 319 | | summoner_spells, [INFO] [stdout] 320 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `uggo-ugg-api` (lib test) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:79:12 [INFO] [stdout] | [INFO] [stdout] 69 | let mut client_builder = ClientBuilder::new(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 80 | | agent: Agent::new(), [INFO] [stdout] 81 | | ddragon: client_builder.build()?, [INFO] [stdout] 82 | | overview_cache: RefCell::new(LruCache::new(cache_size)), [INFO] [stdout] 83 | | matchup_cache: RefCell::new(LruCache::new(cache_size)), [INFO] [stdout] 84 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:210:20 [INFO] [stdout] | [INFO] [stdout] 210 | .ok_or(UggError::MissingRole) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:269:20 [INFO] [stdout] | [INFO] [stdout] 269 | .ok_or(UggError::MissingRole) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:310:12 [INFO] [stdout] | [INFO] [stdout] 275 | let mut inner_api = DataApi::new(version, cache_dir.clone())?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 310 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 311 | | api: inner_api, [INFO] [stdout] 312 | | allowed_versions: versions_ugg_supports, [INFO] [stdout] 313 | | ugg_api_versions, [INFO] [stdout] ... | [INFO] [stdout] 319 | | summoner_spells, [INFO] [stdout] 320 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `uggo-ugg-api` (lib) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "d2efe2a76f9d6bbf634a9d3b5a9ff521665c832995b1e1a4857d96b895f29ede", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d2efe2a76f9d6bbf634a9d3b5a9ff521665c832995b1e1a4857d96b895f29ede", kill_on_drop: false }` [INFO] [stdout] d2efe2a76f9d6bbf634a9d3b5a9ff521665c832995b1e1a4857d96b895f29ede