[INFO] fetching crate ufire_sht20 0.9.1... [INFO] checking ufire_sht20-0.9.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ufire_sht20 0.9.1 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate ufire_sht20 0.9.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ufire_sht20 0.9.1 [INFO] finished tweaking crates.io crate ufire_sht20 0.9.1 [INFO] tweaked toml for crates.io crate ufire_sht20 0.9.1 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate ufire_sht20 0.9.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 392b394dfaaea12916b5bd88f00a0de05188be471c991dbc78a92f3afa2da21b [INFO] running `Command { std: "docker" "start" "-a" "392b394dfaaea12916b5bd88f00a0de05188be471c991dbc78a92f3afa2da21b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "392b394dfaaea12916b5bd88f00a0de05188be471c991dbc78a92f3afa2da21b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "392b394dfaaea12916b5bd88f00a0de05188be471c991dbc78a92f3afa2da21b", kill_on_drop: false }` [INFO] [stdout] 392b394dfaaea12916b5bd88f00a0de05188be471c991dbc78a92f3afa2da21b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e2ae13d85af35b88e4e1fc8b18054745c9dafcfbe4e841dec14a6958cdbd4231 [INFO] running `Command { std: "docker" "start" "-a" "e2ae13d85af35b88e4e1fc8b18054745c9dafcfbe4e841dec14a6958cdbd4231", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling serde v1.0.88 [INFO] [stderr] Compiling libc v0.2.37 [INFO] [stderr] Compiling cc v1.0.5 [INFO] [stderr] Compiling unicode-xid v0.0.4 [INFO] [stderr] Compiling winapi-build v0.1.1 [INFO] [stderr] Compiling quote v0.3.15 [INFO] [stderr] Compiling winapi v0.2.8 [INFO] [stderr] Compiling rustc-demangle v0.1.7 [INFO] [stderr] Compiling synom v0.11.3 [INFO] [stderr] Compiling cfg-if v0.1.2 [INFO] [stderr] Compiling memchr v2.2.0 [INFO] [stderr] Compiling kernel32-sys v0.2.2 [INFO] [stderr] Compiling pulldown-cmark v0.1.2 [INFO] [stderr] Compiling syn v0.11.11 [INFO] [stderr] Compiling dtoa v0.4.2 [INFO] [stderr] Compiling itoa v0.3.4 [INFO] [stderr] Compiling num-traits v0.2.1 [INFO] [stderr] Checking byteorder v1.2.1 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Compiling remove_dir_all v0.3.0 [INFO] [stderr] Compiling rand v0.4.2 [INFO] [stderr] Compiling bitflags v0.9.1 [INFO] [stderr] Compiling same-file v0.1.3 [INFO] [stderr] Compiling backtrace-sys v0.1.16 [INFO] [stderr] Compiling walkdir v1.0.7 [INFO] [stderr] Compiling glob v0.2.11 [INFO] [stderr] Compiling bytecount v0.2.0 [INFO] [stderr] Checking csv-core v0.1.5 [INFO] [stderr] Checking iovec v0.1.2 [INFO] [stderr] Compiling nix v0.10.0 [INFO] [stderr] Checking bytes v0.4.6 [INFO] [stderr] Checking term v0.5.1 [INFO] [stderr] Compiling serde_derive_internals v0.19.0 [INFO] [stderr] Compiling tempdir v0.3.6 [INFO] [stderr] Checking atty v0.2.11 [INFO] [stderr] Checking lazy_static v1.2.0 [INFO] [stderr] Checking bitflags v1.0.1 [INFO] [stderr] Checking encode_unicode v0.3.5 [INFO] [stderr] Checking unicode-width v0.1.5 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Compiling serde_derive v1.0.27 [INFO] [stderr] Compiling semver v0.8.0 [INFO] [stderr] Compiling serde_json v1.0.10 [INFO] [stderr] Checking csv v1.0.5 [INFO] [stderr] Checking prettytable-rs v0.8.0 [INFO] [stderr] Checking shrust v0.0.6 [INFO] [stderr] Compiling backtrace v0.3.5 [INFO] [stderr] Compiling error-chain v0.11.0 [INFO] [stderr] Compiling cargo_metadata v0.3.3 [INFO] [stderr] Compiling skeptic v0.13.2 [INFO] [stderr] Compiling i2cdev v0.3.2 [INFO] [stderr] Checking ufire_sht20 v0.9.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/lib.rs:61:45 [INFO] [stdout] | [INFO] [stdout] 61 | pub fn temperature(&mut self) -> Result<(f32), Box> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 61 - pub fn temperature(&mut self) -> Result<(f32), Box> { [INFO] [stdout] 61 + pub fn temperature(&mut self) -> Result> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/lib.rs:80:42 [INFO] [stdout] | [INFO] [stdout] 80 | pub fn humidity(&mut self) -> Result<(f32), Box> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 80 - pub fn humidity(&mut self) -> Result<(f32), Box> { [INFO] [stdout] 80 + pub fn humidity(&mut self) -> Result> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/lib.rs:125:62 [INFO] [stdout] | [INFO] [stdout] 125 | pub fn _read_register(&mut self, register: u8) -> Result<(f32), Box> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 125 - pub fn _read_register(&mut self, register: u8) -> Result<(f32), Box> { [INFO] [stdout] 125 + pub fn _read_register(&mut self, register: u8) -> Result> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/lib.rs:61:45 [INFO] [stdout] | [INFO] [stdout] 61 | pub fn temperature(&mut self) -> Result<(f32), Box> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 61 - pub fn temperature(&mut self) -> Result<(f32), Box> { [INFO] [stdout] 61 + pub fn temperature(&mut self) -> Result> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/lib.rs:80:42 [INFO] [stdout] | [INFO] [stdout] 80 | pub fn humidity(&mut self) -> Result<(f32), Box> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 80 - pub fn humidity(&mut self) -> Result<(f32), Box> { [INFO] [stdout] 80 + pub fn humidity(&mut self) -> Result> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/lib.rs:125:62 [INFO] [stdout] | [INFO] [stdout] 125 | pub fn _read_register(&mut self, register: u8) -> Result<(f32), Box> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 125 - pub fn _read_register(&mut self, register: u8) -> Result<(f32), Box> { [INFO] [stdout] 125 + pub fn _read_register(&mut self, register: u8) -> Result> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:51:12 [INFO] [stdout] | [INFO] [stdout] 49 | let dev = LinuxI2CDevice::new(filename, SHT20_I2C)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | [INFO] [stdout] 51 | Ok(SHT20 { dev: Box::new(dev) }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:51:12 [INFO] [stdout] | [INFO] [stdout] 49 | let dev = LinuxI2CDevice::new(filename, SHT20_I2C)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | [INFO] [stdout] 51 | Ok(SHT20 { dev: Box::new(dev) }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ufire_sht20` (lib) due to 2 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `ufire_sht20` (lib test) due to 2 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "e2ae13d85af35b88e4e1fc8b18054745c9dafcfbe4e841dec14a6958cdbd4231", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e2ae13d85af35b88e4e1fc8b18054745c9dafcfbe4e841dec14a6958cdbd4231", kill_on_drop: false }` [INFO] [stdout] e2ae13d85af35b88e4e1fc8b18054745c9dafcfbe4e841dec14a6958cdbd4231