[INFO] fetching crate uds-rs 0.1.0... [INFO] checking uds-rs-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate uds-rs 0.1.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate uds-rs 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate uds-rs 0.1.0 [INFO] finished tweaking crates.io crate uds-rs 0.1.0 [INFO] tweaked toml for crates.io crate uds-rs 0.1.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate uds-rs 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3c4cd3f7c59fff5feb427d838e183a20b1f5baef663e4be60abccb8cd60ffab1 [INFO] running `Command { std: "docker" "start" "-a" "3c4cd3f7c59fff5feb427d838e183a20b1f5baef663e4be60abccb8cd60ffab1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3c4cd3f7c59fff5feb427d838e183a20b1f5baef663e4be60abccb8cd60ffab1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3c4cd3f7c59fff5feb427d838e183a20b1f5baef663e4be60abccb8cd60ffab1", kill_on_drop: false }` [INFO] [stdout] 3c4cd3f7c59fff5feb427d838e183a20b1f5baef663e4be60abccb8cd60ffab1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] df8baa51006cb3f37cc10c8d0c768c51c3dacd070539307303cbbd7f24236f7d [INFO] running `Command { std: "docker" "start" "-a" "df8baa51006cb3f37cc10c8d0c768c51c3dacd070539307303cbbd7f24236f7d", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling proc-macro2 v1.0.76 [INFO] [stderr] Compiling libc v0.2.152 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Compiling equivalent v1.0.1 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Compiling hashbrown v0.14.3 [INFO] [stderr] Compiling parking_lot_core v0.9.9 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking smallvec v1.11.2 [INFO] [stderr] Compiling winnow v0.5.33 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking bitflags v2.4.1 [INFO] [stderr] Compiling toml_datetime v0.6.5 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Compiling rustix v0.38.28 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling thiserror v1.0.56 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Checking nb v1.1.0 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking linux-raw-sys v0.4.12 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking embedded-can v0.4.1 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Compiling memoffset v0.7.1 [INFO] [stderr] Checking futures-timer v3.0.2 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking termcolor v1.4.0 [INFO] [stderr] Compiling indexmap v2.1.0 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Checking regex-automata v0.4.3 [INFO] [stderr] Checking is-terminal v0.4.10 [INFO] [stderr] Compiling toml_edit v0.21.0 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking mio v0.8.10 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking socket2 v0.5.5 [INFO] [stderr] Checking nix v0.26.4 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling proc-macro-crate v3.0.0 [INFO] [stderr] Checking regex v1.10.2 [INFO] [stderr] Checking env_logger v0.10.1 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling thiserror-impl v1.0.56 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling num_enum_derive v0.7.2 [INFO] [stderr] Checking tokio v1.35.1 [INFO] [stderr] Checking num_enum v0.7.2 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking tokio-socketcan-isotp v0.1.0 [INFO] [stderr] Checking uds-rs v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `crate::uds::clear_diagnostic_information::*` [INFO] [stdout] --> src/uds.rs:88:9 [INFO] [stdout] | [INFO] [stdout] 88 | pub use crate::uds::clear_diagnostic_information::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::uds::clear_diagnostic_information::*` [INFO] [stdout] --> src/uds.rs:88:9 [INFO] [stdout] | [INFO] [stdout] 88 | pub use crate::uds::clear_diagnostic_information::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `dtc_and_status_record` [INFO] [stdout] --> src/uds/read_dtc_information.rs:668:13 [INFO] [stdout] | [INFO] [stdout] 668 | let dtc_and_status_record: Vec = vec![]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_dtc_and_status_record` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/uds.rs:194:12 [INFO] [stdout] | [INFO] [stdout] 191 | src: impl Into, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 192 | dst: impl Into, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 193 | ) -> Result { [INFO] [stdout] 194 | Ok(UdsClient { [INFO] [stdout] | ____________^ [INFO] [stdout] 195 | | socket: UdsSocket::new(canifc, src, dst)?, [INFO] [stdout] 196 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/uds/communication.rs:51:12 [INFO] [stdout] | [INFO] [stdout] 48 | src: impl Into, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | dst: impl Into, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | ) -> Result { [INFO] [stdout] 51 | Ok(UdsSocket { [INFO] [stdout] | ____________^ [INFO] [stdout] 52 | | isotp_socket: tokio_socketcan_isotp::IsoTpSocket::open(ifname, src, dst)?, [INFO] [stdout] 53 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/uds/communication.rs:63:12 [INFO] [stdout] | [INFO] [stdout] 57 | src: impl Into, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | dst: impl Into, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | Ok(UdsSocket { [INFO] [stdout] | ____________^ [INFO] [stdout] 64 | | isotp_socket: tokio_socketcan_isotp::IsoTpSocket::open_with_opts( [INFO] [stdout] 65 | | ifname, [INFO] [stdout] 66 | | src, [INFO] [stdout] ... | [INFO] [stdout] 71 | | )?, [INFO] [stdout] 72 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/uds.rs:194:12 [INFO] [stdout] | [INFO] [stdout] 191 | src: impl Into, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 192 | dst: impl Into, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 193 | ) -> Result { [INFO] [stdout] 194 | Ok(UdsClient { [INFO] [stdout] | ____________^ [INFO] [stdout] 195 | | socket: UdsSocket::new(canifc, src, dst)?, [INFO] [stdout] 196 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/uds/communication.rs:51:12 [INFO] [stdout] | [INFO] [stdout] 48 | src: impl Into, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | dst: impl Into, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | ) -> Result { [INFO] [stdout] 51 | Ok(UdsSocket { [INFO] [stdout] | ____________^ [INFO] [stdout] 52 | | isotp_socket: tokio_socketcan_isotp::IsoTpSocket::open(ifname, src, dst)?, [INFO] [stdout] 53 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/uds/communication.rs:63:12 [INFO] [stdout] | [INFO] [stdout] 57 | src: impl Into, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | dst: impl Into, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | Ok(UdsSocket { [INFO] [stdout] | ____________^ [INFO] [stdout] 64 | | isotp_socket: tokio_socketcan_isotp::IsoTpSocket::open_with_opts( [INFO] [stdout] 65 | | ifname, [INFO] [stdout] 66 | | src, [INFO] [stdout] ... | [INFO] [stdout] 71 | | )?, [INFO] [stdout] 72 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `uds-rs` (lib) due to 4 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 3 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `uds-rs` (lib test) due to 4 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "df8baa51006cb3f37cc10c8d0c768c51c3dacd070539307303cbbd7f24236f7d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "df8baa51006cb3f37cc10c8d0c768c51c3dacd070539307303cbbd7f24236f7d", kill_on_drop: false }` [INFO] [stdout] df8baa51006cb3f37cc10c8d0c768c51c3dacd070539307303cbbd7f24236f7d