[INFO] fetching crate ubs-lib 0.1.1... [INFO] checking ubs-lib-0.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ubs-lib 0.1.1 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate ubs-lib 0.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ubs-lib 0.1.1 [INFO] finished tweaking crates.io crate ubs-lib 0.1.1 [INFO] tweaked toml for crates.io crate ubs-lib 0.1.1 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 111 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding base64 v0.21.7 (latest: v0.22.1) [INFO] [stderr] Adding cookie v0.17.0 (latest: v0.18.1) [INFO] [stderr] Adding core-foundation v0.9.4 (latest: v0.10.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding http v0.2.12 (latest: v1.1.0) [INFO] [stderr] Adding http-body v0.4.6 (latest: v1.0.1) [INFO] [stderr] Adding hyper v0.14.30 (latest: v1.4.1) [INFO] [stderr] Adding hyper-rustls v0.24.2 (latest: v0.27.2) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding rustls v0.21.12 (latest: v0.23.12) [INFO] [stderr] Adding rustls-native-certs v0.6.3 (latest: v0.8.0) [INFO] [stderr] Adding rustls-pemfile v1.0.4 (latest: v2.1.3) [INFO] [stderr] Adding rustls-webpki v0.101.7 (latest: v0.102.7) [INFO] [stderr] Adding tokio-rustls v0.24.1 (latest: v0.26.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3bb1f8c93f99dc81c0a4f1670f5ea2e8b22abfe5ef75eeec379838d320666107 [INFO] running `Command { std: "docker" "start" "-a" "3bb1f8c93f99dc81c0a4f1670f5ea2e8b22abfe5ef75eeec379838d320666107", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3bb1f8c93f99dc81c0a4f1670f5ea2e8b22abfe5ef75eeec379838d320666107", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3bb1f8c93f99dc81c0a4f1670f5ea2e8b22abfe5ef75eeec379838d320666107", kill_on_drop: false }` [INFO] [stdout] 3bb1f8c93f99dc81c0a4f1670f5ea2e8b22abfe5ef75eeec379838d320666107 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 335301ff13228419d02b4808079103d5febef4aa51ca44f1947c3fd122334cda [INFO] running `Command { std: "docker" "start" "-a" "335301ff13228419d02b4808079103d5febef4aa51ca44f1947c3fd122334cda", kill_on_drop: false }` [INFO] [stderr] Compiling cc v1.1.15 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling rustls v0.21.12 [INFO] [stderr] Compiling time-core v0.1.2 [INFO] [stderr] Compiling num-conv v0.1.0 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Checking powerfmt v0.2.0 [INFO] [stderr] Checking rustls-pemfile v1.0.4 [INFO] [stderr] Compiling cookie v0.17.0 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Checking tower-service v0.3.3 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Checking rustls-native-certs v0.6.3 [INFO] [stderr] Checking tl v0.7.8 [INFO] [stderr] Compiling time-macros v0.2.18 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking hyper v0.14.30 [INFO] [stderr] Checking rustls-webpki v0.101.7 [INFO] [stderr] Checking sct v0.7.1 [INFO] [stderr] Checking tokio-rustls v0.24.1 [INFO] [stderr] Checking hyper-rustls v0.24.2 [INFO] [stderr] Checking ubs-lib v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:94:12 [INFO] [stdout] | [INFO] [stdout] 92 | let dom = unsafe { tl::parse_owned(String::from_utf8(bytes)?, ParserOptions::default())? }; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | [INFO] [stdout] 94 | Ok(Self { dom, page }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session.rs:72:9 [INFO] [stdout] | [INFO] [stdout] 70 | let client = self.client.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | let token = self.token.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | / stream::iter(1..) [INFO] [stdout] 73 | | .then(move |page_num| { [INFO] [stdout] 74 | | // Cloning `client` and `token` above is to avoid having the closure live as long [INFO] [stdout] 75 | | // as `self`. Cloning again is necessary because new ownership is needed for each [INFO] [stdout] ... | [INFO] [stdout] 87 | | }) [INFO] [stdout] 88 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session.rs:83:26 [INFO] [stdout] | [INFO] [stdout] 70 | let client = self.client.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | let token = self.token.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | let client = client.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | let token = token.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | Box::pin(async move { [INFO] [stdout] | __________________________^ [INFO] [stdout] 84 | | Ok(Self::get_page(client, token, query, page_num) [INFO] [stdout] 85 | | .await? [INFO] [stdout] 86 | | .await?) [INFO] [stdout] 87 | | }) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session.rs:84:24 [INFO] [stdout] | [INFO] [stdout] 77 | let client = client.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | let token = token.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | Ok(Self::get_page(client, token, query, page_num) [INFO] [stdout] | ________________________^ [INFO] [stdout] 85 | | .await? [INFO] [stdout] 86 | | .await?) [INFO] [stdout] | |_______________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session.rs:89:43 [INFO] [stdout] | [INFO] [stdout] 89 | .and_then(|response| Box::pin(body::to_bytes(response.into_body()).err_into())) [INFO] [stdout] | -------- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ubs-lib` (lib) due to 6 previous errors [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:94:12 [INFO] [stdout] | [INFO] [stdout] 92 | let dom = unsafe { tl::parse_owned(String::from_utf8(bytes)?, ParserOptions::default())? }; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | [INFO] [stdout] 94 | Ok(Self { dom, page }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session.rs:72:9 [INFO] [stdout] | [INFO] [stdout] 70 | let client = self.client.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | let token = self.token.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | / stream::iter(1..) [INFO] [stdout] 73 | | .then(move |page_num| { [INFO] [stdout] 74 | | // Cloning `client` and `token` above is to avoid having the closure live as long [INFO] [stdout] 75 | | // as `self`. Cloning again is necessary because new ownership is needed for each [INFO] [stdout] ... | [INFO] [stdout] 87 | | }) [INFO] [stdout] 88 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session.rs:83:26 [INFO] [stdout] | [INFO] [stdout] 70 | let client = self.client.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | let token = self.token.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | let client = client.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | let token = token.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | Box::pin(async move { [INFO] [stdout] | __________________________^ [INFO] [stdout] 84 | | Ok(Self::get_page(client, token, query, page_num) [INFO] [stdout] 85 | | .await? [INFO] [stdout] 86 | | .await?) [INFO] [stdout] 87 | | }) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session.rs:84:24 [INFO] [stdout] | [INFO] [stdout] 77 | let client = client.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | let token = token.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | Ok(Self::get_page(client, token, query, page_num) [INFO] [stdout] | ________________________^ [INFO] [stdout] 85 | | .await? [INFO] [stdout] 86 | | .await?) [INFO] [stdout] | |_______________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session.rs:89:43 [INFO] [stdout] | [INFO] [stdout] 89 | .and_then(|response| Box::pin(body::to_bytes(response.into_body()).err_into())) [INFO] [stdout] | -------- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ubs-lib` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "335301ff13228419d02b4808079103d5febef4aa51ca44f1947c3fd122334cda", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "335301ff13228419d02b4808079103d5febef4aa51ca44f1947c3fd122334cda", kill_on_drop: false }` [INFO] [stdout] 335301ff13228419d02b4808079103d5febef4aa51ca44f1947c3fd122334cda