[INFO] fetching crate ublox-sockets 0.5.0... [INFO] checking ublox-sockets-0.5.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ublox-sockets 0.5.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate ublox-sockets 0.5.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ublox-sockets 0.5.0 [INFO] finished tweaking crates.io crate ublox-sockets 0.5.0 [INFO] tweaked toml for crates.io crate ublox-sockets 0.5.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 49 packages to latest compatible versions [INFO] [stderr] Adding atat v0.18.0 (latest: v0.23.0) [INFO] [stderr] Adding atat_derive v0.18.0 (latest: v0.23.0) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding embedded-hal v1.0.0-alpha.9 (latest: v1.0.0) [INFO] [stderr] Adding embedded-hal-nb v1.0.0-alpha.1 (latest: v1.0.0) [INFO] [stderr] Adding embedded-nal v0.6.0 (latest: v0.8.0) [INFO] [stderr] Adding hash32 v0.2.1 (latest: v0.3.1) [INFO] [stderr] Adding heapless v0.7.17 (latest: v0.8.0) [INFO] [stderr] Adding heapless-bytes v0.3.0 (latest: v0.4.0) [INFO] [stderr] Adding no-std-net v0.5.0 (latest: v0.6.0) [INFO] [stderr] Adding serde_at v0.18.0 (latest: v0.23.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 862d2093a69130f3b5fb97de72260d0444ae59606a1d47eed9c8dac4d32f3b7a [INFO] running `Command { std: "docker" "start" "-a" "862d2093a69130f3b5fb97de72260d0444ae59606a1d47eed9c8dac4d32f3b7a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "862d2093a69130f3b5fb97de72260d0444ae59606a1d47eed9c8dac4d32f3b7a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "862d2093a69130f3b5fb97de72260d0444ae59606a1d47eed9c8dac4d32f3b7a", kill_on_drop: false }` [INFO] [stdout] 862d2093a69130f3b5fb97de72260d0444ae59606a1d47eed9c8dac4d32f3b7a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 564ca333efa6f596d90315f776aeeb86d44e584a616dd0a6d95add46c64c40c9 [INFO] running `Command { std: "docker" "start" "-a" "564ca333efa6f596d90315f776aeeb86d44e584a616dd0a6d95add46c64c40c9", kill_on_drop: false }` [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling scopeguard v1.2.0 [INFO] [stderr] Compiling byteorder v1.5.0 [INFO] [stderr] Checking nb v1.1.0 [INFO] [stderr] Compiling stable_deref_trait v1.2.0 [INFO] [stderr] Checking gcd v2.3.0 [INFO] [stderr] Checking hash32 v0.2.1 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking embedded-hal v1.0.0-alpha.9 [INFO] [stderr] Checking bbqueue v0.5.1 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling hash32-derive v0.1.1 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Checking fugit v0.3.7 [INFO] [stderr] Checking embedded-hal-nb v1.0.0-alpha.1 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Compiling spin v0.9.8 [INFO] [stderr] Checking fugit-timer v0.1.3 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Compiling heapless v0.7.17 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling serde_at v0.18.0 [INFO] [stderr] Compiling atat_derive v0.18.0 [INFO] [stderr] Checking serde_bytes v0.11.15 [INFO] [stderr] Checking no-std-net v0.5.0 [INFO] [stderr] Checking heapless-bytes v0.3.0 [INFO] [stderr] Checking embedded-nal v0.6.0 [INFO] [stderr] Checking atat v0.18.0 [INFO] [stderr] Checking ublox-sockets v0.5.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: method `into_result` is never used [INFO] [stdout] --> src/fmt.rs:226:8 [INFO] [stdout] | [INFO] [stdout] 223 | pub trait Try { [INFO] [stdout] | --- method in this trait [INFO] [stdout] ... [INFO] [stdout] 226 | fn into_result(self) -> Result; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ring_buffer.rs:117:15 [INFO] [stdout] | [INFO] [stdout] 108 | pub fn enqueue_one_with<'b, R, F>(&'b mut self, f: F) -> Result [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 117 | match f(&mut self.storage[index]) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ring_buffer.rs:145:15 [INFO] [stdout] | [INFO] [stdout] 136 | pub fn dequeue_one_with<'b, R, F>(&'b mut self, f: F) -> Result [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 145 | match f(&mut self.storage[self.read_at]) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tcp.rs:215:24 [INFO] [stdout] | [INFO] [stdout] 211 | pub fn recv<'b, F, R>(&'b mut self, f: F) -> Result [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 215 | self.recv_impl(|rx_buffer| rx_buffer.dequeue_many_with(f)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tcp.rs:231:24 [INFO] [stdout] | [INFO] [stdout] 227 | pub fn recv_wrapping<'b, F>(&'b mut self, f: F) -> Result [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 231 | self.recv_impl(|rx_buffer| { [INFO] [stdout] | ________________________^ [INFO] [stdout] 232 | | rx_buffer.dequeue_many_with_wrapping(|a, b| { [INFO] [stdout] 233 | | let len = f(a, b); [INFO] [stdout] 234 | | (len, len) [INFO] [stdout] 235 | | }) [INFO] [stdout] 236 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tcp.rs:232:50 [INFO] [stdout] | [INFO] [stdout] 227 | pub fn recv_wrapping<'b, F>(&'b mut self, f: F) -> Result [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 232 | rx_buffer.dequeue_many_with_wrapping(|a, b| { [INFO] [stdout] | __________________________________________________^ [INFO] [stdout] 233 | | let len = f(a, b); [INFO] [stdout] 234 | | (len, len) [INFO] [stdout] 235 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/udp.rs:188:24 [INFO] [stdout] | [INFO] [stdout] 184 | pub fn recv<'b, F, R>(&'b mut self, f: F) -> Result [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 188 | self.recv_impl(|rx_buffer| rx_buffer.dequeue_many_with(f)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ublox-sockets` (lib) due to 7 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: method `into_result` is never used [INFO] [stdout] --> src/fmt.rs:226:8 [INFO] [stdout] | [INFO] [stdout] 223 | pub trait Try { [INFO] [stdout] | --- method in this trait [INFO] [stdout] ... [INFO] [stdout] 226 | fn into_result(self) -> Result; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ring_buffer.rs:117:15 [INFO] [stdout] | [INFO] [stdout] 108 | pub fn enqueue_one_with<'b, R, F>(&'b mut self, f: F) -> Result [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 117 | match f(&mut self.storage[index]) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ring_buffer.rs:145:15 [INFO] [stdout] | [INFO] [stdout] 136 | pub fn dequeue_one_with<'b, R, F>(&'b mut self, f: F) -> Result [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 145 | match f(&mut self.storage[self.read_at]) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tcp.rs:215:24 [INFO] [stdout] | [INFO] [stdout] 211 | pub fn recv<'b, F, R>(&'b mut self, f: F) -> Result [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 215 | self.recv_impl(|rx_buffer| rx_buffer.dequeue_many_with(f)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tcp.rs:231:24 [INFO] [stdout] | [INFO] [stdout] 227 | pub fn recv_wrapping<'b, F>(&'b mut self, f: F) -> Result [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 231 | self.recv_impl(|rx_buffer| { [INFO] [stdout] | ________________________^ [INFO] [stdout] 232 | | rx_buffer.dequeue_many_with_wrapping(|a, b| { [INFO] [stdout] 233 | | let len = f(a, b); [INFO] [stdout] 234 | | (len, len) [INFO] [stdout] 235 | | }) [INFO] [stdout] 236 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tcp.rs:232:50 [INFO] [stdout] | [INFO] [stdout] 227 | pub fn recv_wrapping<'b, F>(&'b mut self, f: F) -> Result [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 232 | rx_buffer.dequeue_many_with_wrapping(|a, b| { [INFO] [stdout] | __________________________________________________^ [INFO] [stdout] 233 | | let len = f(a, b); [INFO] [stdout] 234 | | (len, len) [INFO] [stdout] 235 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/udp.rs:188:24 [INFO] [stdout] | [INFO] [stdout] 184 | pub fn recv<'b, F, R>(&'b mut self, f: F) -> Result [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 188 | self.recv_impl(|rx_buffer| rx_buffer.dequeue_many_with(f)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ublox-sockets` (lib test) due to 7 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "564ca333efa6f596d90315f776aeeb86d44e584a616dd0a6d95add46c64c40c9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "564ca333efa6f596d90315f776aeeb86d44e584a616dd0a6d95add46c64c40c9", kill_on_drop: false }` [INFO] [stdout] 564ca333efa6f596d90315f776aeeb86d44e584a616dd0a6d95add46c64c40c9