[INFO] fetching crate uaparser 0.6.4... [INFO] checking uaparser-0.6.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate uaparser 0.6.4 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate uaparser 0.6.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate uaparser 0.6.4 [INFO] finished tweaking crates.io crate uaparser 0.6.4 [INFO] tweaked toml for crates.io crate uaparser 0.6.4 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate uaparser 0.6.4 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 53322a8c1864b9f106a4a1454cc252d17292178724182c18575dbc42de388b70 [INFO] running `Command { std: "docker" "start" "-a" "53322a8c1864b9f106a4a1454cc252d17292178724182c18575dbc42de388b70", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "53322a8c1864b9f106a4a1454cc252d17292178724182c18575dbc42de388b70", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "53322a8c1864b9f106a4a1454cc252d17292178724182c18575dbc42de388b70", kill_on_drop: false }` [INFO] [stdout] 53322a8c1864b9f106a4a1454cc252d17292178724182c18575dbc42de388b70 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9157f4509cebccc904fe4d5fbf34b1f57b25697f890a9f79e8638c95885d519a [INFO] running `Command { std: "docker" "start" "-a" "9157f4509cebccc904fe4d5fbf34b1f57b25697f890a9f79e8638c95885d519a", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.85 [INFO] [stderr] Compiling serde v1.0.203 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Checking either v1.12.0 [INFO] [stderr] Compiling serde_json v1.0.117 [INFO] [stderr] Checking plotters-backend v0.3.6 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking clap_lex v0.7.1 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Checking ciborium-io v0.2.2 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking unsafe-libyaml v0.2.11 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking clap_builder v4.5.7 [INFO] [stderr] Checking plotters-svg v0.3.6 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Compiling syn v2.0.66 [INFO] [stderr] Checking is-terminal v0.4.12 [INFO] [stderr] Checking plotters v0.3.6 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking clap v4.5.7 [INFO] [stderr] Compiling derive_more v0.99.17 [INFO] [stderr] Checking regex v1.10.5 [INFO] [stderr] Compiling serde_derive v1.0.203 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking criterion v0.5.1 [INFO] [stderr] Checking uaparser v0.6.4 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/mod.rs:192:12 [INFO] [stdout] | [INFO] [stdout] 162 | let device_matchers = if device { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 163 | let mut matchers = Vec::with_capacity(regex_file.device_parsers.len()); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 172 | let os_matchers = if os { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 173 | let mut matchers = Vec::with_capacity(regex_file.os_parsers.len()); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 182 | let user_agent_matchers = if user_agent { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 183 | let mut matchers = Vec::with_capacity(regex_file.user_agent_parsers.len()); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 192 | Ok(UserAgentParser { [INFO] [stdout] | ____________^ [INFO] [stdout] 193 | | device_matchers, [INFO] [stdout] 194 | | os_matchers, [INFO] [stdout] 195 | | user_agent_matchers, [INFO] [stdout] 196 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/device.rs:88:12 [INFO] [stdout] | [INFO] [stdout] 83 | let regex = regex::bytes::RegexBuilder::new(&clean_escapes(®ex_with_flags)) [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | Ok(Matcher { [INFO] [stdout] | ____________^ [INFO] [stdout] 89 | | regex: regex?, [INFO] [stdout] 90 | | device_replacement_has_group: entry [INFO] [stdout] 91 | | .device_replacement [INFO] [stdout] ... | [INFO] [stdout] 104 | | model_replacement: entry.model_replacement, [INFO] [stdout] 105 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/os.rs:112:12 [INFO] [stdout] | [INFO] [stdout] 108 | let regex = regex::bytes::RegexBuilder::new(&clean_escapes(&entry.regex)) [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | Ok(Matcher { [INFO] [stdout] | ____________^ [INFO] [stdout] 113 | | regex: regex?, [INFO] [stdout] 114 | | os_replacement_has_group: entry [INFO] [stdout] 115 | | .os_replacement [INFO] [stdout] ... | [INFO] [stdout] 133 | | os_v3_replacement: entry.os_v3_replacement, [INFO] [stdout] 134 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/user_agent.rs:96:12 [INFO] [stdout] | [INFO] [stdout] 91 | let regex = regex::bytes::RegexBuilder::new(&clean_escapes(&entry.regex)) [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | Ok(Matcher { [INFO] [stdout] | ____________^ [INFO] [stdout] 97 | | regex: regex?, [INFO] [stdout] 98 | | family_replacement_has_group: entry [INFO] [stdout] 99 | | .family_replacement [INFO] [stdout] ... | [INFO] [stdout] 105 | | v3_replacement: entry.v3_replacement, [INFO] [stdout] 106 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `uaparser` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "9157f4509cebccc904fe4d5fbf34b1f57b25697f890a9f79e8638c95885d519a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9157f4509cebccc904fe4d5fbf34b1f57b25697f890a9f79e8638c95885d519a", kill_on_drop: false }` [INFO] [stdout] 9157f4509cebccc904fe4d5fbf34b1f57b25697f890a9f79e8638c95885d519a