[INFO] fetching crate txn-core 0.1.3... [INFO] checking txn-core-0.1.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate txn-core 0.1.3 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate txn-core 0.1.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate txn-core 0.1.3 [INFO] finished tweaking crates.io crate txn-core 0.1.3 [INFO] tweaked toml for crates.io crate txn-core 0.1.3 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 47 packages to latest compatible versions [INFO] [stderr] Adding ahash v0.7.8 (latest: v0.8.11) [INFO] [stderr] Adding bytecheck v0.6.12 (latest: v0.7.0) [INFO] [stderr] Adding bytecheck_derive v0.6.12 (latest: v0.7.0) [INFO] [stderr] Adding hashbrown v0.12.3 (latest: v0.14.5) [INFO] [stderr] Adding ptr_meta v0.1.4 (latest: v0.2.0) [INFO] [stderr] Adding ptr_meta_derive v0.1.4 (latest: v0.2.0) [INFO] [stderr] Adding radium v0.7.0 (latest: v1.1.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding wyz v0.5.1 (latest: v0.6.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9404d6f7ef9064a2d0d07383de6efd1e659e882a332cc972ed9366a01716a5f2 [INFO] running `Command { std: "docker" "start" "-a" "9404d6f7ef9064a2d0d07383de6efd1e659e882a332cc972ed9366a01716a5f2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9404d6f7ef9064a2d0d07383de6efd1e659e882a332cc972ed9366a01716a5f2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9404d6f7ef9064a2d0d07383de6efd1e659e882a332cc972ed9366a01716a5f2", kill_on_drop: false }` [INFO] [stdout] 9404d6f7ef9064a2d0d07383de6efd1e659e882a332cc972ed9366a01716a5f2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5b8170ab6f860b6aa67b9a82adb25ec528e2acf19f72adf76beb8f92cd8fca93 [INFO] running `Command { std: "docker" "start" "-a" "5b8170ab6f860b6aa67b9a82adb25ec528e2acf19f72adf76beb8f92cd8fca93", kill_on_drop: false }` [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking cheap-clone v0.1.2 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking smallvec-wrapper v0.1.1 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking txn-core v0.1.3 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:248:13 [INFO] [stdout] | [INFO] [stdout] 241 | pub fn split(self) -> (K, EntryValue) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 242 | let Entry { data, version } = self; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 243 | [INFO] [stdout] 244 | let (key, value) = match data { [INFO] [stdout] | --- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 245 | EntryData::Insert { key, value } => (key, Some(value)), [INFO] [stdout] | --- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 246 | EntryData::Remove(key) => (key, None), [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 247 | }; [INFO] [stdout] 248 | (key, EntryValue { value, version }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:255:15 [INFO] [stdout] | [INFO] [stdout] 252 | pub fn unsplit(key: K, value: EntryValue) -> Self { [INFO] [stdout] | ------ -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 253 | let EntryValue { value, version } = value; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 254 | Entry { [INFO] [stdout] 255 | data: match value { [INFO] [stdout] | _______________^ [INFO] [stdout] 256 | | Some(value) => EntryData::Insert { key, value }, [INFO] [stdout] 257 | | None => EntryData::Remove(key), [INFO] [stdout] 258 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sync/hash_cm.rs:73:8 [INFO] [stdout] | [INFO] [stdout] 72 | fn new(options: Self::Options) -> Result { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | Ok(match options.capacity { [INFO] [stdout] | ________^ [INFO] [stdout] 74 | | Some(capacity) => Self { [INFO] [stdout] 75 | | reads: MediumVec::with_capacity(capacity), [INFO] [stdout] 76 | | conflict_keys: IndexSet::with_capacity_and_hasher(capacity, options.hasher), [INFO] [stdout] ... | [INFO] [stdout] 83 | | }, [INFO] [stdout] 84 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sync/hash_pwm.rs:25:8 [INFO] [stdout] | [INFO] [stdout] 24 | fn new(options: Self::Options) -> Result { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | Ok(match options { [INFO] [stdout] | ________^ [INFO] [stdout] 26 | | Some(hasher) => Self::with_hasher(hasher), [INFO] [stdout] 27 | | None => Self::default(), [INFO] [stdout] 28 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:248:13 [INFO] [stdout] | [INFO] [stdout] 241 | pub fn split(self) -> (K, EntryValue) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 242 | let Entry { data, version } = self; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 243 | [INFO] [stdout] 244 | let (key, value) = match data { [INFO] [stdout] | --- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 245 | EntryData::Insert { key, value } => (key, Some(value)), [INFO] [stdout] | --- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 246 | EntryData::Remove(key) => (key, None), [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 247 | }; [INFO] [stdout] 248 | (key, EntryValue { value, version }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:255:15 [INFO] [stdout] | [INFO] [stdout] 252 | pub fn unsplit(key: K, value: EntryValue) -> Self { [INFO] [stdout] | ------ -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 253 | let EntryValue { value, version } = value; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 254 | Entry { [INFO] [stdout] 255 | data: match value { [INFO] [stdout] | _______________^ [INFO] [stdout] 256 | | Some(value) => EntryData::Insert { key, value }, [INFO] [stdout] 257 | | None => EntryData::Remove(key), [INFO] [stdout] 258 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sync/hash_cm.rs:73:8 [INFO] [stdout] | [INFO] [stdout] 72 | fn new(options: Self::Options) -> Result { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | Ok(match options.capacity { [INFO] [stdout] | ________^ [INFO] [stdout] 74 | | Some(capacity) => Self { [INFO] [stdout] 75 | | reads: MediumVec::with_capacity(capacity), [INFO] [stdout] 76 | | conflict_keys: IndexSet::with_capacity_and_hasher(capacity, options.hasher), [INFO] [stdout] ... | [INFO] [stdout] 83 | | }, [INFO] [stdout] 84 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sync/hash_pwm.rs:25:8 [INFO] [stdout] | [INFO] [stdout] 24 | fn new(options: Self::Options) -> Result { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | Ok(match options { [INFO] [stdout] | ________^ [INFO] [stdout] 26 | | Some(hasher) => Self::with_hasher(hasher), [INFO] [stdout] 27 | | None => Self::default(), [INFO] [stdout] 28 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `txn-core` (lib test) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `txn-core` (lib) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "5b8170ab6f860b6aa67b9a82adb25ec528e2acf19f72adf76beb8f92cd8fca93", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5b8170ab6f860b6aa67b9a82adb25ec528e2acf19f72adf76beb8f92cd8fca93", kill_on_drop: false }` [INFO] [stdout] 5b8170ab6f860b6aa67b9a82adb25ec528e2acf19f72adf76beb8f92cd8fca93