[INFO] fetching crate txfs 0.4.0... [INFO] checking txfs-0.4.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate txfs 0.4.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate txfs 0.4.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate txfs 0.4.0 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate txfs 0.4.0 [INFO] tweaked toml for crates.io crate txfs 0.4.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate txfs 0.4.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ba9226b48bdc1ee8933ea13121931b1b7c57e315caf2995cfc90c6ac04060dab [INFO] running `Command { std: "docker" "start" "-a" "ba9226b48bdc1ee8933ea13121931b1b7c57e315caf2995cfc90c6ac04060dab", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ba9226b48bdc1ee8933ea13121931b1b7c57e315caf2995cfc90c6ac04060dab", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ba9226b48bdc1ee8933ea13121931b1b7c57e315caf2995cfc90c6ac04060dab", kill_on_drop: false }` [INFO] [stdout] ba9226b48bdc1ee8933ea13121931b1b7c57e315caf2995cfc90c6ac04060dab [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b71092d14199631dd228c70b896f9cc8f0d2222a53c0aae627d9539c9f59cc2e [INFO] running `Command { std: "docker" "start" "-a" "b71092d14199631dd228c70b896f9cc8f0d2222a53c0aae627d9539c9f59cc2e", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Compiling smallvec v1.13.2 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Compiling unicode-xid v0.2.4 [INFO] [stderr] Compiling collection_literals v1.0.1 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Compiling interpolator v0.5.0 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Checking safecast v0.2.3 [INFO] [stderr] Checking get-size v0.1.4 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking collate v0.4.2 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.74 [INFO] [stderr] Compiling proc-macro-utils v0.8.0 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Compiling derive-where v1.2.7 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling derive_more-impl v1.0.0 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Checking tokio v1.39.2 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling quote-use-macros v0.7.2 [INFO] [stderr] Checking derive_more v1.0.0 [INFO] [stderr] Checking hr-id v0.6.0 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Compiling quote-use v0.7.2 [INFO] [stderr] Compiling attribute-derive-macro v0.6.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling attribute-derive v0.6.1 [INFO] [stderr] Compiling get-size-derive v0.1.3 [INFO] [stderr] Checking ds-ext v0.2.0 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking txn_lock v0.10.0 [INFO] [stderr] Checking freqfs v0.10.0 [INFO] [stderr] Checking destream v0.8.0 [INFO] [stderr] Checking txfs v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dir.rs:134:18 [INFO] [stdout] | [INFO] [stdout] 129 | canon: DirLock, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 134 | Box::pin(async move { [INFO] [stdout] | __________________^ [INFO] [stdout] 135 | | let (contents, versions) = { [INFO] [stdout] 136 | | #[cfg(feature = "log")] [INFO] [stdout] 137 | | log::trace!("lock canonical dir for writing"); [INFO] [stdout] ... | [INFO] [stdout] 206 | | }) [INFO] [stdout] 207 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dir.rs:202:16 [INFO] [stdout] | [INFO] [stdout] 129 | canon: DirLock, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 135 | let (contents, versions) = { [INFO] [stdout] | -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 139 | let versions = { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 140 | let mut dir = canon.write().await; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 144 | let contents = { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 148 | let mut versions = versions.write().await; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 155 | let mut contents = HashMap::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 158 | let name: Id = if name.starts_with('.') { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 166 | let entry = match entry.clone() { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 167 | freqfs::DirEntry::Dir(dir) => { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 172 | freqfs::DirEntry::File(_file) => { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 182 | let file_versions = versions.get_or_create_dir(name.to_string())?; [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 202 | Ok(Self { [INFO] [stdout] | ________________^ [INFO] [stdout] 203 | | canon, [INFO] [stdout] 204 | | versions, [INFO] [stdout] 205 | | entries: TxnMapLock::with_contents(txn_id, contents), [INFO] [stdout] 206 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dir.rs:291:39 [INFO] [stdout] | [INFO] [stdout] 291 | .then(move |(name, file)| file.into_read(txn_id).map_ok(|file| (name, file))); [INFO] [stdout] | ------------ ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dir.rs:291:69 [INFO] [stdout] | [INFO] [stdout] 291 | .then(move |(name, file)| file.into_read(txn_id).map_ok(|file| (name, file))); [INFO] [stdout] | ------------ ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dir.rs:329:18 [INFO] [stdout] | [INFO] [stdout] 328 | pub fn truncate(self, txn_id: TxnId) -> Pin> + Send>> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 329 | Box::pin(async move { [INFO] [stdout] | __________________^ [INFO] [stdout] 330 | | let entries = self.entries.clear(txn_id).map_err(Error::from).await?; [INFO] [stdout] 331 | | [INFO] [stdout] 332 | | let truncates = entries [INFO] [stdout] ... | [INFO] [stdout] 343 | | try_join_all(truncates).map_ok(|_| ()).await [INFO] [stdout] 344 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dir.rs:343:52 [INFO] [stdout] | [INFO] [stdout] 328 | pub fn truncate(self, txn_id: TxnId) -> Pin> + Send>> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 329 | Box::pin(async move { [INFO] [stdout] 330 | let entries = self.entries.clear(txn_id).map_err(Error::from).await?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 331 | [INFO] [stdout] 332 | let truncates = entries [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 343 | try_join_all(truncates).map_ok(|_| ()).await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `txfs` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "b71092d14199631dd228c70b896f9cc8f0d2222a53c0aae627d9539c9f59cc2e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b71092d14199631dd228c70b896f9cc8f0d2222a53c0aae627d9539c9f59cc2e", kill_on_drop: false }` [INFO] [stdout] b71092d14199631dd228c70b896f9cc8f0d2222a53c0aae627d9539c9f59cc2e