[INFO] fetching crate tx3 0.0.1... [INFO] checking tx3-0.0.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate tx3 0.0.1 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate tx3 0.0.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tx3 0.0.1 [INFO] finished tweaking crates.io crate tx3 0.0.1 [INFO] tweaked toml for crates.io crate tx3 0.0.1 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate tx3 0.0.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3721ae211b7830c6896f80c35b268a828ec73f2d83d2a9c1f18add39c399ed13 [INFO] running `Command { std: "docker" "start" "-a" "3721ae211b7830c6896f80c35b268a828ec73f2d83d2a9c1f18add39c399ed13", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3721ae211b7830c6896f80c35b268a828ec73f2d83d2a9c1f18add39c399ed13", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3721ae211b7830c6896f80c35b268a828ec73f2d83d2a9c1f18add39c399ed13", kill_on_drop: false }` [INFO] [stdout] 3721ae211b7830c6896f80c35b268a828ec73f2d83d2a9c1f18add39c399ed13 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a1718e6ef531516f4afb5e3ea1c7c379a335346e19d94e993e878b630a0c986e [INFO] running `Command { std: "docker" "start" "-a" "a1718e6ef531516f4afb5e3ea1c7c379a335346e19d94e993e878b630a0c986e", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.125 [INFO] [stderr] Compiling proc-macro2 v1.0.37 [INFO] [stderr] Compiling syn v1.0.92 [INFO] [stderr] Compiling serde_derive v1.0.136 [INFO] [stderr] Compiling serde v1.0.136 [INFO] [stderr] Checking once_cell v1.10.0 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling cc v1.0.73 [INFO] [stderr] Compiling log v0.4.16 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Compiling typenum v1.15.0 [INFO] [stderr] Compiling generic-array v0.14.5 [INFO] [stderr] Compiling lock_api v0.4.7 [INFO] [stderr] Compiling semver v1.0.7 [INFO] [stderr] Compiling parking_lot_core v0.9.2 [INFO] [stderr] Checking spin v0.5.2 [INFO] [stderr] Compiling futures-core v0.3.21 [INFO] [stderr] Checking untrusted v0.7.1 [INFO] [stderr] Compiling crossbeam-utils v0.8.8 [INFO] [stderr] Compiling quote v1.0.18 [INFO] [stderr] Checking smallvec v1.8.0 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling futures-channel v0.3.21 [INFO] [stderr] Checking ryu v1.0.9 [INFO] [stderr] Compiling futures-task v0.3.21 [INFO] [stderr] Compiling indexmap v1.8.1 [INFO] [stderr] Compiling crossbeam-epoch v0.9.8 [INFO] [stderr] Checking futures-sink v0.3.21 [INFO] [stderr] Compiling futures-util v0.3.21 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Checking parking_lot v0.12.0 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking mio v0.8.2 [INFO] [stderr] Checking socket2 v0.4.4 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking tracing-core v0.1.26 [INFO] [stderr] Checking num_threads v0.1.5 [INFO] [stderr] Checking bytes v1.1.0 [INFO] [stderr] Compiling rayon-core v1.9.2 [INFO] [stderr] Checking futures-io v0.3.21 [INFO] [stderr] Checking matches v0.1.9 [INFO] [stderr] Checking slab v0.4.6 [INFO] [stderr] Compiling rustls v0.20.4 [INFO] [stderr] Checking time v0.3.9 [INFO] [stderr] Checking unicode-normalization v0.1.19 [INFO] [stderr] Checking block-buffer v0.10.2 [INFO] [stderr] Checking crypto-common v0.1.3 [INFO] [stderr] Checking regex v1.5.5 [INFO] [stderr] Compiling cast v0.2.7 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Checking os_str_bytes v6.0.0 [INFO] [stderr] Checking linked-hash-map v0.5.4 [INFO] [stderr] Compiling serde_json v1.0.79 [INFO] [stderr] Compiling heck v0.4.0 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Checking unicode-bidi v0.3.8 [INFO] [stderr] Checking crossbeam-deque v0.8.1 [INFO] [stderr] Checking clap_lex v0.1.1 [INFO] [stderr] Checking form_urlencoded v1.0.1 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Checking idna v0.2.3 [INFO] [stderr] Checking pem v1.0.2 [INFO] [stderr] Checking yasna v0.5.0 [INFO] [stderr] Checking matchers v0.1.0 [INFO] [stderr] Checking digest v0.10.3 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking tracing-log v0.1.3 [INFO] [stderr] Checking tracing v0.1.34 [INFO] [stderr] Checking crossbeam-channel v0.5.4 [INFO] [stderr] Checking thread_local v1.1.4 [INFO] [stderr] Checking sharded-slab v0.1.4 [INFO] [stderr] Compiling rayon v1.5.2 [INFO] [stderr] Checking plotters-backend v0.3.2 [INFO] [stderr] Checking itoa v1.0.1 [INFO] [stderr] Checking c_linked_list v1.1.1 [INFO] [stderr] Checking sct v0.7.0 [INFO] [stderr] Checking webpki v0.22.0 [INFO] [stderr] Checking cpufeatures v0.2.2 [INFO] [stderr] Checking unicode-width v0.1.9 [INFO] [stderr] Checking textwrap v0.15.0 [INFO] [stderr] Checking sha2 v0.10.2 [INFO] [stderr] Checking plotters-svg v0.3.1 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking get_if_addrs v0.5.3 [INFO] [stderr] Checking rcgen v0.9.2 [INFO] [stderr] Checking tracing-subscriber v0.3.11 [INFO] [stderr] Checking itertools v0.10.3 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Checking futures v0.3.21 [INFO] [stderr] Checking half v1.8.2 [INFO] [stderr] Checking itoa v0.4.8 [INFO] [stderr] Checking walkdir v2.3.2 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Checking plotters v0.3.1 [INFO] [stderr] Compiling tokio-macros v1.7.0 [INFO] [stderr] Compiling clap_derive v3.1.7 [INFO] [stderr] Checking criterion-plot v0.4.4 [INFO] [stderr] Checking tokio v1.18.0 [INFO] [stderr] Checking clap v3.1.12 [INFO] [stderr] Checking tokio-rustls v0.23.3 [INFO] [stderr] Checking url v2.2.2 [INFO] [stderr] Checking serde_yaml v0.8.23 [INFO] [stderr] Checking bstr v0.2.17 [INFO] [stderr] Checking serde_cbor v0.11.2 [INFO] [stderr] Checking csv v1.1.6 [INFO] [stderr] Checking tx3 v0.0.1 (/opt/rustwide/workdir) [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking criterion v0.3.5 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tls.rs:94:12 [INFO] [stdout] | [INFO] [stdout] 94 | Ok(Self(Arc::new(out))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tls.rs:148:8 [INFO] [stdout] | [INFO] [stdout] 122 | let mut params = rcgen::CertificateParams::new(vec![sni.clone()]); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 139 | let cert = rcgen::Certificate::from_params(params).map_err(other_err)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 148 | Ok(( [INFO] [stdout] | ________^ [INFO] [stdout] 149 | | TlsCertDer(cert_der.into_boxed_slice()), [INFO] [stdout] 150 | | TlsPkDer(priv_key.into_boxed_slice()), [INFO] [stdout] 151 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tls.rs:156:27 [INFO] [stdout] | [INFO] [stdout] 156 | Lazy::new(|| Arc::new(rustls::KeyLogFile::new())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tls.rs:265:12 [INFO] [stdout] | [INFO] [stdout] 209 | pub fn build(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 210 | let (cert, pk) = match self.cert { [INFO] [stdout] | ---- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 211 | Some(r) => r, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 217 | let digest = TlsCertDigest(Arc::new(digest.finalize().into())); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 226 | let mut srv = rustls::ServerConfig::builder() [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 247 | let mut cli = rustls::ClientConfig::builder() [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 265 | Ok(TlsConfig { [INFO] [stdout] | ____________^ [INFO] [stdout] 266 | | srv: Arc::new(srv), [INFO] [stdout] 267 | | cli: Arc::new(cli), [INFO] [stdout] 268 | | digest, [INFO] [stdout] 269 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tls.rs:323:5 [INFO] [stdout] | [INFO] [stdout] 323 | / cert.verify_is_valid_tls_client_cert( [INFO] [stdout] 324 | | SUPPORTED_SIG_ALGS, [INFO] [stdout] 325 | | &webpki::TlsClientTrustAnchors(&trustroots), [INFO] [stdout] 326 | | &chain, [INFO] [stdout] 327 | | now, [INFO] [stdout] 328 | | ) [INFO] [stdout] 329 | | .map_err(other_err) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_______________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tx3` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "a1718e6ef531516f4afb5e3ea1c7c379a335346e19d94e993e878b630a0c986e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a1718e6ef531516f4afb5e3ea1c7c379a335346e19d94e993e878b630a0c986e", kill_on_drop: false }` [INFO] [stdout] a1718e6ef531516f4afb5e3ea1c7c379a335346e19d94e993e878b630a0c986e