[INFO] fetching crate twsnap 0.2.1... [INFO] checking twsnap-0.2.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate twsnap 0.2.1 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate twsnap 0.2.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate twsnap 0.2.1 [INFO] finished tweaking crates.io crate twsnap 0.2.1 [INFO] tweaked toml for crates.io crate twsnap 0.2.1 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate twsnap 0.2.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 882cafa19d3b54cd96d5a1e1bc686d0e315110de5f9e6e3d810ab301ad976166 [INFO] running `Command { std: "docker" "start" "-a" "882cafa19d3b54cd96d5a1e1bc686d0e315110de5f9e6e3d810ab301ad976166", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "882cafa19d3b54cd96d5a1e1bc686d0e315110de5f9e6e3d810ab301ad976166", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "882cafa19d3b54cd96d5a1e1bc686d0e315110de5f9e6e3d810ab301ad976166", kill_on_drop: false }` [INFO] [stdout] 882cafa19d3b54cd96d5a1e1bc686d0e315110de5f9e6e3d810ab301ad976166 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6e025e9b415a2f16f1f124c8b45d05bd6739e2d25ddd6495779e99b0498f7ad1 [INFO] running `Command { std: "docker" "start" "-a" "6e025e9b415a2f16f1f124c8b45d05bd6739e2d25ddd6495779e99b0498f7ad1", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.79 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking arrayvec v0.5.2 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking mac v0.0.2 [INFO] [stderr] Compiling semver v1.0.20 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling hashbrown v0.14.3 [INFO] [stderr] Compiling equivalent v1.0.1 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Compiling binrw_derive v0.11.2 [INFO] [stderr] Compiling toml_datetime v0.6.3 [INFO] [stderr] Compiling winnow v0.5.25 [INFO] [stderr] Compiling owo-colors v3.5.0 [INFO] [stderr] Compiling either v1.9.0 [INFO] [stderr] Compiling thiserror v1.0.50 [INFO] [stderr] Checking log v0.3.9 [INFO] [stderr] Checking zerocopy v0.7.32 [INFO] [stderr] Compiling az v1.2.1 [INFO] [stderr] Compiling binrw v0.11.2 [INFO] [stderr] Checking warn v0.2.2 [INFO] [stderr] Checking buffer v0.1.9 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Checking bytemuck v1.14.0 [INFO] [stderr] Checking array-init v2.1.0 [INFO] [stderr] Checking itertools v0.4.19 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling fixed v1.24.0 [INFO] [stderr] Checking half v2.3.1 [INFO] [stderr] Checking allocator-api2 v0.2.18 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling indexmap v2.1.0 [INFO] [stderr] Checking pre-rfc3243-libtw2-common v0.1.0 [INFO] [stderr] Compiling syn v2.0.55 [INFO] [stderr] Compiling vek v0.16.1 [INFO] [stderr] Checking pre-rfc3243-libtw2-huffman v0.1.0 [INFO] [stderr] Compiling toml_edit v0.20.2 [INFO] [stderr] Checking approx v0.5.1 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Compiling thiserror-impl v1.0.50 [INFO] [stderr] Compiling proc-macro-crate v2.0.1 [INFO] [stderr] Compiling num_enum_derive v0.7.1 [INFO] [stderr] Checking num_enum v0.7.1 [INFO] [stderr] Checking uuid v0.8.2 [INFO] [stderr] Checking arrayvec v0.7.4 [INFO] [stderr] Checking bitflags v2.4.1 [INFO] [stderr] Checking pre-rfc3243-libtw2-packer v0.1.0 [INFO] [stderr] Checking pre-rfc3243-libtw2-gamenet-common v0.1.1 [INFO] [stderr] Checking pre-rfc3243-libtw2-gamenet-snap v0.1.0 [INFO] [stderr] Checking pre-rfc3243-libtw2-snapshot v0.1.0 [INFO] [stderr] Checking pre-rfc3243-libtw2-gamenet-ddnet v0.1.1 [INFO] [stderr] Checking pre-rfc3243-libtw2-demo v0.1.0 [INFO] [stderr] Checking twsnap v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compat/ddnet/demo_reader.rs:43:12 [INFO] [stdout] | [INFO] [stdout] 40 | pub fn new(file: R) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | let reader = ddnet::DemoReader::new(file, &mut warn::Log)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | let converter = super::Converter::default(); [INFO] [stdout] 43 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 44 | | reader, [INFO] [stdout] 45 | | converter, [INFO] [stdout] 46 | | last_tick: None, [INFO] [stdout] 47 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compat/ddnet/demo_writer.rs:67:12 [INFO] [stdout] | [INFO] [stdout] 39 | file: T, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | let inner = ddnet::DemoWriter::new( [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 68 | | inner, [INFO] [stdout] 69 | | item_storage: Vec::new(), [INFO] [stdout] 70 | | teams: [0; 64], [INFO] [stdout] 71 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compat/ddnet/demo_reader.rs:43:12 [INFO] [stdout] | [INFO] [stdout] 40 | pub fn new(file: R) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | let reader = ddnet::DemoReader::new(file, &mut warn::Log)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | let converter = super::Converter::default(); [INFO] [stdout] 43 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 44 | | reader, [INFO] [stdout] 45 | | converter, [INFO] [stdout] 46 | | last_tick: None, [INFO] [stdout] 47 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compat/ddnet/demo_writer.rs:67:12 [INFO] [stdout] | [INFO] [stdout] 39 | file: T, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | let inner = ddnet::DemoWriter::new( [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 68 | | inner, [INFO] [stdout] 69 | | item_storage: Vec::new(), [INFO] [stdout] 70 | | teams: [0; 64], [INFO] [stdout] 71 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `twsnap` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `twsnap` (lib test) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "6e025e9b415a2f16f1f124c8b45d05bd6739e2d25ddd6495779e99b0498f7ad1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6e025e9b415a2f16f1f124c8b45d05bd6739e2d25ddd6495779e99b0498f7ad1", kill_on_drop: false }` [INFO] [stdout] 6e025e9b415a2f16f1f124c8b45d05bd6739e2d25ddd6495779e99b0498f7ad1