[INFO] fetching crate tweakster 0.0.3... [INFO] checking tweakster-0.0.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate tweakster 0.0.3 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate tweakster 0.0.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tweakster 0.0.3 [INFO] finished tweaking crates.io crate tweakster 0.0.3 [INFO] tweaked toml for crates.io crate tweakster 0.0.3 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate tweakster 0.0.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ba1737df9e70ffe0f79d6a43762335951fe660f027872231dcb65de87554ec24 [INFO] running `Command { std: "docker" "start" "-a" "ba1737df9e70ffe0f79d6a43762335951fe660f027872231dcb65de87554ec24", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ba1737df9e70ffe0f79d6a43762335951fe660f027872231dcb65de87554ec24", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ba1737df9e70ffe0f79d6a43762335951fe660f027872231dcb65de87554ec24", kill_on_drop: false }` [INFO] [stdout] ba1737df9e70ffe0f79d6a43762335951fe660f027872231dcb65de87554ec24 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e38468f25296fbda74df90fa61cf1dab7c35530d04a1cffec817892e7b8f5689 [INFO] running `Command { std: "docker" "start" "-a" "e38468f25296fbda74df90fa61cf1dab7c35530d04a1cffec817892e7b8f5689", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.37 [INFO] [stderr] Compiling syn v1.0.91 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling glob v0.3.0 [INFO] [stderr] Compiling libc v0.2.123 [INFO] [stderr] Compiling minimal-lexical v0.2.1 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Compiling regex-syntax v0.6.27 [INFO] [stderr] Compiling bindgen v0.59.2 [INFO] [stderr] Compiling lazy_static v1.4.0 [INFO] [stderr] Compiling shlex v1.1.0 [INFO] [stderr] Compiling peeking_take_while v0.1.2 [INFO] [stderr] Compiling rustc-hash v1.1.0 [INFO] [stderr] Compiling bitflags v1.3.2 [INFO] [stderr] Compiling lazycell v1.3.0 [INFO] [stderr] Compiling libloading v0.7.3 [INFO] [stderr] Compiling serde_derive v1.0.136 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Checking once_cell v1.13.0 [INFO] [stderr] Compiling serde v1.0.136 [INFO] [stderr] Compiling unicode-segmentation v1.9.0 [INFO] [stderr] Checking pin-project-lite v0.2.9 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking plain v0.2.3 [INFO] [stderr] Checking tracing-core v0.1.28 [INFO] [stderr] Compiling clang-sys v1.3.3 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Compiling quote v1.0.18 [INFO] [stderr] Compiling nom v7.1.1 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking errno v0.2.8 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Compiling regex v1.6.0 [INFO] [stderr] Compiling cexpr v0.6.0 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling scroll_derive v0.10.5 [INFO] [stderr] Compiling tracing-attributes v0.1.22 [INFO] [stderr] Compiling thiserror-impl v1.0.31 [INFO] [stderr] Compiling merge_derive v0.1.0 [INFO] [stderr] Compiling smart-default v0.6.0 [INFO] [stderr] Compiling structopt-derive v0.4.18 [INFO] [stderr] Checking merge v0.1.0 [INFO] [stderr] Checking scroll v0.10.2 [INFO] [stderr] Checking thiserror v1.0.31 [INFO] [stderr] Checking goblin v0.2.3 [INFO] [stderr] Checking tracing v0.1.35 [INFO] [stderr] Checking structopt v0.3.26 [INFO] [stderr] Compiling loopdev v0.4.0 [INFO] [stderr] Checking sys-mount v1.5.1 [INFO] [stderr] Checking toml v0.5.8 [INFO] [stderr] Checking tweakster v0.0.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: for loop over a `Result`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/main.rs:65:18 [INFO] [stdout] | [INFO] [stdout] 65 | for entry in fs::read_dir(cfg_path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 65 | while let Ok(entry) = fs::read_dir(cfg_path) { [INFO] [stdout] | ~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 65 | if let Ok(entry) = fs::read_dir(cfg_path) { [INFO] [stdout] | ~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/firmware.rs:68:11 [INFO] [stdout] | [INFO] [stdout] 60 | let _res = fs::DirBuilder::new().recursive(true).create(mountpath); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | match Mount::builder().mount(&srcpath, mountpath) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `Result`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/main.rs:65:18 [INFO] [stdout] | [INFO] [stdout] 65 | for entry in fs::read_dir(cfg_path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 65 | while let Ok(entry) = fs::read_dir(cfg_path) { [INFO] [stdout] | ~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 65 | if let Ok(entry) = fs::read_dir(cfg_path) { [INFO] [stdout] | ~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/firmware.rs:68:11 [INFO] [stdout] | [INFO] [stdout] 60 | let _res = fs::DirBuilder::new().recursive(true).create(mountpath); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | match Mount::builder().mount(&srcpath, mountpath) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tweakster` (bin "tweakster") due to 2 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tweakster` (bin "tweakster" test) due to 2 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "e38468f25296fbda74df90fa61cf1dab7c35530d04a1cffec817892e7b8f5689", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e38468f25296fbda74df90fa61cf1dab7c35530d04a1cffec817892e7b8f5689", kill_on_drop: false }` [INFO] [stdout] e38468f25296fbda74df90fa61cf1dab7c35530d04a1cffec817892e7b8f5689