[INFO] fetching crate tune 0.35.0... [INFO] checking tune-0.35.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate tune 0.35.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate tune 0.35.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tune 0.35.0 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate tune 0.35.0 [INFO] tweaked toml for crates.io crate tune 0.35.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate tune 0.35.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0643768deec3a1870ae061a169b0120d76588c2e7318731163b8a1c3e98dff7f [INFO] running `Command { std: "docker" "start" "-a" "0643768deec3a1870ae061a169b0120d76588c2e7318731163b8a1c3e98dff7f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0643768deec3a1870ae061a169b0120d76588c2e7318731163b8a1c3e98dff7f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0643768deec3a1870ae061a169b0120d76588c2e7318731163b8a1c3e98dff7f", kill_on_drop: false }` [INFO] [stdout] 0643768deec3a1870ae061a169b0120d76588c2e7318731163b8a1c3e98dff7f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a2e0b1bf438e46bb8ec8228a7d38395b9d10d0fc9c4ae0bf0e4d4e028cdb0490 [INFO] running `Command { std: "docker" "start" "-a" "a2e0b1bf438e46bb8ec8228a7d38395b9d10d0fc9c4ae0bf0e4d4e028cdb0490", kill_on_drop: false }` [INFO] [stderr] Checking assert_approx_eq v1.1.0 [INFO] [stderr] Checking tune v0.35.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pergen.rs:808:13 [INFO] [stdout] | [INFO] [stdout] 807 | fn repeat(count: u16, item: T) -> impl Iterator { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 808 | iter::repeat(item).take(usize::from(count)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scala/import.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 11 | pub(crate) fn import_scl(reader: impl Read) -> Result { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 12 | let importer = SclImporter::ExpectingDescription; [INFO] [stdout] 13 | / consume_lines(importer, reader, |i, line_number, line| { [INFO] [stdout] 14 | | i.consume(line_number, line) [INFO] [stdout] 15 | | }) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scala/import.rs:131:5 [INFO] [stdout] | [INFO] [stdout] 129 | pub(crate) fn import_kbm(reader: impl Read) -> Result { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 130 | let importer = KbmImporter::ExpectingMapSize; [INFO] [stdout] 131 | / consume_lines(importer, reader, |i, line_number, line| { [INFO] [stdout] 132 | | i.consume(line_number, line) [INFO] [stdout] 133 | | }) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scala/import.rs:308:5 [INFO] [stdout] | [INFO] [stdout] 307 | fn parse(line_number: usize, line: &str, error: E) -> Result> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 308 | / main_item(line) [INFO] [stdout] 309 | | .parse() [INFO] [stdout] | |________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scala/import.rs:310:18 [INFO] [stdout] | [INFO] [stdout] 307 | fn parse(line_number: usize, line: &str, error: E) -> Result> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 310 | .map_err(|_| ParseError(line_number, error)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tuner/aot.rs:26:20 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn start(synth: S) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | Self { [INFO] [stdout] 26 | model: AotTuningModel::empty(synth.num_channels()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tuner/jit.rs:23:20 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn start(synth: S, pooling_mode: PoolingMode) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | Self { [INFO] [stdout] 23 | model: JitTuningModel::new(synth.num_channels(), synth.group_by(), pooling_mode), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tune` (lib) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pergen.rs:808:13 [INFO] [stdout] | [INFO] [stdout] 807 | fn repeat(count: u16, item: T) -> impl Iterator { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 808 | iter::repeat(item).take(usize::from(count)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scala/import.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 11 | pub(crate) fn import_scl(reader: impl Read) -> Result { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 12 | let importer = SclImporter::ExpectingDescription; [INFO] [stdout] 13 | / consume_lines(importer, reader, |i, line_number, line| { [INFO] [stdout] 14 | | i.consume(line_number, line) [INFO] [stdout] 15 | | }) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scala/import.rs:131:5 [INFO] [stdout] | [INFO] [stdout] 129 | pub(crate) fn import_kbm(reader: impl Read) -> Result { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 130 | let importer = KbmImporter::ExpectingMapSize; [INFO] [stdout] 131 | / consume_lines(importer, reader, |i, line_number, line| { [INFO] [stdout] 132 | | i.consume(line_number, line) [INFO] [stdout] 133 | | }) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scala/import.rs:308:5 [INFO] [stdout] | [INFO] [stdout] 307 | fn parse(line_number: usize, line: &str, error: E) -> Result> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 308 | / main_item(line) [INFO] [stdout] 309 | | .parse() [INFO] [stdout] | |________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scala/import.rs:310:18 [INFO] [stdout] | [INFO] [stdout] 307 | fn parse(line_number: usize, line: &str, error: E) -> Result> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 310 | .map_err(|_| ParseError(line_number, error)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tuner/aot.rs:26:20 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn start(synth: S) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | Self { [INFO] [stdout] 26 | model: AotTuningModel::empty(synth.num_channels()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tuner/jit.rs:23:20 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn start(synth: S, pooling_mode: PoolingMode) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | Self { [INFO] [stdout] 23 | model: JitTuningModel::new(synth.num_channels(), synth.group_by(), pooling_mode), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tune` (lib test) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "a2e0b1bf438e46bb8ec8228a7d38395b9d10d0fc9c4ae0bf0e4d4e028cdb0490", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a2e0b1bf438e46bb8ec8228a7d38395b9d10d0fc9c4ae0bf0e4d4e028cdb0490", kill_on_drop: false }` [INFO] [stdout] a2e0b1bf438e46bb8ec8228a7d38395b9d10d0fc9c4ae0bf0e4d4e028cdb0490