[INFO] fetching crate tudelft-serial-upload 2.0.0... [INFO] checking tudelft-serial-upload-2.0.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate tudelft-serial-upload 2.0.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate tudelft-serial-upload 2.0.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tudelft-serial-upload 2.0.0 [INFO] finished tweaking crates.io crate tudelft-serial-upload 2.0.0 [INFO] tweaked toml for crates.io crate tudelft-serial-upload 2.0.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 82 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.21.0 (latest: v0.24.1) [INFO] [stderr] Adding backtrace v0.3.71 (latest: v0.3.73) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding crossterm v0.26.1 (latest: v0.28.1) [INFO] [stderr] Adding gimli v0.28.1 (latest: v0.31.0) [INFO] [stderr] Adding mach v0.1.2 (latest: v0.3.2) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding mio v0.8.11 (latest: v1.0.2) [INFO] [stderr] Adding object v0.32.2 (latest: v0.36.4) [INFO] [stderr] Adding owo-colors v3.5.0 (latest: v4.0.0) [INFO] [stderr] Adding serial2 v0.2.16 (latest: v0.2.26) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows v0.29.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-sys v0.48.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-targets v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.29.0 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.29.0 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.29.0 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.29.0 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.29.0 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.48.5 (latest: v0.52.6) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f0c2bb2a938dae9c749c3fba6825efececf3dcc9bf1cde6757a9e1b6a61b7d5f [INFO] running `Command { std: "docker" "start" "-a" "f0c2bb2a938dae9c749c3fba6825efececf3dcc9bf1cde6757a9e1b6a61b7d5f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f0c2bb2a938dae9c749c3fba6825efececf3dcc9bf1cde6757a9e1b6a61b7d5f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f0c2bb2a938dae9c749c3fba6825efececf3dcc9bf1cde6757a9e1b6a61b7d5f", kill_on_drop: false }` [INFO] [stdout] f0c2bb2a938dae9c749c3fba6825efececf3dcc9bf1cde6757a9e1b6a61b7d5f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5cc7caaea97714641c183f7c5c4fca0efc9caf6fa28576ee267f6ded72434569 [INFO] running `Command { std: "docker" "start" "-a" "5cc7caaea97714641c183f7c5c4fca0efc9caf6fa28576ee267f6ded72434569", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Compiling shlex v1.3.0 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Compiling cc v1.1.15 [INFO] [stderr] Compiling eyre v0.6.12 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking gimli v0.28.1 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking object v0.32.2 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Checking indenter v0.3.3 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking rustc-demangle v0.1.24 [INFO] [stderr] Checking owo-colors v3.5.0 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking tracing-error v0.2.0 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking serial2 v0.2.16 [INFO] [stderr] Checking dissimilar v1.0.9 [INFO] [stderr] Checking color-spantrace v0.2.1 [INFO] [stderr] Checking signal-hook-mio v0.2.4 [INFO] [stderr] Checking crossterm v0.26.1 [INFO] [stderr] Checking expect-test v1.5.0 [INFO] [stderr] Compiling backtrace v0.3.71 [INFO] [stderr] Checking addr2line v0.21.0 [INFO] [stderr] Checking serial_enumerator v0.2.12 [INFO] [stderr] Checking color-eyre v0.6.3 [INFO] [stderr] Checking tudelft-serial-upload v2.0.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serial.rs:43:13 [INFO] [stdout] | [INFO] [stdout] 29 | let mut port = SerialPort::open(&path, |mut s: Settings| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | Ok(Self { [INFO] [stdout] | _____________^ [INFO] [stdout] 44 | | port, [INFO] [stdout] 45 | | path, [INFO] [stdout] 46 | | sequence_number: 0, [INFO] [stdout] 47 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/upload.rs:94:11 [INFO] [stdout] | [INFO] [stdout] 93 | pub fn upload_or_stop(port: PortSelector, file: impl AsRef<[u8]>, dry_run: bool) -> PathBuf { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | match upload(port, file.as_ref(), dry_run) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tudelft-serial-upload` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serial.rs:43:13 [INFO] [stdout] | [INFO] [stdout] 29 | let mut port = SerialPort::open(&path, |mut s: Settings| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | Ok(Self { [INFO] [stdout] | _____________^ [INFO] [stdout] 44 | | port, [INFO] [stdout] 45 | | path, [INFO] [stdout] 46 | | sequence_number: 0, [INFO] [stdout] 47 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/upload.rs:94:11 [INFO] [stdout] | [INFO] [stdout] 93 | pub fn upload_or_stop(port: PortSelector, file: impl AsRef<[u8]>, dry_run: bool) -> PathBuf { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | match upload(port, file.as_ref(), dry_run) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tudelft-serial-upload` (lib test) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "5cc7caaea97714641c183f7c5c4fca0efc9caf6fa28576ee267f6ded72434569", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5cc7caaea97714641c183f7c5c4fca0efc9caf6fa28576ee267f6ded72434569", kill_on_drop: false }` [INFO] [stdout] 5cc7caaea97714641c183f7c5c4fca0efc9caf6fa28576ee267f6ded72434569