[INFO] fetching crate tty-spawn 0.4.0... [INFO] checking tty-spawn-0.4.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate tty-spawn 0.4.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate tty-spawn 0.4.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tty-spawn 0.4.0 [INFO] finished tweaking crates.io crate tty-spawn 0.4.0 [INFO] tweaked toml for crates.io crate tty-spawn 0.4.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 9 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8ab00ebe6bbb00a1e128ebd3fb5bffe9c57b961296d492aae8051ea4681ff320 [INFO] running `Command { std: "docker" "start" "-a" "8ab00ebe6bbb00a1e128ebd3fb5bffe9c57b961296d492aae8051ea4681ff320", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8ab00ebe6bbb00a1e128ebd3fb5bffe9c57b961296d492aae8051ea4681ff320", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8ab00ebe6bbb00a1e128ebd3fb5bffe9c57b961296d492aae8051ea4681ff320", kill_on_drop: false }` [INFO] [stdout] 8ab00ebe6bbb00a1e128ebd3fb5bffe9c57b961296d492aae8051ea4681ff320 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 86005870ce10da106598e6e2e2c9a4b1fa8ab96a0a044ebac534bd90dbc0f244 [INFO] running `Command { std: "docker" "start" "-a" "86005870ce10da106598e6e2e2c9a4b1fa8ab96a0a044ebac534bd90dbc0f244", kill_on_drop: false }` [INFO] [stderr] Compiling cfg_aliases v0.2.1 [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Compiling nix v0.29.0 [INFO] [stderr] Checking tty-spawn v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:38:22 [INFO] [stdout] | [INFO] [stdout] 36 | pub fn new>(cmd: S) -> TtySpawn { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | TtySpawn { [INFO] [stdout] 38 | options: Some(SpawnOptions { [INFO] [stdout] | ______________________^ [INFO] [stdout] 39 | | command: vec![cmd.as_ref().to_os_string()], [INFO] [stdout] 40 | | stdin_file: None, [INFO] [stdout] 41 | | stdout_file: None, [INFO] [stdout] ... | [INFO] [stdout] 46 | | no_raw: false, [INFO] [stdout] 47 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:105:13 [INFO] [stdout] | [INFO] [stdout] 99 | pub fn stdin_path>(&mut self, path: P) -> Result<&mut Self, io::Error> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 105 | / File::options() [INFO] [stdout] 106 | | .read(true) [INFO] [stdout] 107 | | .write(true) [INFO] [stdout] 108 | | .custom_flags(O_NONBLOCK) [INFO] [stdout] 109 | | .open(path)?, [INFO] [stdout] | |____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:128:29 [INFO] [stdout] | [INFO] [stdout] 125 | path: P, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 128 | Ok(self.stdout_file(if !truncate { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 129 | | File::options().append(true).create(true).open(path)? [INFO] [stdout] 130 | | } else { [INFO] [stdout] 131 | | File::options() [INFO] [stdout] ... | [INFO] [stdout] 135 | | .open(path)? [INFO] [stdout] 136 | | })) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:309:25 [INFO] [stdout] | [INFO] [stdout] 309 | .filter_map(|x| CString::new(x.as_bytes()).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:38:22 [INFO] [stdout] | [INFO] [stdout] 36 | pub fn new>(cmd: S) -> TtySpawn { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | TtySpawn { [INFO] [stdout] 38 | options: Some(SpawnOptions { [INFO] [stdout] | ______________________^ [INFO] [stdout] 39 | | command: vec![cmd.as_ref().to_os_string()], [INFO] [stdout] 40 | | stdin_file: None, [INFO] [stdout] 41 | | stdout_file: None, [INFO] [stdout] ... | [INFO] [stdout] 46 | | no_raw: false, [INFO] [stdout] 47 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:105:13 [INFO] [stdout] | [INFO] [stdout] 99 | pub fn stdin_path>(&mut self, path: P) -> Result<&mut Self, io::Error> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 105 | / File::options() [INFO] [stdout] 106 | | .read(true) [INFO] [stdout] 107 | | .write(true) [INFO] [stdout] 108 | | .custom_flags(O_NONBLOCK) [INFO] [stdout] 109 | | .open(path)?, [INFO] [stdout] | |____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tty-spawn` (lib) due to 5 previous errors [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:128:29 [INFO] [stdout] | [INFO] [stdout] 125 | path: P, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 128 | Ok(self.stdout_file(if !truncate { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 129 | | File::options().append(true).create(true).open(path)? [INFO] [stdout] 130 | | } else { [INFO] [stdout] 131 | | File::options() [INFO] [stdout] ... | [INFO] [stdout] 135 | | .open(path)? [INFO] [stdout] 136 | | })) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:309:25 [INFO] [stdout] | [INFO] [stdout] 309 | .filter_map(|x| CString::new(x.as_bytes()).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tty-spawn` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "86005870ce10da106598e6e2e2c9a4b1fa8ab96a0a044ebac534bd90dbc0f244", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "86005870ce10da106598e6e2e2c9a4b1fa8ab96a0a044ebac534bd90dbc0f244", kill_on_drop: false }` [INFO] [stdout] 86005870ce10da106598e6e2e2c9a4b1fa8ab96a0a044ebac534bd90dbc0f244