[INFO] fetching crate ttrace 0.1.4... [INFO] checking ttrace-0.1.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ttrace 0.1.4 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate ttrace 0.1.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ttrace 0.1.4 [INFO] finished tweaking crates.io crate ttrace 0.1.4 [INFO] tweaked toml for crates.io crate ttrace 0.1.4 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate ttrace 0.1.4 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e334e9eae6452debbdf09837493def49cd5a3a60c09014bf623923fdfb52610e [INFO] running `Command { std: "docker" "start" "-a" "e334e9eae6452debbdf09837493def49cd5a3a60c09014bf623923fdfb52610e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e334e9eae6452debbdf09837493def49cd5a3a60c09014bf623923fdfb52610e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e334e9eae6452debbdf09837493def49cd5a3a60c09014bf623923fdfb52610e", kill_on_drop: false }` [INFO] [stdout] e334e9eae6452debbdf09837493def49cd5a3a60c09014bf623923fdfb52610e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a6e9e9f1494efbb6ca35adc5d5e9bfa57d5f862c1482e3969c57f59c8c5cb009 [INFO] running `Command { std: "docker" "start" "-a" "a6e9e9f1494efbb6ca35adc5d5e9bfa57d5f862c1482e3969c57f59c8c5cb009", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.82 [INFO] [stderr] Compiling serde v1.0.201 [INFO] [stderr] Compiling libc v0.2.154 [INFO] [stderr] Compiling cc v1.0.97 [INFO] [stderr] Compiling thiserror v1.0.60 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Compiling eyre v0.6.12 [INFO] [stderr] Compiling serde_json v1.0.117 [INFO] [stderr] Checking indenter v0.3.3 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Checking either v1.11.0 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking hashlink v0.9.0 [INFO] [stderr] Compiling syn v2.0.62 [INFO] [stderr] Compiling libsqlite3-sys v0.28.0 [INFO] [stderr] Checking dirs v1.0.5 [INFO] [stderr] Checking clap v4.5.4 [INFO] [stderr] Compiling serde_derive v1.0.201 [INFO] [stderr] Compiling thiserror-impl v1.0.60 [INFO] [stderr] Checking pwd v1.4.0 [INFO] [stderr] Checking expanduser v1.2.2 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking someutil v0.1.0 [INFO] [stderr] Checking termfmt v0.2.1 [INFO] [stderr] Checking rusqlite v0.31.0 [INFO] [stderr] Checking ttrace v0.1.4 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:186:35 [INFO] [stdout] | [INFO] [stdout] 186 | .filter_map(|day| task_repository.day_with_tasks(day).ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/database.rs:11:8 [INFO] [stdout] | [INFO] [stdout] 10 | let connection = Connection::open_with_flags(path, flags)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 11 | Ok(connection.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/day.rs:25:12 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn new(connection: Rc) -> eyre::Result { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | Ok(Self { connection }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/day.rs:103:9 [INFO] [stdout] | [INFO] [stdout] 102 | fn get(&self, statement: &str, parameters: impl Params) -> eyre::Result { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | / self.connection [INFO] [stdout] 104 | | .query_row(statement, parameters, day_from_row) [INFO] [stdout] 105 | | .wrap_err("could not query day") [INFO] [stdout] | |____________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/day.rs:110:9 [INFO] [stdout] | [INFO] [stdout] 109 | fn query(&self, query: &str, parameters: impl Params) -> eyre::Result> { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | / self.connection [INFO] [stdout] 111 | | .prepare(query)? [INFO] [stdout] 112 | | .query_map(parameters, day_from_row) [INFO] [stdout] 113 | | .wrap_err("could not execute sql statement") [INFO] [stdout] ... | [INFO] [stdout] 116 | | .collect::>() [INFO] [stdout] 117 | | .wrap_err("cannot convert tasks from sql statement") [INFO] [stdout] | |________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:186:35 [INFO] [stdout] | [INFO] [stdout] 186 | .filter_map(|day| task_repository.day_with_tasks(day).ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/database.rs:11:8 [INFO] [stdout] | [INFO] [stdout] 10 | let connection = Connection::open_with_flags(path, flags)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 11 | Ok(connection.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/day.rs:25:12 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn new(connection: Rc) -> eyre::Result { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | Ok(Self { connection }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/task.rs:170:12 [INFO] [stdout] | [INFO] [stdout] 159 | pub fn new(connection: Rc) -> eyre::Result { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 170 | Ok(Self { connection }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/day.rs:103:9 [INFO] [stdout] | [INFO] [stdout] 102 | fn get(&self, statement: &str, parameters: impl Params) -> eyre::Result { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | / self.connection [INFO] [stdout] 104 | | .query_row(statement, parameters, day_from_row) [INFO] [stdout] 105 | | .wrap_err("could not query day") [INFO] [stdout] | |____________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/task.rs:186:9 [INFO] [stdout] | [INFO] [stdout] 185 | fn get(&self, query: &str, params: impl Params) -> eyre::Result> { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 186 | / self.connection [INFO] [stdout] 187 | | .query_row(query, params, task_from_row) [INFO] [stdout] 188 | | .wrap_err("could not execute sql statement") [INFO] [stdout] | |________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/day.rs:110:9 [INFO] [stdout] | [INFO] [stdout] 109 | fn query(&self, query: &str, parameters: impl Params) -> eyre::Result> { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | / self.connection [INFO] [stdout] 111 | | .prepare(query)? [INFO] [stdout] 112 | | .query_map(parameters, day_from_row) [INFO] [stdout] 113 | | .wrap_err("could not execute sql statement") [INFO] [stdout] ... | [INFO] [stdout] 116 | | .collect::>() [INFO] [stdout] 117 | | .wrap_err("cannot convert tasks from sql statement") [INFO] [stdout] | |________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/task.rs:193:9 [INFO] [stdout] | [INFO] [stdout] 192 | fn query(&self, query: &str, params: impl Params) -> eyre::Result>> { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 193 | / self.connection [INFO] [stdout] 194 | | .prepare(query)? [INFO] [stdout] 195 | | .query_map(params, task_from_row) [INFO] [stdout] 196 | | .wrap_err("could not execute sql statement") [INFO] [stdout] ... | [INFO] [stdout] 199 | | .collect::>() [INFO] [stdout] 200 | | .wrap_err("cannot convert tasks from sql statement") [INFO] [stdout] | |________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/task.rs:170:12 [INFO] [stdout] | [INFO] [stdout] 159 | pub fn new(connection: Rc) -> eyre::Result { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 170 | Ok(Self { connection }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/task.rs:186:9 [INFO] [stdout] | [INFO] [stdout] 185 | fn get(&self, query: &str, params: impl Params) -> eyre::Result> { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 186 | / self.connection [INFO] [stdout] 187 | | .query_row(query, params, task_from_row) [INFO] [stdout] 188 | | .wrap_err("could not execute sql statement") [INFO] [stdout] | |________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/task.rs:193:9 [INFO] [stdout] | [INFO] [stdout] 192 | fn query(&self, query: &str, params: impl Params) -> eyre::Result>> { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 193 | / self.connection [INFO] [stdout] 194 | | .prepare(query)? [INFO] [stdout] 195 | | .query_map(params, task_from_row) [INFO] [stdout] 196 | | .wrap_err("could not execute sql statement") [INFO] [stdout] ... | [INFO] [stdout] 199 | | .collect::>() [INFO] [stdout] 200 | | .wrap_err("cannot convert tasks from sql statement") [INFO] [stdout] | |________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ttrace` (bin "ttrace" test) due to 9 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `ttrace` (bin "ttrace") due to 9 previous errors [INFO] running `Command { std: "docker" "inspect" "a6e9e9f1494efbb6ca35adc5d5e9bfa57d5f862c1482e3969c57f59c8c5cb009", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a6e9e9f1494efbb6ca35adc5d5e9bfa57d5f862c1482e3969c57f59c8c5cb009", kill_on_drop: false }` [INFO] [stdout] a6e9e9f1494efbb6ca35adc5d5e9bfa57d5f862c1482e3969c57f59c8c5cb009