[INFO] fetching crate tsk_lib 0.0.0... [INFO] checking tsk_lib-0.0.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate tsk_lib 0.0.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate tsk_lib 0.0.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tsk_lib 0.0.0 [INFO] finished tweaking crates.io crate tsk_lib 0.0.0 [INFO] tweaked toml for crates.io crate tsk_lib 0.0.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 42 packages to latest compatible versions [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6e25b2ce490e0d0a3419ccd0329294a30def9f71b1ea2e46e3497a89263105c5 [INFO] running `Command { std: "docker" "start" "-a" "6e25b2ce490e0d0a3419ccd0329294a30def9f71b1ea2e46e3497a89263105c5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6e25b2ce490e0d0a3419ccd0329294a30def9f71b1ea2e46e3497a89263105c5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6e25b2ce490e0d0a3419ccd0329294a30def9f71b1ea2e46e3497a89263105c5", kill_on_drop: false }` [INFO] [stdout] 6e25b2ce490e0d0a3419ccd0329294a30def9f71b1ea2e46e3497a89263105c5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c1aba5afd8c2fae8dde5abee737099b7127b4113a3127a5bf017aef49ba7e7e7 [INFO] running `Command { std: "docker" "start" "-a" "c1aba5afd8c2fae8dde5abee737099b7127b4113a3127a5bf017aef49ba7e7e7", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking tsk_lib v0.0.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `InfixExpression` [INFO] [stdout] --> src/list.rs:23:30 [INFO] [stdout] | [INFO] [stdout] 23 | use query::ast::{Expression, InfixExpression, AST}; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `InfixExpression` [INFO] [stdout] --> src/list.rs:23:30 [INFO] [stdout] | [INFO] [stdout] 23 | use query::ast::{Expression, InfixExpression, AST}; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `chrono::TimeZone::datetime_from_str`: use `DateTime::parse_from_str` or `NaiveDateTime::parse_from_str` with `and_utc()` or `and_local_timezone()` instead [INFO] [stdout] --> src/query/tokens.rs:63:33 [INFO] [stdout] | [INFO] [stdout] 63 | if let Ok(date) = Local.datetime_from_str(s, "%Y-%m-%d %r") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `chrono::DateTime::::date`: Use `date_naive()` instead [INFO] [stdout] --> src/tasks/task.rs:115:33 [INFO] [stdout] | [INFO] [stdout] 115 | match self.created_date.date().cmp(&other.created_date.date()) { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `chrono::DateTime::::date`: Use `date_naive()` instead [INFO] [stdout] --> src/tasks/task.rs:115:64 [INFO] [stdout] | [INFO] [stdout] 115 | match self.created_date.date().cmp(&other.created_date.date()) { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `chrono::TimeZone::datetime_from_str`: use `DateTime::parse_from_str` or `NaiveDateTime::parse_from_str` with `and_utc()` or `and_local_timezone()` instead [INFO] [stdout] --> src/query/tokens.rs:63:33 [INFO] [stdout] | [INFO] [stdout] 63 | if let Ok(date) = Local.datetime_from_str(s, "%Y-%m-%d %r") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `chrono::DateTime::::date`: Use `date_naive()` instead [INFO] [stdout] --> src/tasks/task.rs:115:33 [INFO] [stdout] | [INFO] [stdout] 115 | match self.created_date.date().cmp(&other.created_date.date()) { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `chrono::DateTime::::date`: Use `date_naive()` instead [INFO] [stdout] --> src/tasks/task.rs:115:64 [INFO] [stdout] | [INFO] [stdout] 115 | match self.created_date.date().cmp(&other.created_date.date()) { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `exp` [INFO] [stdout] --> src/list.rs:142:31 [INFO] [stdout] | [INFO] [stdout] 142 | fn eval<'a>(&'a mut self, exp: Expression) -> Vec<&'a Task> { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_exp` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `exp` [INFO] [stdout] --> src/list.rs:142:31 [INFO] [stdout] | [INFO] [stdout] 142 | fn eval<'a>(&'a mut self, exp: Expression) -> Vec<&'a Task> { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_exp` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/backends/file.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 53 | fs::File::create(file)?.write_all(list.as_bytes()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/backends/file.rs:60:9 [INFO] [stdout] | [INFO] [stdout] 57 | let mut file = fs::File::open(Backend::file(config)?)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | serde_json::from_str(&contents) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/query/parser.rs:290:12 [INFO] [stdout] | [INFO] [stdout] 259 | fn parse_infix_exp(&mut self, left: Expression) -> ExpResult { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 279 | let right = self.parse_expression(precedence)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 280 | [INFO] [stdout] 281 | let exp = InfixExpression { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 290 | Ok(Expression::Infix(Box::new(exp))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/backends/file.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 53 | fs::File::create(file)?.write_all(list.as_bytes()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/backends/file.rs:60:9 [INFO] [stdout] | [INFO] [stdout] 57 | let mut file = fs::File::open(Backend::file(config)?)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | serde_json::from_str(&contents) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/query/parser.rs:290:12 [INFO] [stdout] | [INFO] [stdout] 259 | fn parse_infix_exp(&mut self, left: Expression) -> ExpResult { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 279 | let right = self.parse_expression(precedence)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 280 | [INFO] [stdout] 281 | let exp = InfixExpression { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 290 | Ok(Expression::Infix(Box::new(exp))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tsk_lib` (lib) due to 4 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 3 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tsk_lib` (lib test) due to 4 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "c1aba5afd8c2fae8dde5abee737099b7127b4113a3127a5bf017aef49ba7e7e7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c1aba5afd8c2fae8dde5abee737099b7127b4113a3127a5bf017aef49ba7e7e7", kill_on_drop: false }` [INFO] [stdout] c1aba5afd8c2fae8dde5abee737099b7127b4113a3127a5bf017aef49ba7e7e7