[INFO] crate tshell 0.2.2 is already in cache [INFO] checking tshell-0.2.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate tshell 0.2.2 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate tshell 0.2.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tshell 0.2.2 [INFO] finished tweaking crates.io crate tshell 0.2.2 [INFO] tweaked toml for crates.io crate tshell 0.2.2 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 20 packages to latest compatible versions [INFO] [stderr] Adding aho-corasick v0.5.3 (latest: v1.1.3) [INFO] [stderr] Adding bitflags v0.4.0 (latest: v2.6.0) [INFO] [stderr] Adding encode_unicode v0.1.3 (latest: v1.0.0) [INFO] [stderr] Adding env_logger v0.3.5 (latest: v0.11.5) [INFO] [stderr] Adding log v0.3.9 (latest: v0.4.22) [INFO] [stderr] Adding memchr v0.1.11 (latest: v2.7.4) [INFO] [stderr] Adding nix v0.5.1 (latest: v0.29.0) [INFO] [stderr] Adding regex v0.1.80 (latest: v1.10.6) [INFO] [stderr] Adding regex-syntax v0.3.9 (latest: v0.8.4) [INFO] [stderr] Adding rustyline v1.0.0 (latest: v14.0.0) [INFO] [stderr] Adding thread-id v2.0.0 (latest: v4.2.2) [INFO] [stderr] Adding thread_local v0.2.7 (latest: v1.1.8) [INFO] [stderr] Adding utf8-ranges v0.1.3 (latest: v1.0.5) [INFO] [stderr] Adding winapi v0.2.8 (latest: v0.3.9) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] aa58c07a91a581cb4a0d4f0ed8772941435b6151cb43af77a03b2a0f93f16d20 [INFO] running `Command { std: "docker" "start" "-a" "aa58c07a91a581cb4a0d4f0ed8772941435b6151cb43af77a03b2a0f93f16d20", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "aa58c07a91a581cb4a0d4f0ed8772941435b6151cb43af77a03b2a0f93f16d20", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "aa58c07a91a581cb4a0d4f0ed8772941435b6151cb43af77a03b2a0f93f16d20", kill_on_drop: false }` [INFO] [stdout] aa58c07a91a581cb4a0d4f0ed8772941435b6151cb43af77a03b2a0f93f16d20 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] adfee134ae6328c3ea05140d3abc25796b8ea3adf96fb38ec89383866bc531a1 [INFO] running `Command { std: "docker" "start" "-a" "adfee134ae6328c3ea05140d3abc25796b8ea3adf96fb38ec89383866bc531a1", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling winapi-build v0.1.1 [INFO] [stderr] Checking winapi v0.2.8 [INFO] [stderr] Checking utf8-ranges v0.1.3 [INFO] [stderr] Checking bitflags v0.4.0 [INFO] [stderr] Checking regex-syntax v0.3.9 [INFO] [stderr] Checking encode_unicode v0.1.3 [INFO] [stderr] Checking memchr v0.1.11 [INFO] [stderr] Checking nix v0.5.1 [INFO] [stderr] Compiling kernel32-sys v0.2.2 [INFO] [stderr] Checking aho-corasick v0.5.3 [INFO] [stderr] Checking thread-id v2.0.0 [INFO] [stderr] Checking thread_local v0.2.7 [INFO] [stderr] Checking regex v0.1.80 [INFO] [stderr] Checking rustyline v1.0.0 [INFO] [stderr] Checking env_logger v0.3.5 [INFO] [stderr] Checking tshell v0.2.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> src/commands.rs:312:42 [INFO] [stdout] | [INFO] [stdout] 312 | context: Arc::new(Mutex::new((context))) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 312 - context: Arc::new(Mutex::new((context))) [INFO] [stdout] 312 + context: Arc::new(Mutex::new(context)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> src/commands.rs:312:42 [INFO] [stdout] | [INFO] [stdout] 312 | context: Arc::new(Mutex::new((context))) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 312 - context: Arc::new(Mutex::new((context))) [INFO] [stdout] 312 + context: Arc::new(Mutex::new(context)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::env::home_dir`: This function's behavior may be unexpected on Windows. Consider using a crate from crates.io instead. [INFO] [stdout] --> src/commands.rs:394:29 [INFO] [stdout] | [INFO] [stdout] 394 | let home_dir = env::home_dir() [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/commands.rs:10:24 [INFO] [stdout] | [INFO] [stdout] 10 | pub type CallBack = Fn(HashMap, &mut Option, &HashMap) -> CommandResult>; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 10 | pub type CallBack = dyn Fn(HashMap, &mut Option, &HashMap) -> CommandResult>; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::env::home_dir`: This function's behavior may be unexpected on Windows. Consider using a crate from crates.io instead. [INFO] [stdout] --> src/commands.rs:394:29 [INFO] [stdout] | [INFO] [stdout] 394 | let home_dir = env::home_dir() [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/commands.rs:10:24 [INFO] [stdout] | [INFO] [stdout] 10 | pub type CallBack = Fn(HashMap, &mut Option, &HashMap) -> CommandResult>; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 10 | pub type CallBack = dyn Fn(HashMap, &mut Option, &HashMap) -> CommandResult>; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `core::str::::trim_left`: superseded by `trim_start` [INFO] [stdout] --> src/commands.rs:321:42 [INFO] [stdout] | [INFO] [stdout] 321 | let mut levels: Vec<&str> = line.trim_left().split_whitespace().collect(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: replace the use of the deprecated method [INFO] [stdout] | [INFO] [stdout] 321 | let mut levels: Vec<&str> = line.trim_start().split_whitespace().collect(); [INFO] [stdout] | ~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `core::str::::trim_left`: superseded by `trim_start` [INFO] [stdout] --> src/commands.rs:321:42 [INFO] [stdout] | [INFO] [stdout] 321 | let mut levels: Vec<&str> = line.trim_left().split_whitespace().collect(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: replace the use of the deprecated method [INFO] [stdout] | [INFO] [stdout] 321 | let mut levels: Vec<&str> = line.trim_start().split_whitespace().collect(); [INFO] [stdout] | ~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands.rs:38:24 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn new(cmd: &str, conditional: Option<&str>, help: &str, callback: Option>>) -> Node { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | sub_nodes: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands.rs:312:22 [INFO] [stdout] | [INFO] [stdout] 307 | pub fn new(name: &str, version: &str, root: Node, context: Option) -> CommandTree { [INFO] [stdout] | ------------- ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 312 | context: Arc::new(Mutex::new((context))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tshell` (lib) due to 3 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands.rs:38:24 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn new(cmd: &str, conditional: Option<&str>, help: &str, callback: Option>>) -> Node { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | sub_nodes: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands.rs:312:22 [INFO] [stdout] | [INFO] [stdout] 307 | pub fn new(name: &str, version: &str, root: Node, context: Option) -> CommandTree { [INFO] [stdout] | ------------- ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 312 | context: Arc::new(Mutex::new((context))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tshell` (lib test) due to 3 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "adfee134ae6328c3ea05140d3abc25796b8ea3adf96fb38ec89383866bc531a1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "adfee134ae6328c3ea05140d3abc25796b8ea3adf96fb38ec89383866bc531a1", kill_on_drop: false }` [INFO] [stdout] adfee134ae6328c3ea05140d3abc25796b8ea3adf96fb38ec89383866bc531a1