[INFO] fetching crate tsfile-writer 0.2.1... [INFO] checking tsfile-writer-0.2.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate tsfile-writer 0.2.1 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate tsfile-writer 0.2.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tsfile-writer 0.2.1 [INFO] finished tweaking crates.io crate tsfile-writer 0.2.1 [INFO] tweaked toml for crates.io crate tsfile-writer 0.2.1 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 52 packages to latest compatible versions [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding ipnetwork v0.18.0 (latest: v0.20.0) [INFO] [stderr] Adding ordered-float v1.1.1 (latest: v4.2.2) [INFO] [stderr] Adding pnet v0.29.0 (latest: v0.35.0) [INFO] [stderr] Adding pnet_base v0.29.0 (latest: v0.35.0) [INFO] [stderr] Adding pnet_datalink v0.29.0 (latest: v0.35.0) [INFO] [stderr] Adding pnet_macros v0.29.0 (latest: v0.35.0) [INFO] [stderr] Adding pnet_macros_support v0.29.0 (latest: v0.35.0) [INFO] [stderr] Adding pnet_packet v0.29.0 (latest: v0.35.0) [INFO] [stderr] Adding pnet_sys v0.29.0 (latest: v0.35.0) [INFO] [stderr] Adding pnet_transport v0.29.0 (latest: v0.35.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding thrift v0.14.2 (latest: v0.17.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] da51b603658cd652c8f69703cae6b06970226c464263510af8110fa98d27bc8c [INFO] running `Command { std: "docker" "start" "-a" "da51b603658cd652c8f69703cae6b06970226c464263510af8110fa98d27bc8c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "da51b603658cd652c8f69703cae6b06970226c464263510af8110fa98d27bc8c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "da51b603658cd652c8f69703cae6b06970226c464263510af8110fa98d27bc8c", kill_on_drop: false }` [INFO] [stdout] da51b603658cd652c8f69703cae6b06970226c464263510af8110fa98d27bc8c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e34e13d103048bf4e3ac7e3c267a41450cc8a786f760ee57521f700f03b08eda [INFO] running `Command { std: "docker" "start" "-a" "e34e13d103048bf4e3ac7e3c267a41450cc8a786f760ee57521f700f03b08eda", kill_on_drop: false }` [INFO] [stderr] Checking tsfile-writer v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: struct `ChunkGroup` is never constructed [INFO] [stdout] --> src/writer/mod.rs:838:8 [INFO] [stdout] | [INFO] [stdout] 838 | struct ChunkGroup<'a> { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/writer/tsfile_writer.rs:335:12 [INFO] [stdout] | [INFO] [stdout] 301 | file_writer: T, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 304 | let group_writers = schema [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 334 | let io_writer = TsFileIoWriter::new(file_writer, config)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 335 | Ok(TsFileWriter { [INFO] [stdout] | ____________^ [INFO] [stdout] 336 | | filename: String::from(""), [INFO] [stdout] 337 | | schema, [INFO] [stdout] 338 | | group_writers, [INFO] [stdout] ... | [INFO] [stdout] 345 | | file_io_writer: io_writer, [INFO] [stdout] 346 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/writer/tsfile_writer.rs:310:25 [INFO] [stdout] | [INFO] [stdout] 310 | path.borrow(), [INFO] [stdout] | ^^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Borrow`, so calling `borrow` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tsfile-writer` (lib) due to 2 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: struct `ChunkGroup` is never constructed [INFO] [stdout] --> src/writer/mod.rs:838:8 [INFO] [stdout] | [INFO] [stdout] 838 | struct ChunkGroup<'a> { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/writer/tsfile_writer.rs:335:12 [INFO] [stdout] | [INFO] [stdout] 301 | file_writer: T, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 304 | let group_writers = schema [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 334 | let io_writer = TsFileIoWriter::new(file_writer, config)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 335 | Ok(TsFileWriter { [INFO] [stdout] | ____________^ [INFO] [stdout] 336 | | filename: String::from(""), [INFO] [stdout] 337 | | schema, [INFO] [stdout] 338 | | group_writers, [INFO] [stdout] ... | [INFO] [stdout] 345 | | file_io_writer: io_writer, [INFO] [stdout] 346 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/writer/tsfile_writer.rs:310:25 [INFO] [stdout] | [INFO] [stdout] 310 | path.borrow(), [INFO] [stdout] | ^^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Borrow`, so calling `borrow` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tsfile-writer` (lib test) due to 2 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "e34e13d103048bf4e3ac7e3c267a41450cc8a786f760ee57521f700f03b08eda", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e34e13d103048bf4e3ac7e3c267a41450cc8a786f760ee57521f700f03b08eda", kill_on_drop: false }` [INFO] [stdout] e34e13d103048bf4e3ac7e3c267a41450cc8a786f760ee57521f700f03b08eda