[INFO] fetching crate ts-analyzer 0.2.1... [INFO] checking ts-analyzer-0.2.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ts-analyzer 0.2.1 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate ts-analyzer 0.2.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ts-analyzer 0.2.1 [INFO] finished tweaking crates.io crate ts-analyzer 0.2.1 [INFO] tweaked toml for crates.io crate ts-analyzer 0.2.1 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate ts-analyzer 0.2.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 94bac9b53a2cecbbbd2a71f36ee5db33a7455d63a748eff3b4f1c1a4276a5d43 [INFO] running `Command { std: "docker" "start" "-a" "94bac9b53a2cecbbbd2a71f36ee5db33a7455d63a748eff3b4f1c1a4276a5d43", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "94bac9b53a2cecbbbd2a71f36ee5db33a7455d63a748eff3b4f1c1a4276a5d43", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "94bac9b53a2cecbbbd2a71f36ee5db33a7455d63a748eff3b4f1c1a4276a5d43", kill_on_drop: false }` [INFO] [stdout] 94bac9b53a2cecbbbd2a71f36ee5db33a7455d63a748eff3b4f1c1a4276a5d43 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 441dd37ca42b0e5392220f412b7c7120064b821c753804323324b8f7ff90168b [INFO] running `Command { std: "docker" "start" "-a" "441dd37ca42b0e5392220f412b7c7120064b821c753804323324b8f7ff90168b", kill_on_drop: false }` [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Compiling radium v0.7.0 [INFO] [stderr] Checking regex-syntax v0.8.3 [INFO] [stderr] Checking tap v1.0.1 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Checking anstyle-query v1.0.3 [INFO] [stderr] Compiling syn v2.0.66 [INFO] [stderr] Checking funty v2.0.0 [INFO] [stderr] Checking memmem v0.1.1 [INFO] [stderr] Checking wyz v0.5.1 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Checking bitvec v1.0.1 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking ts-analyzer v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `crate::packet::payload::TSPayload` [INFO] [stdout] --> src/reader.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use crate::packet::payload::TSPayload; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self` [INFO] [stdout] --> src/reader.rs:9:39 [INFO] [stdout] | [INFO] [stdout] 9 | use crate::helpers::tracked_payload::{self, TrackedPayload}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Searcher` and `TwoWaySearcher` [INFO] [stdout] --> src/reader.rs:13:14 [INFO] [stdout] | [INFO] [stdout] 13 | use memmem::{Searcher, TwoWaySearcher}; [INFO] [stdout] | ^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `bitvec::macros::internal::funty::Fundamental` [INFO] [stdout] --> src/packet/header.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use bitvec::macros::internal::funty::Fundamental; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self` [INFO] [stdout] --> src/helpers/tracked_payload.rs:3:30 [INFO] [stdout] | [INFO] [stdout] 3 | use crate::packet::payload::{self, TSPayload}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Searcher` and `TwoWaySearcher` [INFO] [stdout] --> src/helpers/tracked_payload.rs:8:14 [INFO] [stdout] | [INFO] [stdout] 8 | use memmem::{Searcher, TwoWaySearcher}; [INFO] [stdout] | ^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `TransportScramblingControl` is more private than the item `TSHeader::tsc` [INFO] [stdout] --> src/packet/header.rs:163:5 [INFO] [stdout] | [INFO] [stdout] 163 | pub fn tsc(&self) -> TransportScramblingControl { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ method `TSHeader::tsc` is reachable at visibility `pub` [INFO] [stdout] | [INFO] [stdout] note: but type `TransportScramblingControl` is only usable at visibility `pub(crate)` [INFO] [stdout] --> src/lib.rs:30:1 [INFO] [stdout] | [INFO] [stdout] 30 | enum TransportScramblingControl { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(private_interfaces)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `AdaptationFieldControl` is more private than the item `TSHeader::adaptation_field_control` [INFO] [stdout] --> src/packet/header.rs:168:5 [INFO] [stdout] | [INFO] [stdout] 168 | pub fn adaptation_field_control(&self) -> AdaptationFieldControl { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ method `TSHeader::adaptation_field_control` is reachable at visibility `pub` [INFO] [stdout] | [INFO] [stdout] note: but type `AdaptationFieldControl` is only usable at visibility `pub(crate)` [INFO] [stdout] --> src/lib.rs:37:1 [INFO] [stdout] | [INFO] [stdout] 37 | enum AdaptationFieldControl { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `Errors` is never used [INFO] [stdout] --> src/lib.rs:45:6 [INFO] [stdout] | [INFO] [stdout] 45 | enum Errors { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `filename` is never read [INFO] [stdout] --> src/reader.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 16 | pub struct TSReader { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] 17 | /// Filename for the file being read. Only really used for logging. [INFO] [stdout] 18 | filename: String, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `pcr`, `opcr`, `splice_countdown`, `transport_private_data_length`, and `transport_private_data` are never read [INFO] [stdout] --> src/packet/adaptation_field.rs:66:5 [INFO] [stdout] | [INFO] [stdout] 38 | pub struct DataAdaptationField { [INFO] [stdout] | ------------------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 66 | pcr: Option, [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 70 | opcr: Option, [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 74 | splice_countdown: Option, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 78 | transport_private_data_length: Option, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 83 | transport_private_data: Option>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `DataAdaptationField` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/helpers/tracked_payload.rs:21:12 [INFO] [stdout] | [INFO] [stdout] 19 | impl TrackedPayload { [INFO] [stdout] | ------------------- associated function in this implementation [INFO] [stdout] 20 | /// Create a new tracked payload [INFO] [stdout] 21 | pub fn new(pid: u16) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader.rs:98:12 [INFO] [stdout] | [INFO] [stdout] 42 | pub fn new(filename: &str, mut buf_reader: BufReader) -> Result> { [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | Ok(TSReader { [INFO] [stdout] | ____________^ [INFO] [stdout] 99 | | filename: filename.to_string(), [INFO] [stdout] 100 | | buf_reader, [INFO] [stdout] 101 | | sync_alignment, [INFO] [stdout] ... | [INFO] [stdout] 104 | | tracked_payloads: Vec::new(), [INFO] [stdout] 105 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/helpers/tracked_payload.rs:37:12 [INFO] [stdout] | [INFO] [stdout] 32 | let payload = match packet.payload() { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | Some(payload) => payload, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | Ok(TrackedPayload { [INFO] [stdout] | ____________^ [INFO] [stdout] 38 | | pid: packet.header().pid(), [INFO] [stdout] 39 | | payloads: vec!(payload) [INFO] [stdout] 40 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/helpers/tracked_payload.rs:112:68 [INFO] [stdout] | [INFO] [stdout] 112 | let payload_data: Box<[u8]> = data_vec.iter().flat_map(|s| s.clone().into_vec()).collect(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 12 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ts-analyzer` (lib) due to 4 previous errors; 12 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "441dd37ca42b0e5392220f412b7c7120064b821c753804323324b8f7ff90168b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "441dd37ca42b0e5392220f412b7c7120064b821c753804323324b8f7ff90168b", kill_on_drop: false }` [INFO] [stdout] 441dd37ca42b0e5392220f412b7c7120064b821c753804323324b8f7ff90168b