[INFO] fetching crate trustfall-rustdoc-adapter 28.1.3... [INFO] checking trustfall-rustdoc-adapter-28.1.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate trustfall-rustdoc-adapter 28.1.3 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate trustfall-rustdoc-adapter 28.1.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-4-tc2/source/rust-toolchain.toml [INFO] started tweaking crates.io crate trustfall-rustdoc-adapter 28.1.3 [INFO] finished tweaking crates.io crate trustfall-rustdoc-adapter 28.1.3 [INFO] tweaked toml for crates.io crate trustfall-rustdoc-adapter 28.1.3 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 54 packages to latest compatible versions [INFO] [stderr] Adding async-graphql-parser v6.0.11 (latest: v7.0.8) [INFO] [stderr] Adding async-graphql-value v6.0.11 (latest: v7.0.8) [INFO] [stderr] Adding encode_unicode v0.3.6 (latest: v1.0.0) [INFO] [stderr] Adding itertools v0.11.0 (latest: v0.13.0) [INFO] [stderr] Adding itertools v0.12.1 (latest: v0.13.0) [INFO] [stderr] Adding rustdoc-types v0.24.0 (latest: v0.29.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 09924e75e034a9ecfdb97d771c70464c9c753c0b77f762a5aab5b7afb56099e2 [INFO] running `Command { std: "docker" "start" "-a" "09924e75e034a9ecfdb97d771c70464c9c753c0b77f762a5aab5b7afb56099e2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "09924e75e034a9ecfdb97d771c70464c9c753c0b77f762a5aab5b7afb56099e2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "09924e75e034a9ecfdb97d771c70464c9c753c0b77f762a5aab5b7afb56099e2", kill_on_drop: false }` [INFO] [stdout] 09924e75e034a9ecfdb97d771c70464c9c753c0b77f762a5aab5b7afb56099e2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6378a7794a78cfe769627302c0d4ea75e5e0c018e515bfb309b5cd0d14a10e68 [INFO] running `Command { std: "docker" "start" "-a" "6378a7794a78cfe769627302c0d4ea75e5e0c018e515bfb309b5cd0d14a10e68", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking ucd-trie v0.1.6 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking maplit v1.0.2 [INFO] [stderr] Compiling trustfall_derive v0.3.1 [INFO] [stderr] Checking unicode-segmentation v1.11.0 [INFO] [stderr] Checking itertools v0.11.0 [INFO] [stderr] Checking similar v2.6.0 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking version_check v0.9.5 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking pest v2.7.11 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking rustdoc-types v0.24.0 [INFO] [stderr] Checking similar-asserts v1.5.0 [INFO] [stderr] Checking async-graphql-value v6.0.11 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking async-graphql-parser v6.0.11 [INFO] [stderr] Checking trustfall_core v0.7.1 [INFO] [stderr] Checking trustfall v0.7.1 [INFO] [stderr] Checking trustfall-rustdoc-adapter v28.1.3 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/adapter/edges.rs:249:22 [INFO] [stdout] | [INFO] [stdout] 241 | let field_ids_iter: Box> = match &struct_item.kind { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 249 | Box::new(field_ids_iter.map(move |field_id| { [INFO] [stdout] | ______________________^ [INFO] [stdout] 250 | | origin.make_item_vertex(item_index.get(field_id).expect("missing item")) [INFO] [stdout] 251 | | })) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/adapter/optimizations/impl_lookup.rs:86:17 [INFO] [stdout] | [INFO] [stdout] 79 | } else if let Some(candidate) = method_vertex_info.statically_required_property("name") { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | candidate.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/adapter/optimizations/item_lookup.rs:42:72 [INFO] [stdout] | [INFO] [stdout] 38 | } else if let Some(path_value) = neighbor_info.statically_required_property("path") { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | resolve_items_by_importable_path(crate_vertex, origin, path_value.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/adapter/optimizations/item_lookup.rs:125:9 [INFO] [stdout] | [INFO] [stdout] 122 | items: impl Iterator + 'a, [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 125 | / items [INFO] [stdout] 126 | | .filter(|value| crate::adapter::supported_item_kind(value)) [INFO] [stdout] 127 | | .map(move |value| origin.make_item_vertex(value)), [INFO] [stdout] | |_____________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/adapter/optimizations/method_lookup.rs:44:17 [INFO] [stdout] | [INFO] [stdout] 38 | } else if let Some(candidate) = neighbor_info.statically_required_property("name") { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | candidate.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/adapter/optimizations/method_lookup.rs:200:9 [INFO] [stdout] | [INFO] [stdout] 165 | let provided_methods: Box> = [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 200 | / provided_methods [INFO] [stdout] 201 | | .chain(impl_vertex.items.iter()) [INFO] [stdout] 202 | | .filter_map(move |item_id| { [INFO] [stdout] 203 | | let next_item = &item_index.get(item_id); [INFO] [stdout] ... | [INFO] [stdout] 213 | | } [INFO] [stdout] 214 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `trustfall-rustdoc-adapter` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/adapter/edges.rs:249:22 [INFO] [stdout] | [INFO] [stdout] 241 | let field_ids_iter: Box> = match &struct_item.kind { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 249 | Box::new(field_ids_iter.map(move |field_id| { [INFO] [stdout] | ______________________^ [INFO] [stdout] 250 | | origin.make_item_vertex(item_index.get(field_id).expect("missing item")) [INFO] [stdout] 251 | | })) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/adapter/optimizations/impl_lookup.rs:86:17 [INFO] [stdout] | [INFO] [stdout] 79 | } else if let Some(candidate) = method_vertex_info.statically_required_property("name") { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | candidate.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/adapter/optimizations/item_lookup.rs:42:72 [INFO] [stdout] | [INFO] [stdout] 38 | } else if let Some(path_value) = neighbor_info.statically_required_property("path") { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | resolve_items_by_importable_path(crate_vertex, origin, path_value.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/adapter/optimizations/item_lookup.rs:125:9 [INFO] [stdout] | [INFO] [stdout] 122 | items: impl Iterator + 'a, [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 125 | / items [INFO] [stdout] 126 | | .filter(|value| crate::adapter::supported_item_kind(value)) [INFO] [stdout] 127 | | .map(move |value| origin.make_item_vertex(value)), [INFO] [stdout] | |_____________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/adapter/optimizations/method_lookup.rs:44:17 [INFO] [stdout] | [INFO] [stdout] 38 | } else if let Some(candidate) = neighbor_info.statically_required_property("name") { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | candidate.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/adapter/optimizations/method_lookup.rs:200:9 [INFO] [stdout] | [INFO] [stdout] 165 | let provided_methods: Box> = [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 200 | / provided_methods [INFO] [stdout] 201 | | .chain(impl_vertex.items.iter()) [INFO] [stdout] 202 | | .filter_map(move |item_id| { [INFO] [stdout] 203 | | let next_item = &item_index.get(item_id); [INFO] [stdout] ... | [INFO] [stdout] 213 | | } [INFO] [stdout] 214 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `trustfall-rustdoc-adapter` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "6378a7794a78cfe769627302c0d4ea75e5e0c018e515bfb309b5cd0d14a10e68", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6378a7794a78cfe769627302c0d4ea75e5e0c018e515bfb309b5cd0d14a10e68", kill_on_drop: false }` [INFO] [stdout] 6378a7794a78cfe769627302c0d4ea75e5e0c018e515bfb309b5cd0d14a10e68