[INFO] fetching crate trillium-opentelemetry 0.9.0... [INFO] checking trillium-opentelemetry-0.9.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate trillium-opentelemetry 0.9.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate trillium-opentelemetry 0.9.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate trillium-opentelemetry 0.9.0 [INFO] finished tweaking crates.io crate trillium-opentelemetry 0.9.0 [INFO] tweaked toml for crates.io crate trillium-opentelemetry 0.9.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate trillium-opentelemetry 0.9.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 78a7717a29679b875facde831878330127a786e53e79fd9e3a00aafcb5058fb0 [INFO] running `Command { std: "docker" "start" "-a" "78a7717a29679b875facde831878330127a786e53e79fd9e3a00aafcb5058fb0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "78a7717a29679b875facde831878330127a786e53e79fd9e3a00aafcb5058fb0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "78a7717a29679b875facde831878330127a786e53e79fd9e3a00aafcb5058fb0", kill_on_drop: false }` [INFO] [stdout] 78a7717a29679b875facde831878330127a786e53e79fd9e3a00aafcb5058fb0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 524d188b8aa66e9774b975b061f09e6dc682648d594a08b2ab0850fd1a601fda [INFO] running `Command { std: "docker" "start" "-a" "524d188b8aa66e9774b975b061f09e6dc682648d594a08b2ab0850fd1a601fda", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking bytes v1.6.1 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking ahash v0.8.11 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling thiserror v1.0.62 [INFO] [stderr] Compiling rustversion v1.0.17 [INFO] [stderr] Compiling syn v2.0.71 [INFO] [stderr] Compiling smartstring v1.0.1 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking parking v2.2.0 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking fastrand v2.1.0 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Checking tower-layer v0.3.2 [INFO] [stderr] Compiling serde v1.0.204 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking futures-lite v2.3.0 [INFO] [stderr] Checking event-listener v5.3.1 [INFO] [stderr] Checking smartcow v0.2.1 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Compiling axum-core v0.4.3 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Compiling either v1.13.0 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling itertools v0.13.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling axum v0.7.5 [INFO] [stderr] Checking stopper v0.2.8 [INFO] [stderr] Compiling serde_json v1.0.120 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking sync_wrapper v0.1.2 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking sync_wrapper v1.0.1 [INFO] [stderr] Compiling rlimit v0.10.1 [INFO] [stderr] Checking matchit v0.7.3 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking glob v0.3.1 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking signal-hook v0.3.17 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking event-listener v4.0.3 [INFO] [stderr] Checking async_cell v0.2.2 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Checking anstyle-query v1.1.0 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Checking routefinder v0.5.4 [INFO] [stderr] Checking opentelemetry-semantic-conventions v0.16.0 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Checking regex v1.10.5 [INFO] [stderr] Compiling tokio-macros v2.3.0 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Compiling thiserror-impl v1.0.62 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling trillium-macros v0.0.6 [INFO] [stderr] Compiling async-stream-impl v0.3.5 [INFO] [stderr] Compiling prost-derive v0.13.1 [INFO] [stderr] Checking tokio v1.38.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking async-stream v0.3.5 [INFO] [stderr] Checking env_filter v0.1.0 [INFO] [stderr] Compiling trillium-macros v0.0.5 [INFO] [stderr] Checking env_logger v0.11.3 [INFO] [stderr] Checking trillium-http v0.3.17 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking opentelemetry v0.24.0 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking prost v0.13.1 [INFO] [stderr] Checking trillium v0.2.20 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking trillium-server-common v0.5.2 [INFO] [stderr] Checking trillium-router v0.4.1 [INFO] [stderr] Checking trillium-opentelemetry v0.9.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated method `trillium::Conn::set_state`: use Conn::insert_state [INFO] [stdout] --> src/trace.rs:207:18 [INFO] [stdout] | [INFO] [stdout] 207 | conn.set_state(RouteWasAvailable); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/instrument.rs:31:14 [INFO] [stdout] | [INFO] [stdout] 28 | meter: impl Into, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | tracer: impl ObjectSafeTracer + Send + Sync + 'static, [INFO] [stdout] | ----------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | ) -> Self { [INFO] [stdout] 31 | Self((Trace::new(BoxedTracer::new(Box::new(tracer))), meter.into())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metrics.rs:164:45 [INFO] [stdout] | [INFO] [stdout] 164 | async fn run(&self, conn: Conn) -> Conn { [INFO] [stdout] | _________________________----------__________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 165 | | conn.with_state(MetricsWasRun) [INFO] [stdout] 166 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metrics.rs:168:57 [INFO] [stdout] | [INFO] [stdout] 168 | async fn before_send(&self, mut conn: Conn) -> Conn { [INFO] [stdout] | _____________________________________----------__________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 169 | | if conn.state::().is_none() { [INFO] [stdout] 170 | | return conn; [INFO] [stdout] 171 | | } [INFO] [stdout] ... | [INFO] [stdout] 245 | | conn [INFO] [stdout] 246 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trace.rs:60:20 [INFO] [stdout] | [INFO] [stdout] 58 | pub fn new(tracer: T) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | Trace { [INFO] [stdout] 60 | route: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trace.rs:61:25 [INFO] [stdout] | [INFO] [stdout] 58 | pub fn new(tracer: T) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | error_type: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trace.rs:136:49 [INFO] [stdout] | [INFO] [stdout] 136 | async fn run(&self, mut conn: Conn) -> Conn { [INFO] [stdout] | _____________________________----------__________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 137 | | let start_time = [INFO] [stdout] 138 | | Some(SystemTime::now() - conn.inner().start_time().duration_since(Instant::now())); [INFO] [stdout] ... | [INFO] [stdout] 223 | | conn.with_state(TraceContext { context }) [INFO] [stdout] 224 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trace.rs:226:57 [INFO] [stdout] | [INFO] [stdout] 226 | async fn before_send(&self, mut conn: Conn) -> Conn { [INFO] [stdout] | _____________________________________----------__________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 227 | | let Some(TraceContext { context }) = conn.state().cloned() else { [INFO] [stdout] 228 | | return conn; [INFO] [stdout] 229 | | }; [INFO] [stdout] ... | [INFO] [stdout] 284 | | conn [INFO] [stdout] 285 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/instrument_handler.rs:36:49 [INFO] [stdout] | [INFO] [stdout] 36 | async fn run(&self, mut conn: Conn) -> Conn { [INFO] [stdout] | _____________________________----------__________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | | let name = self.handler.name(); [INFO] [stdout] 38 | | match conn.take_state() { [INFO] [stdout] 39 | | Some(TraceContext { context }) => { [INFO] [stdout] ... | [INFO] [stdout] 54 | | } [INFO] [stdout] 55 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/instrument_handler.rs:57:57 [INFO] [stdout] | [INFO] [stdout] 57 | async fn before_send(&self, mut conn: Conn) -> Conn { [INFO] [stdout] | _____________________________________----------__________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | | let name = self.handler.name(); [INFO] [stdout] 59 | | match conn.take_state() { [INFO] [stdout] 60 | | Some(TraceContext { context }) => { [INFO] [stdout] ... | [INFO] [stdout] 76 | | } [INFO] [stdout] 77 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/instrument_handler.rs:83:47 [INFO] [stdout] | [INFO] [stdout] 83 | async fn upgrade(&self, upgrade: Upgrade) { [INFO] [stdout] | _____________________________----------------__^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 84 | | let name = self.handler.name(); [INFO] [stdout] 85 | | match upgrade.state().get() { [INFO] [stdout] 86 | | Some(TraceContext { context }) => { [INFO] [stdout] ... | [INFO] [stdout] 98 | | } [INFO] [stdout] 99 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/instrument_handler.rs:142:9 [INFO] [stdout] | [INFO] [stdout] 136 | pub fn instrument_handler_global(handler: H) -> InstrumentHandler [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 142 | opentelemetry::global::tracer("trillium-opentelemetry"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 11 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `trillium-opentelemetry` (lib) due to 12 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "524d188b8aa66e9774b975b061f09e6dc682648d594a08b2ab0850fd1a601fda", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "524d188b8aa66e9774b975b061f09e6dc682648d594a08b2ab0850fd1a601fda", kill_on_drop: false }` [INFO] [stdout] 524d188b8aa66e9774b975b061f09e6dc682648d594a08b2ab0850fd1a601fda