[INFO] fetching crate triemap 0.1.0... [INFO] checking triemap-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate triemap 0.1.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate triemap 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate triemap 0.1.0 [INFO] finished tweaking crates.io crate triemap 0.1.0 [INFO] tweaked toml for crates.io crate triemap 0.1.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 8 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7397b63eb4acd08450285dfd9711c186fb5d468758cdd8bed7afde6058a3cafc [INFO] running `Command { std: "docker" "start" "-a" "7397b63eb4acd08450285dfd9711c186fb5d468758cdd8bed7afde6058a3cafc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7397b63eb4acd08450285dfd9711c186fb5d468758cdd8bed7afde6058a3cafc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7397b63eb4acd08450285dfd9711c186fb5d468758cdd8bed7afde6058a3cafc", kill_on_drop: false }` [INFO] [stdout] 7397b63eb4acd08450285dfd9711c186fb5d468758cdd8bed7afde6058a3cafc [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 86f773d01d2a32425816e13fdff291c6ccd9cd22fefcd669f9564e40dc8e13bf [INFO] running `Command { std: "docker" "start" "-a" "86f773d01d2a32425816e13fdff291c6ccd9cd22fefcd669f9564e40dc8e13bf", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Checking unicode-ident v1.0.12 [INFO] [stderr] Checking heck v0.5.0 [INFO] [stderr] Compiling slotmap v1.0.7 [INFO] [stderr] Checking quote v1.0.37 [INFO] [stderr] Checking syn v2.0.77 [INFO] [stderr] Checking triemap v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:109:33 [INFO] [stdout] | [INFO] [stdout] 109 | result.unwrap_or_else(|err| err.to_compile_error().into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trie_map.rs:31:8 [INFO] [stdout] | [INFO] [stdout] 12 | pub fn trie_map_impl(args: TrieMapArgs, key: DeriveInput) -> Result { [INFO] [stdout] | ----------------- ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | let inner_name = format_ident!("Many_{}", wrapper_name); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | [INFO] [stdout] 26 | let key_variants = get_key_variants(&key, &args.type_map)?; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | [INFO] [stdout] 28 | let wrapper = generate_wrapper(&args.map_trait_name, key_name, wrapper_name, &inner_name); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | let inner = generate_inner(&args.map_trait_name, key_name, &key_variants, &inner_name); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | [INFO] [stdout] 31 | Ok(quote! { [INFO] [stdout] | ________^ [INFO] [stdout] 32 | | #key [INFO] [stdout] 33 | | [INFO] [stdout] 34 | | #wrapper [INFO] [stdout] ... | [INFO] [stdout] 37 | | } [INFO] [stdout] 38 | | .into()) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trie_map.rs:123:12 [INFO] [stdout] | [INFO] [stdout] 108 | let map_trait_name = input.parse::()?; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | let _ = input.parse::()?; [INFO] [stdout] 110 | let entries = Punctuated::::parse_terminated(input)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 111 | let type_map = entries [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 123 | Ok(TrieMapArgs { [INFO] [stdout] | ____________^ [INFO] [stdout] 124 | | map_trait_name, [INFO] [stdout] 125 | | type_map, [INFO] [stdout] 126 | | span: input.span(), [INFO] [stdout] 127 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trie_map.rs:116:21 [INFO] [stdout] | [INFO] [stdout] 113 | .map(|arg| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | / TypeMapEntry { [INFO] [stdout] 117 | | name: arg.value, [INFO] [stdout] 118 | | is_indirect: arg.is_indirect, [INFO] [stdout] 119 | | }, [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trie_map.rs:143:12 [INFO] [stdout] | [INFO] [stdout] 139 | let key = input.parse::()?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 142 | let value = input.parse::()?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 143 | Ok(TypeMapArg { [INFO] [stdout] | ____________^ [INFO] [stdout] 144 | | key, [INFO] [stdout] 145 | | value, [INFO] [stdout] 146 | | is_indirect, [INFO] [stdout] 147 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:109:33 [INFO] [stdout] | [INFO] [stdout] 109 | result.unwrap_or_else(|err| err.to_compile_error().into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `triemap` (lib) due to 6 previous errors [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trie_map.rs:31:8 [INFO] [stdout] | [INFO] [stdout] 12 | pub fn trie_map_impl(args: TrieMapArgs, key: DeriveInput) -> Result { [INFO] [stdout] | ----------------- ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | let inner_name = format_ident!("Many_{}", wrapper_name); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | [INFO] [stdout] 26 | let key_variants = get_key_variants(&key, &args.type_map)?; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | [INFO] [stdout] 28 | let wrapper = generate_wrapper(&args.map_trait_name, key_name, wrapper_name, &inner_name); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | let inner = generate_inner(&args.map_trait_name, key_name, &key_variants, &inner_name); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | [INFO] [stdout] 31 | Ok(quote! { [INFO] [stdout] | ________^ [INFO] [stdout] 32 | | #key [INFO] [stdout] 33 | | [INFO] [stdout] 34 | | #wrapper [INFO] [stdout] ... | [INFO] [stdout] 37 | | } [INFO] [stdout] 38 | | .into()) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trie_map.rs:123:12 [INFO] [stdout] | [INFO] [stdout] 108 | let map_trait_name = input.parse::()?; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | let _ = input.parse::()?; [INFO] [stdout] 110 | let entries = Punctuated::::parse_terminated(input)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 111 | let type_map = entries [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 123 | Ok(TrieMapArgs { [INFO] [stdout] | ____________^ [INFO] [stdout] 124 | | map_trait_name, [INFO] [stdout] 125 | | type_map, [INFO] [stdout] 126 | | span: input.span(), [INFO] [stdout] 127 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trie_map.rs:116:21 [INFO] [stdout] | [INFO] [stdout] 113 | .map(|arg| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | / TypeMapEntry { [INFO] [stdout] 117 | | name: arg.value, [INFO] [stdout] 118 | | is_indirect: arg.is_indirect, [INFO] [stdout] 119 | | }, [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trie_map.rs:143:12 [INFO] [stdout] | [INFO] [stdout] 139 | let key = input.parse::()?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 142 | let value = input.parse::()?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 143 | Ok(TypeMapArg { [INFO] [stdout] | ____________^ [INFO] [stdout] 144 | | key, [INFO] [stdout] 145 | | value, [INFO] [stdout] 146 | | is_indirect, [INFO] [stdout] 147 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `triemap` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "86f773d01d2a32425816e13fdff291c6ccd9cd22fefcd669f9564e40dc8e13bf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "86f773d01d2a32425816e13fdff291c6ccd9cd22fefcd669f9564e40dc8e13bf", kill_on_drop: false }` [INFO] [stdout] 86f773d01d2a32425816e13fdff291c6ccd9cd22fefcd669f9564e40dc8e13bf