[INFO] fetching crate treestate 0.1.1... [INFO] checking treestate-0.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate treestate 0.1.1 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate treestate 0.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate treestate 0.1.1 [INFO] finished tweaking crates.io crate treestate 0.1.1 [INFO] tweaked toml for crates.io crate treestate 0.1.1 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 19 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ca0c85b089bda643e3c3f96930c00f3de70bee65bbc6762696763a72fd20c620 [INFO] running `Command { std: "docker" "start" "-a" "ca0c85b089bda643e3c3f96930c00f3de70bee65bbc6762696763a72fd20c620", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ca0c85b089bda643e3c3f96930c00f3de70bee65bbc6762696763a72fd20c620", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ca0c85b089bda643e3c3f96930c00f3de70bee65bbc6762696763a72fd20c620", kill_on_drop: false }` [INFO] [stdout] ca0c85b089bda643e3c3f96930c00f3de70bee65bbc6762696763a72fd20c620 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8ed06923d5c859def1ae68e8c03df97a9e858b6c3127785f991e4b3a1a6e7f81 [INFO] running `Command { std: "docker" "start" "-a" "8ed06923d5c859def1ae68e8c03df97a9e858b6c3127785f991e4b3a1a6e7f81", kill_on_drop: false }` [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking utime v0.3.1 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking treestate v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:23:27 [INFO] [stdout] | [INFO] [stdout] 23 | modified: attr.modified().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:52:20 [INFO] [stdout] | [INFO] [stdout] 47 | pub fn new(items: I) -> TreeState [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | state: items [INFO] [stdout] | ____________________^ [INFO] [stdout] 53 | | .into_iter() [INFO] [stdout] 54 | | .filter_map(|item| T::from(item).map(|state| (item.clone(), state))) [INFO] [stdout] 55 | | .collect::>(), [INFO] [stdout] | |___________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:54:36 [INFO] [stdout] | [INFO] [stdout] 54 | .filter_map(|item| T::from(item).map(|state| (item.clone(), state))) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:54:63 [INFO] [stdout] | [INFO] [stdout] 54 | .filter_map(|item| T::from(item).map(|state| (item.clone(), state))) [INFO] [stdout] | ----- ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:62:39 [INFO] [stdout] | [INFO] [stdout] 62 | .find_any(|(item, state)| T::from(item).map_or(true, |x| x != **state)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `treestate` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:23:27 [INFO] [stdout] | [INFO] [stdout] 23 | modified: attr.modified().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:52:20 [INFO] [stdout] | [INFO] [stdout] 47 | pub fn new(items: I) -> TreeState [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | state: items [INFO] [stdout] | ____________________^ [INFO] [stdout] 53 | | .into_iter() [INFO] [stdout] 54 | | .filter_map(|item| T::from(item).map(|state| (item.clone(), state))) [INFO] [stdout] 55 | | .collect::>(), [INFO] [stdout] | |___________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:54:36 [INFO] [stdout] | [INFO] [stdout] 54 | .filter_map(|item| T::from(item).map(|state| (item.clone(), state))) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:54:63 [INFO] [stdout] | [INFO] [stdout] 54 | .filter_map(|item| T::from(item).map(|state| (item.clone(), state))) [INFO] [stdout] | ----- ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:62:39 [INFO] [stdout] | [INFO] [stdout] 62 | .find_any(|(item, state)| T::from(item).map_or(true, |x| x != **state)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `treestate` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "8ed06923d5c859def1ae68e8c03df97a9e858b6c3127785f991e4b3a1a6e7f81", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8ed06923d5c859def1ae68e8c03df97a9e858b6c3127785f991e4b3a1a6e7f81", kill_on_drop: false }` [INFO] [stdout] 8ed06923d5c859def1ae68e8c03df97a9e858b6c3127785f991e4b3a1a6e7f81