[INFO] fetching crate treeflection 0.1.35... [INFO] checking treeflection-0.1.35 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate treeflection 0.1.35 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate treeflection 0.1.35 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate treeflection 0.1.35 [INFO] finished tweaking crates.io crate treeflection 0.1.35 [INFO] tweaked toml for crates.io crate treeflection 0.1.35 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 14 packages to latest compatible versions [INFO] [stderr] Adding itertools v0.9.0 (latest: v0.13.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] edc8ce23992e4b818ad42ed54fcd5eb02cdd035a360af9cc9ffb737d688e4b69 [INFO] running `Command { std: "docker" "start" "-a" "edc8ce23992e4b818ad42ed54fcd5eb02cdd035a360af9cc9ffb737d688e4b69", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "edc8ce23992e4b818ad42ed54fcd5eb02cdd035a360af9cc9ffb737d688e4b69", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "edc8ce23992e4b818ad42ed54fcd5eb02cdd035a360af9cc9ffb737d688e4b69", kill_on_drop: false }` [INFO] [stdout] edc8ce23992e4b818ad42ed54fcd5eb02cdd035a360af9cc9ffb737d688e4b69 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 35fcfe73bd5df9427be109f310c0a77a941c608ada8841755d03e34506e569c7 [INFO] running `Command { std: "docker" "start" "-a" "35fcfe73bd5df9427be109f310c0a77a941c608ada8841755d03e34506e569c7", kill_on_drop: false }` [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking itertools v0.9.0 [INFO] [stderr] Checking treeflection v0.1.35 (/opt/rustwide/workdir) [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/context_vec.rs:105:20 [INFO] [stdout] | [INFO] [stdout] 105 | panic!(format!("Attempted to set context {} on a ContextVec of length {}", value, length)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 105 - panic!(format!("Attempted to set context {} on a ContextVec of length {}", value, length)); [INFO] [stdout] 105 + panic!("Attempted to set context {} on a ContextVec of length {}", value, length); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/context_vec.rs:117:24 [INFO] [stdout] | [INFO] [stdout] 117 | panic!(format!("Attempted to set context {} on a ContextVec of length {}", value, length)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 117 - panic!(format!("Attempted to set context {} on a ContextVec of length {}", value, length)); [INFO] [stdout] 117 + panic!("Attempted to set context {} on a ContextVec of length {}", value, length); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/context_vec.rs:322:12 [INFO] [stdout] | [INFO] [stdout] 321 | fn deserialize(deserializer: D) -> Result where D: Deserializer<'de> { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 322 | Ok(ContextVec { [INFO] [stdout] | ____________^ [INFO] [stdout] 323 | | context: vec!(), [INFO] [stdout] 324 | | vector: Vec::::deserialize(deserializer)?, [INFO] [stdout] 325 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/keyed_context_vec.rs:125:20 [INFO] [stdout] | [INFO] [stdout] 125 | panic!(format!("Attempted to set context {} on a KeyedContextVec of length {}", value, length)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 125 - panic!(format!("Attempted to set context {} on a KeyedContextVec of length {}", value, length)); [INFO] [stdout] 125 + panic!("Attempted to set context {} on a KeyedContextVec of length {}", value, length); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/keyed_context_vec.rs:137:24 [INFO] [stdout] | [INFO] [stdout] 137 | panic!(format!("Attempted to set context {} on a KeyedContextVec of length {}", value, length)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 137 - panic!(format!("Attempted to set context {} on a KeyedContextVec of length {}", value, length)); [INFO] [stdout] 137 + panic!("Attempted to set context {} on a KeyedContextVec of length {}", value, length); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `treeflection` (lib test) due to 2 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/context_vec.rs:105:20 [INFO] [stdout] | [INFO] [stdout] 105 | panic!(format!("Attempted to set context {} on a ContextVec of length {}", value, length)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 105 - panic!(format!("Attempted to set context {} on a ContextVec of length {}", value, length)); [INFO] [stdout] 105 + panic!("Attempted to set context {} on a ContextVec of length {}", value, length); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/context_vec.rs:117:24 [INFO] [stdout] | [INFO] [stdout] 117 | panic!(format!("Attempted to set context {} on a ContextVec of length {}", value, length)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 117 - panic!(format!("Attempted to set context {} on a ContextVec of length {}", value, length)); [INFO] [stdout] 117 + panic!("Attempted to set context {} on a ContextVec of length {}", value, length); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/context_vec.rs:322:12 [INFO] [stdout] | [INFO] [stdout] 321 | fn deserialize(deserializer: D) -> Result where D: Deserializer<'de> { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 322 | Ok(ContextVec { [INFO] [stdout] | ____________^ [INFO] [stdout] 323 | | context: vec!(), [INFO] [stdout] 324 | | vector: Vec::::deserialize(deserializer)?, [INFO] [stdout] 325 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/keyed_context_vec.rs:125:20 [INFO] [stdout] | [INFO] [stdout] 125 | panic!(format!("Attempted to set context {} on a KeyedContextVec of length {}", value, length)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 125 - panic!(format!("Attempted to set context {} on a KeyedContextVec of length {}", value, length)); [INFO] [stdout] 125 + panic!("Attempted to set context {} on a KeyedContextVec of length {}", value, length); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/keyed_context_vec.rs:137:24 [INFO] [stdout] | [INFO] [stdout] 137 | panic!(format!("Attempted to set context {} on a KeyedContextVec of length {}", value, length)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 137 - panic!(format!("Attempted to set context {} on a KeyedContextVec of length {}", value, length)); [INFO] [stdout] 137 + panic!("Attempted to set context {} on a KeyedContextVec of length {}", value, length); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `treeflection` (lib) due to 2 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "35fcfe73bd5df9427be109f310c0a77a941c608ada8841755d03e34506e569c7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "35fcfe73bd5df9427be109f310c0a77a941c608ada8841755d03e34506e569c7", kill_on_drop: false }` [INFO] [stdout] 35fcfe73bd5df9427be109f310c0a77a941c608ada8841755d03e34506e569c7