[INFO] fetching crate treebender 0.1.1... [INFO] checking treebender-0.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate treebender 0.1.1 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate treebender 0.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate treebender 0.1.1 [INFO] finished tweaking crates.io crate treebender 0.1.1 [INFO] tweaked toml for crates.io crate treebender 0.1.1 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate treebender 0.1.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e2c410b1c0a45492bb9a25dee2973ed595c71599925e6e7b25fea1020911a4b3 [INFO] running `Command { std: "docker" "start" "-a" "e2c410b1c0a45492bb9a25dee2973ed595c71599925e6e7b25fea1020911a4b3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e2c410b1c0a45492bb9a25dee2973ed595c71599925e6e7b25fea1020911a4b3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e2c410b1c0a45492bb9a25dee2973ed595c71599925e6e7b25fea1020911a4b3", kill_on_drop: false }` [INFO] [stdout] e2c410b1c0a45492bb9a25dee2973ed595c71599925e6e7b25fea1020911a4b3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e6307ca5a74533e5cd755f9fb0543004973fd88821138c6116ff1256dcf0f47a [INFO] running `Command { std: "docker" "start" "-a" "e6307ca5a74533e5cd755f9fb0543004973fd88821138c6116ff1256dcf0f47a", kill_on_drop: false }` [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking regex-syntax v0.6.17 [INFO] [stderr] Checking thread_local v1.0.1 [INFO] [stderr] Checking aho-corasick v0.7.10 [INFO] [stderr] Checking regex v1.3.7 [INFO] [stderr] Checking treebender v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:587:23 [INFO] [stdout] | [INFO] [stdout] 587 | .filter_map(|t| Self::unify_tree(t).map(Some).unwrap_or(None)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rules.rs:134:8 [INFO] [stdout] | [INFO] [stdout] 112 | let nonterminals: HashSet = rules.iter().map(|r| r.symbol.clone()).collect(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 132 | let nullables = Self::find_nullables(&rules); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 133 | [INFO] [stdout] 134 | Ok(Self { [INFO] [stdout] | ________^ [INFO] [stdout] 135 | | start, [INFO] [stdout] 136 | | rules, [INFO] [stdout] 137 | | nonterminals, [INFO] [stdout] 138 | | nullables, [INFO] [stdout] 139 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:42:25 [INFO] [stdout] | [INFO] [stdout] 40 | .map(|subseq| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | // prepend every element of the head to every possible subseq [INFO] [stdout] 42 | head.iter().map(move |v| { [INFO] [stdout] | _________________________^ [INFO] [stdout] 43 | | let mut newseq = subseq.clone(); [INFO] [stdout] 44 | | newseq.insert(0, v.clone()); [INFO] [stdout] 45 | | newseq [INFO] [stdout] 46 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `treebender` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:587:23 [INFO] [stdout] | [INFO] [stdout] 587 | .filter_map(|t| Self::unify_tree(t).map(Some).unwrap_or(None)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rules.rs:134:8 [INFO] [stdout] | [INFO] [stdout] 112 | let nonterminals: HashSet = rules.iter().map(|r| r.symbol.clone()).collect(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 132 | let nullables = Self::find_nullables(&rules); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 133 | [INFO] [stdout] 134 | Ok(Self { [INFO] [stdout] | ________^ [INFO] [stdout] 135 | | start, [INFO] [stdout] 136 | | rules, [INFO] [stdout] 137 | | nonterminals, [INFO] [stdout] 138 | | nullables, [INFO] [stdout] 139 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:42:25 [INFO] [stdout] | [INFO] [stdout] 40 | .map(|subseq| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | // prepend every element of the head to every possible subseq [INFO] [stdout] 42 | head.iter().map(move |v| { [INFO] [stdout] | _________________________^ [INFO] [stdout] 43 | | let mut newseq = subseq.clone(); [INFO] [stdout] 44 | | newseq.insert(0, v.clone()); [INFO] [stdout] 45 | | newseq [INFO] [stdout] 46 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `treebender` (lib test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "e6307ca5a74533e5cd755f9fb0543004973fd88821138c6116ff1256dcf0f47a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e6307ca5a74533e5cd755f9fb0543004973fd88821138c6116ff1256dcf0f47a", kill_on_drop: false }` [INFO] [stdout] e6307ca5a74533e5cd755f9fb0543004973fd88821138c6116ff1256dcf0f47a