[INFO] fetching crate tree_collections 0.1.8... [INFO] checking tree_collections-0.1.8 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate tree_collections 0.1.8 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate tree_collections 0.1.8 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tree_collections 0.1.8 [INFO] finished tweaking crates.io crate tree_collections 0.1.8 [INFO] tweaked toml for crates.io crate tree_collections 0.1.8 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate tree_collections 0.1.8 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b34b2f7b94c6ced664223d909196d4da5e05576a4d8531b8035043548b586471 [INFO] running `Command { std: "docker" "start" "-a" "b34b2f7b94c6ced664223d909196d4da5e05576a4d8531b8035043548b586471", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b34b2f7b94c6ced664223d909196d4da5e05576a4d8531b8035043548b586471", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b34b2f7b94c6ced664223d909196d4da5e05576a4d8531b8035043548b586471", kill_on_drop: false }` [INFO] [stdout] b34b2f7b94c6ced664223d909196d4da5e05576a4d8531b8035043548b586471 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 146f4d8930c2a3ae73830f8963db87aa5b5e6a4e29edc18b3159e3121dad482f [INFO] running `Command { std: "docker" "start" "-a" "146f4d8930c2a3ae73830f8963db87aa5b5e6a4e29edc18b3159e3121dad482f", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.109 [INFO] [stderr] Compiling serde v1.0.131 [INFO] [stderr] Compiling semver v1.0.4 [INFO] [stderr] Compiling crossbeam-utils v0.8.5 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling ryu v1.0.6 [INFO] [stderr] Compiling proc-macro2 v1.0.33 [INFO] [stderr] Compiling crossbeam-epoch v0.9.5 [INFO] [stderr] Compiling getrandom v0.1.16 [INFO] [stderr] Compiling rayon-core v1.9.1 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling syn v1.0.82 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Compiling serde_json v1.0.72 [INFO] [stderr] Checking crossbeam-deque v0.8.1 [INFO] [stderr] Compiling cast v0.2.7 [INFO] [stderr] Compiling quote v1.0.10 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking crossbeam-channel v0.5.1 [INFO] [stderr] Compiling rayon v1.5.1 [INFO] [stderr] Checking plotters-backend v0.3.2 [INFO] [stderr] Compiling serde_derive v1.0.131 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking plotters-svg v0.3.1 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Checking itertools v0.10.3 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Checking ppv-lite86 v0.2.15 [INFO] [stderr] Checking half v1.8.2 [INFO] [stderr] Checking walkdir v2.3.2 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking plotters v0.3.1 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking regex v1.5.4 [INFO] [stderr] Checking criterion-plot v0.4.4 [INFO] [stderr] Checking bstr v0.2.17 [INFO] [stderr] Checking serde_cbor v0.11.2 [INFO] [stderr] Checking csv v1.1.6 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking criterion v0.3.5 [INFO] [stderr] Checking tree_collections v0.1.8 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/avlTree.rs:222:18 [INFO] [stdout] | [INFO] [stdout] 222 | Some(mut n) => { [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `j` is never read [INFO] [stdout] --> src/commonTrait.rs:344:25 [INFO] [stdout] | [INFO] [stdout] 344 | j += 2; [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `j` is never read [INFO] [stdout] --> src/commonTrait.rs:346:25 [INFO] [stdout] | [INFO] [stdout] 346 | j += container[i][j].len() - 1; [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/avlTree.rs:222:18 [INFO] [stdout] | [INFO] [stdout] 222 | Some(mut n) => { [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `j` is never read [INFO] [stdout] --> src/commonTrait.rs:344:25 [INFO] [stdout] | [INFO] [stdout] 344 | j += 2; [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `j` is never read [INFO] [stdout] --> src/commonTrait.rs:346:25 [INFO] [stdout] | [INFO] [stdout] 346 | j += container[i][j].len() - 1; [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `is_balanced` is never used [INFO] [stdout] --> src/avlTree.rs:326:8 [INFO] [stdout] | [INFO] [stdout] 68 | impl AVLTree { [INFO] [stdout] | ------------------------------------------------ method in this implementation [INFO] [stdout] ... [INFO] [stdout] 326 | fn is_balanced(&self, node: OptionAVLTreeNode) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated functions `new_black_with_parent`, `reverse_color`, and `get_uncle` are never used [INFO] [stdout] --> src/rbTree.rs:231:8 [INFO] [stdout] | [INFO] [stdout] 206 | impl TreeNode { [INFO] [stdout] | ------------------------------------------------- associated functions in this implementation [INFO] [stdout] ... [INFO] [stdout] 231 | fn new_black_with_parent(value: T, parent: OptionRBTreeNode) -> Self { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 685 | fn reverse_color(node: RBTreeNode) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 703 | fn get_uncle(node: RBTreeNode) -> OptionRBTreeNode { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module `avlTree` should have a snake case name [INFO] [stdout] --> src/lib.rs:1:9 [INFO] [stdout] | [INFO] [stdout] 1 | pub mod avlTree; [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `avl_tree` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module `bsTree` should have a snake case name [INFO] [stdout] --> src/lib.rs:2:9 [INFO] [stdout] | [INFO] [stdout] 2 | pub mod bsTree; [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `bs_tree` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module `commonTrait` should have a snake case name [INFO] [stdout] --> src/lib.rs:3:9 [INFO] [stdout] | [INFO] [stdout] 3 | pub mod commonTrait; [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `common_trait` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module `rbTree` should have a snake case name [INFO] [stdout] --> src/lib.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 5 | pub mod rbTree; [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `rb_tree` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module `rbTreeFast` should have a snake case name [INFO] [stdout] --> src/lib.rs:6:9 [INFO] [stdout] | [INFO] [stdout] 6 | pub mod rbTreeFast; [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `rb_tree_fast` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/avlTree.rs:311:28 [INFO] [stdout] | [INFO] [stdout] 311 | node.map_or(0, |n| n.borrow().height) [INFO] [stdout] | - ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bounds on generic parameters in type aliases are not enforced [INFO] [stdout] --> src/rbTreeFast.rs:39:24 [INFO] [stdout] | [INFO] [stdout] 39 | type FastRBTreeNode = Rc>>; [INFO] [stdout] | --^^^---^^^^---^^^^^---^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | will not be checked at usage sites of the type alias [INFO] [stdout] | help: remove this bound [INFO] [stdout] | [INFO] [stdout] = note: this is a known limitation of the type checker that may be lifted in a future edition. [INFO] [stdout] see issue #112792 for more information [INFO] [stdout] = help: add `#![feature(lazy_type_alias)]` to the crate attributes to enable the desired semantics [INFO] [stdout] = note: `#[warn(type_alias_bounds)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bounds on generic parameters in type aliases are not enforced [INFO] [stdout] --> src/rbTreeFast.rs:40:30 [INFO] [stdout] | [INFO] [stdout] 40 | type OptionFastRBTreeNode = Option>; [INFO] [stdout] | --^^^---^^^^---^^^^^---^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | will not be checked at usage sites of the type alias [INFO] [stdout] | help: remove this bound [INFO] [stdout] | [INFO] [stdout] = note: this is a known limitation of the type checker that may be lifted in a future edition. [INFO] [stdout] see issue #112792 for more information [INFO] [stdout] = help: add `#![feature(lazy_type_alias)]` to the crate attributes to enable the desired semantics [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 12 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tree_collections` (lib) due to 2 previous errors; 12 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: associated functions `reverse_color` and `get_uncle` are never used [INFO] [stdout] --> src/rbTree.rs:685:8 [INFO] [stdout] | [INFO] [stdout] 206 | impl TreeNode { [INFO] [stdout] | ------------------------------------------------- associated functions in this implementation [INFO] [stdout] ... [INFO] [stdout] 685 | fn reverse_color(node: RBTreeNode) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 703 | fn get_uncle(node: RBTreeNode) -> OptionRBTreeNode { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module `avlTree` should have a snake case name [INFO] [stdout] --> src/lib.rs:1:9 [INFO] [stdout] | [INFO] [stdout] 1 | pub mod avlTree; [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `avl_tree` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module `bsTree` should have a snake case name [INFO] [stdout] --> src/lib.rs:2:9 [INFO] [stdout] | [INFO] [stdout] 2 | pub mod bsTree; [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `bs_tree` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module `commonTrait` should have a snake case name [INFO] [stdout] --> src/lib.rs:3:9 [INFO] [stdout] | [INFO] [stdout] 3 | pub mod commonTrait; [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `common_trait` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module `rbTree` should have a snake case name [INFO] [stdout] --> src/lib.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 5 | pub mod rbTree; [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `rb_tree` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module `rbTreeFast` should have a snake case name [INFO] [stdout] --> src/lib.rs:6:9 [INFO] [stdout] | [INFO] [stdout] 6 | pub mod rbTreeFast; [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `rb_tree_fast` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/avlTree.rs:311:28 [INFO] [stdout] | [INFO] [stdout] 311 | node.map_or(0, |n| n.borrow().height) [INFO] [stdout] | - ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bounds on generic parameters in type aliases are not enforced [INFO] [stdout] --> src/rbTreeFast.rs:39:24 [INFO] [stdout] | [INFO] [stdout] 39 | type FastRBTreeNode = Rc>>; [INFO] [stdout] | --^^^---^^^^---^^^^^---^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | will not be checked at usage sites of the type alias [INFO] [stdout] | help: remove this bound [INFO] [stdout] | [INFO] [stdout] = note: this is a known limitation of the type checker that may be lifted in a future edition. [INFO] [stdout] see issue #112792 for more information [INFO] [stdout] = help: add `#![feature(lazy_type_alias)]` to the crate attributes to enable the desired semantics [INFO] [stdout] = note: `#[warn(type_alias_bounds)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bounds on generic parameters in type aliases are not enforced [INFO] [stdout] --> src/rbTreeFast.rs:40:30 [INFO] [stdout] | [INFO] [stdout] 40 | type OptionFastRBTreeNode = Option>; [INFO] [stdout] | --^^^---^^^^---^^^^^---^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | will not be checked at usage sites of the type alias [INFO] [stdout] | help: remove this bound [INFO] [stdout] | [INFO] [stdout] = note: this is a known limitation of the type checker that may be lifted in a future edition. [INFO] [stdout] see issue #112792 for more information [INFO] [stdout] = help: add `#![feature(lazy_type_alias)]` to the crate attributes to enable the desired semantics [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tree_collections` (lib test) due to 2 previous errors; 11 warnings emitted [INFO] running `Command { std: "docker" "inspect" "146f4d8930c2a3ae73830f8963db87aa5b5e6a4e29edc18b3159e3121dad482f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "146f4d8930c2a3ae73830f8963db87aa5b5e6a4e29edc18b3159e3121dad482f", kill_on_drop: false }` [INFO] [stdout] 146f4d8930c2a3ae73830f8963db87aa5b5e6a4e29edc18b3159e3121dad482f