[INFO] fetching crate treasury-store 0.2.2... [INFO] checking treasury-store-0.2.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate treasury-store 0.2.2 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate treasury-store 0.2.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate treasury-store 0.2.2 [INFO] finished tweaking crates.io crate treasury-store 0.2.2 [INFO] tweaked toml for crates.io crate treasury-store 0.2.2 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 116 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding ahash v0.7.8 (latest: v0.8.11) [INFO] [stderr] Adding base64 v0.13.1 (latest: v0.22.1) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hashbrown v0.12.3 (latest: v0.14.5) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding libloading v0.7.4 (latest: v0.8.5) [INFO] [stderr] Adding matchers v0.1.0 (latest: v0.2.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding nu-ansi-term v0.46.0 (latest: v0.50.1) [INFO] [stderr] Adding regex-automata v0.1.10 (latest: v0.4.7) [INFO] [stderr] Adding regex-syntax v0.6.29 (latest: v0.8.4) [INFO] [stderr] Adding toml v0.5.11 (latest: v0.8.19) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5a304a2599705db01ac942947e2ace83c1146cf7aad7a54d89d34a20b391a4ce [INFO] running `Command { std: "docker" "start" "-a" "5a304a2599705db01ac942947e2ace83c1146cf7aad7a54d89d34a20b391a4ce", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5a304a2599705db01ac942947e2ace83c1146cf7aad7a54d89d34a20b391a4ce", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5a304a2599705db01ac942947e2ace83c1146cf7aad7a54d89d34a20b391a4ce", kill_on_drop: false }` [INFO] [stdout] 5a304a2599705db01ac942947e2ace83c1146cf7aad7a54d89d34a20b391a4ce [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5de54636fd44b4b811e16f5cb9f8561350e55625fbf74e7d1ca758f22c345088 [INFO] running `Command { std: "docker" "start" "-a" "5de54636fd44b4b811e16f5cb9f8561350e55625fbf74e7d1ca758f22c345088", kill_on_drop: false }` [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling ahash v0.7.8 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Compiling eyre v0.6.12 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Checking indenter v0.3.3 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking treasury-id v0.1.0 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking toml v0.5.11 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Checking envy v0.4.2 [INFO] [stderr] Checking serde_bytes v0.11.15 [INFO] [stderr] Checking libloading v0.7.4 [INFO] [stderr] Checking bytemuck v1.17.1 [INFO] [stderr] Checking dunce v1.0.5 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking treasury-import v0.2.0 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking tracing-error v0.2.0 [INFO] [stderr] Checking treasury-store v0.2.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:178:12 [INFO] [stdout] | [INFO] [stdout] 159 | let mut importers = Importers::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 178 | Ok(Treasury { [INFO] [stdout] | ____________^ [INFO] [stdout] 179 | | id_ctx, [INFO] [stdout] 180 | | base, [INFO] [stdout] 181 | | base_url, [INFO] [stdout] ... | [INFO] [stdout] 187 | | scanned: RwLock::new(false), [INFO] [stdout] 188 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/importer/mod.rs:217:60 [INFO] [stdout] | [INFO] [stdout] 217 | .map(|(format, target, importer)| (format, target, Importer::DylibImporter(importer)))) [INFO] [stdout] | -------------------------- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/importer/dylib.rs:123:8 [INFO] [stdout] | [INFO] [stdout] 68 | let lib = libloading::Library::new(lib_path)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | let lib = Arc::new(lib); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 121 | let lib_path: Arc = Arc::from(lib_path); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 122 | [INFO] [stdout] 123 | Ok(importers.into_iter().filter_map(move |importer| { [INFO] [stdout] | ________^ [INFO] [stdout] 124 | | let ffi: ImporterFFI = importer.assume_init(); [INFO] [stdout] 125 | | [INFO] [stdout] 126 | | let format = match ffi.format() { [INFO] [stdout] ... | [INFO] [stdout] 173 | | )) [INFO] [stdout] 174 | | })) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/importer/dylib.rs:165:14 [INFO] [stdout] | [INFO] [stdout] 98 | let lib = Arc::new(lib); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 121 | let lib_path: Arc = Arc::from(lib_path); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 165 | Some(( [INFO] [stdout] | ______________^ [INFO] [stdout] 166 | | format, [INFO] [stdout] 167 | | target, [INFO] [stdout] 168 | | DylibImporter { [INFO] [stdout] ... | [INFO] [stdout] 172 | | }, [INFO] [stdout] 173 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `treasury-store` (lib test) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:178:12 [INFO] [stdout] | [INFO] [stdout] 159 | let mut importers = Importers::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 178 | Ok(Treasury { [INFO] [stdout] | ____________^ [INFO] [stdout] 179 | | id_ctx, [INFO] [stdout] 180 | | base, [INFO] [stdout] 181 | | base_url, [INFO] [stdout] ... | [INFO] [stdout] 187 | | scanned: RwLock::new(false), [INFO] [stdout] 188 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/importer/mod.rs:217:60 [INFO] [stdout] | [INFO] [stdout] 217 | .map(|(format, target, importer)| (format, target, Importer::DylibImporter(importer)))) [INFO] [stdout] | -------------------------- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/importer/dylib.rs:123:8 [INFO] [stdout] | [INFO] [stdout] 68 | let lib = libloading::Library::new(lib_path)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | let lib = Arc::new(lib); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 121 | let lib_path: Arc = Arc::from(lib_path); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 122 | [INFO] [stdout] 123 | Ok(importers.into_iter().filter_map(move |importer| { [INFO] [stdout] | ________^ [INFO] [stdout] 124 | | let ffi: ImporterFFI = importer.assume_init(); [INFO] [stdout] 125 | | [INFO] [stdout] 126 | | let format = match ffi.format() { [INFO] [stdout] ... | [INFO] [stdout] 173 | | )) [INFO] [stdout] 174 | | })) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/importer/dylib.rs:165:14 [INFO] [stdout] | [INFO] [stdout] 98 | let lib = Arc::new(lib); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 121 | let lib_path: Arc = Arc::from(lib_path); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 165 | Some(( [INFO] [stdout] | ______________^ [INFO] [stdout] 166 | | format, [INFO] [stdout] 167 | | target, [INFO] [stdout] 168 | | DylibImporter { [INFO] [stdout] ... | [INFO] [stdout] 172 | | }, [INFO] [stdout] 173 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `treasury-store` (lib) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "5de54636fd44b4b811e16f5cb9f8561350e55625fbf74e7d1ca758f22c345088", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5de54636fd44b4b811e16f5cb9f8561350e55625fbf74e7d1ca758f22c345088", kill_on_drop: false }` [INFO] [stdout] 5de54636fd44b4b811e16f5cb9f8561350e55625fbf74e7d1ca758f22c345088