[INFO] fetching crate trash_lib 0.1.0... [INFO] checking trash_lib-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate trash_lib 0.1.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate trash_lib 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate trash_lib 0.1.0 [INFO] finished tweaking crates.io crate trash_lib 0.1.0 [INFO] tweaked toml for crates.io crate trash_lib 0.1.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 62 packages to latest compatible versions [INFO] [stderr] Adding directories v3.0.2 (latest: v5.0.1) [INFO] [stderr] Adding dirs-sys v0.3.7 (latest: v0.4.1) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding snafu v0.6.10 (latest: v0.8.4) [INFO] [stderr] Adding snafu-derive v0.6.10 (latest: v0.8.4) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 51fbda938e8a3f37815e7b43812e2b7327058199330b8e20a3818ee1bee5b090 [INFO] running `Command { std: "docker" "start" "-a" "51fbda938e8a3f37815e7b43812e2b7327058199330b8e20a3818ee1bee5b090", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "51fbda938e8a3f37815e7b43812e2b7327058199330b8e20a3818ee1bee5b090", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "51fbda938e8a3f37815e7b43812e2b7327058199330b8e20a3818ee1bee5b090", kill_on_drop: false }` [INFO] [stdout] 51fbda938e8a3f37815e7b43812e2b7327058199330b8e20a3818ee1bee5b090 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8341492137bbcd101deea6c46c124a3259edd70d8669f18fec199d04cd2ae8fc [INFO] running `Command { std: "docker" "start" "-a" "8341492137bbcd101deea6c46c124a3259edd70d8669f18fec199d04cd2ae8fc", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking fs_extra v1.3.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling snafu-derive v0.6.10 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking snafu v0.6.10 [INFO] [stderr] Checking dirs-sys v0.3.7 [INFO] [stderr] Checking directories v3.0.2 [INFO] [stderr] Checking trash_lib v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `percent_encoding::percent_decode_str` [INFO] [stdout] --> src/parser.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use percent_encoding::percent_decode_str; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self` [INFO] [stdout] --> src/parser.rs:9:27 [INFO] [stdout] | [INFO] [stdout] 9 | use crate::percent_path::{self, PercentPath}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ProjectDirs` [INFO] [stdout] --> src/lib.rs:10:19 [INFO] [stdout] | [INFO] [stdout] 10 | use directories::{ProjectDirs, UserDirs}; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::str::FromStr` [INFO] [stdout] --> src/parser.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use std::str::FromStr; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/parser.rs:126:10 [INFO] [stdout] | [INFO] [stdout] 126 | let (i, deletion_date) = all_consuming(parse_deletion_date)(i)?; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:116:28 [INFO] [stdout] | [INFO] [stdout] 116 | .map(|trash_entry| trash_entry.remove().context(TrashEntryRemove)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trash_entry.rs:229:18 [INFO] [stdout] | [INFO] [stdout] 229 | .map(|p| convert_to_str(p.as_ref()).unwrap()) // TODO: fix unwrap [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:62:5 [INFO] [stdout] | [INFO] [stdout] 58 | pub(crate) fn move_path(from: impl AsRef, to: impl AsRef) -> Result { [INFO] [stdout] | ---------------------- -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | / if from.is_dir() { [INFO] [stdout] 63 | | // first rename the dir because move_dir does not rename the directory while moving unlike [INFO] [stdout] 64 | | // move_file, so we have to rename it first manually. Also move dir does not work like [INFO] [stdout] 65 | | // move_file. Move dir moves the directory from a path to the inside of another directory. [INFO] [stdout] ... | [INFO] [stdout] 88 | | panic!("BUG: must be file or directory"); [INFO] [stdout] 89 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:95:5 [INFO] [stdout] | [INFO] [stdout] 93 | pub(crate) fn remove_path(path: impl AsRef) -> Result<()> { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | let path = path.as_ref(); [INFO] [stdout] 95 | / if path.is_dir() { [INFO] [stdout] 96 | | dir::remove(path) [INFO] [stdout] 97 | | } else if path.is_file() { [INFO] [stdout] 98 | | file::remove(path) [INFO] [stdout] 99 | | } else { [INFO] [stdout] 100 | | panic!("BUG: must be file or directory"); [INFO] [stdout] 101 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `trash_lib` (lib) due to 5 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "8341492137bbcd101deea6c46c124a3259edd70d8669f18fec199d04cd2ae8fc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8341492137bbcd101deea6c46c124a3259edd70d8669f18fec199d04cd2ae8fc", kill_on_drop: false }` [INFO] [stdout] 8341492137bbcd101deea6c46c124a3259edd70d8669f18fec199d04cd2ae8fc