[INFO] fetching crate transient-btree-index 0.5.1... [INFO] checking transient-btree-index-0.5.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate transient-btree-index 0.5.1 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate transient-btree-index 0.5.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate transient-btree-index 0.5.1 [INFO] finished tweaking crates.io crate transient-btree-index 0.5.1 [INFO] tweaked toml for crates.io crate transient-btree-index 0.5.1 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 99 packages to latest compatible versions [INFO] [stderr] Adding binary-layout v2.1.0 (latest: v4.0.2) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding clap v2.34.0 (latest: v4.5.16) [INFO] [stderr] Adding criterion v0.3.6 (latest: v0.5.1) [INFO] [stderr] Adding criterion-plot v0.4.5 (latest: v0.5.0) [INFO] [stderr] Adding half v1.8.3 (latest: v2.4.1) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding memmap2 v0.5.10 (latest: v0.9.4) [INFO] [stderr] Adding textwrap v0.11.0 (latest: v0.16.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ca28699ad59a79a3ff270bdaf9371af8778907efa7ae1aed53a96d3a7f695649 [INFO] running `Command { std: "docker" "start" "-a" "ca28699ad59a79a3ff270bdaf9371af8778907efa7ae1aed53a96d3a7f695649", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ca28699ad59a79a3ff270bdaf9371af8778907efa7ae1aed53a96d3a7f695649", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ca28699ad59a79a3ff270bdaf9371af8778907efa7ae1aed53a96d3a7f695649", kill_on_drop: false }` [INFO] [stdout] ca28699ad59a79a3ff270bdaf9371af8778907efa7ae1aed53a96d3a7f695649 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] fdf8c1cdfe650913165eacf1f7cac075230db081d4002fb5171e561dd582b525 [INFO] running `Command { std: "docker" "start" "-a" "fdf8c1cdfe650913165eacf1f7cac075230db081d4002fb5171e561dd582b525", kill_on_drop: false }` [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking plotters-backend v0.3.6 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking rustix v0.38.35 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking half v1.8.3 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking memmap2 v0.5.10 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Checking deunicode v1.6.0 [INFO] [stderr] Checking oorandom v11.1.4 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking serde_cbor v0.11.2 [INFO] [stderr] Checking plotters-svg v0.3.6 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking debug_tree v0.4.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking binary-layout v2.1.0 [INFO] [stderr] Checking plotters v0.3.6 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking fake v2.9.2 [INFO] [stderr] Checking criterion-plot v0.4.5 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Checking criterion v0.3.6 [INFO] [stderr] Checking transient-btree-index v0.5.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/btree.rs:165:12 [INFO] [stdout] | [INFO] [stdout] 143 | let mut nodes = NodeFile::with_capacity(capacity, &config)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 144 | [INFO] [stdout] 145 | let values: Box> = match config.value_size { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 146 | TypeSize::Estimated(est_max_value_size) => { [INFO] [stdout] 147 | let f = VariableSizeTupleFile::with_capacity( [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 154 | let f = FixedSizeTupleFile::with_capacity( [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 165 | Ok(BtreeIndex { [INFO] [stdout] | ____________^ [INFO] [stdout] 166 | | root_id, [INFO] [stdout] 167 | | nodes, [INFO] [stdout] 168 | | values, [INFO] [stdout] ... | [INFO] [stdout] 171 | | last_inserted_node_id: root_id, [INFO] [stdout] 172 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/btree.rs:446:12 [INFO] [stdout] | [INFO] [stdout] 444 | let value = self.values.get_owned(payload_id.try_into()?)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 445 | let key = self.nodes.get_key_owned(node, idx)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 446 | Ok((key, value)) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/btree.rs:508:12 [INFO] [stdout] | [INFO] [stdout] 506 | let value = self.values.get_owned(payload_id.try_into()?)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 507 | let key = self.nodes.get_key_owned(node, idx)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 508 | Ok((key, value)) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/btree/node.rs:75:12 [INFO] [stdout] | [INFO] [stdout] 57 | let mmap = create_mmap(capacity_in_nodes * NODE_BLOCK_ALIGNED_SIZE)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | let keys: Box> = match config.key_size { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | super::TypeSize::Estimated(est_max_key_size) => { [INFO] [stdout] 62 | let f = VariableSizeTupleFile::with_capacity( [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | let f = [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | Ok(NodeFile { [INFO] [stdout] | ____________^ [INFO] [stdout] 76 | | mmap, [INFO] [stdout] 77 | | keys, [INFO] [stdout] 78 | | free_space_offset: 0, [INFO] [stdout] 79 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file.rs:222:12 [INFO] [stdout] | [INFO] [stdout] 220 | let mmap = create_mmap(capacity)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 221 | [INFO] [stdout] 222 | Ok(VariableSizeTupleFile { [INFO] [stdout] | ____________^ [INFO] [stdout] 223 | | mmap, [INFO] [stdout] 224 | | free_space_offset: 0, [INFO] [stdout] 225 | | relocated_blocks: HashMap::default(), [INFO] [stdout] ... | [INFO] [stdout] 228 | | block_cache_size, [INFO] [stdout] 229 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file.rs:342:12 [INFO] [stdout] | [INFO] [stdout] 341 | let result = self.read_block(block_id)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 342 | Ok(Arc::new(result)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file.rs:375:12 [INFO] [stdout] | [INFO] [stdout] 374 | let mmap = create_mmap(capacity)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 375 | Ok(FixedSizeTupleFile { [INFO] [stdout] | ____________^ [INFO] [stdout] 376 | | mmap, [INFO] [stdout] 377 | | fixed_tuple_size, [INFO] [stdout] 378 | | free_space_offset: 0, [INFO] [stdout] 379 | | phantom: PhantomData, [INFO] [stdout] 380 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `transient-btree-index` (lib) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "fdf8c1cdfe650913165eacf1f7cac075230db081d4002fb5171e561dd582b525", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fdf8c1cdfe650913165eacf1f7cac075230db081d4002fb5171e561dd582b525", kill_on_drop: false }` [INFO] [stdout] fdf8c1cdfe650913165eacf1f7cac075230db081d4002fb5171e561dd582b525