[INFO] fetching crate transform-gizmo 0.3.0... [INFO] checking transform-gizmo-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate transform-gizmo 0.3.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate transform-gizmo 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate transform-gizmo 0.3.0 [INFO] finished tweaking crates.io crate transform-gizmo 0.3.0 [INFO] tweaked toml for crates.io crate transform-gizmo 0.3.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 49 packages to latest compatible versions [INFO] [stderr] Adding glam v0.28.0 (latest: v0.29.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9683f9c4a5b9266002a3203dcad72591e89c4742492e68d847cdacc3ba6eb80f [INFO] running `Command { std: "docker" "start" "-a" "9683f9c4a5b9266002a3203dcad72591e89c4742492e68d847cdacc3ba6eb80f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9683f9c4a5b9266002a3203dcad72591e89c4742492e68d847cdacc3ba6eb80f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9683f9c4a5b9266002a3203dcad72591e89c4742492e68d847cdacc3ba6eb80f", kill_on_drop: false }` [INFO] [stdout] 9683f9c4a5b9266002a3203dcad72591e89c4742492e68d847cdacc3ba6eb80f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 47ff93190f6d3751c44be45856a45f4efad3d9e2b4cfd870e7e1b2386fbb9a6a [INFO] running `Command { std: "docker" "start" "-a" "47ff93190f6d3751c44be45856a45f4efad3d9e2b4cfd870e7e1b2386fbb9a6a", kill_on_drop: false }` [INFO] [stderr] Checking ttf-parser v0.24.1 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking ab_glyph_rasterizer v0.1.8 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking emath v0.28.1 [INFO] [stderr] Checking nohash-hasher v0.2.0 [INFO] [stderr] Checking mint v0.5.9 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking ecolor v0.28.1 [INFO] [stderr] Checking glam v0.28.0 [INFO] [stderr] Checking owned_ttf_parser v0.24.0 [INFO] [stderr] Checking ab_glyph v0.2.28 [INFO] [stderr] Checking epaint v0.28.1 [INFO] [stderr] Compiling darling_core v0.20.10 [INFO] [stderr] Compiling enum_dispatch v0.3.13 [INFO] [stderr] Compiling darling_macro v0.20.10 [INFO] [stderr] Compiling darling v0.20.10 [INFO] [stderr] Compiling enumset_derive v0.10.0 [INFO] [stderr] Checking enumset v1.1.5 [INFO] [stderr] Checking transform-gizmo v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shape.rs:82:31 [INFO] [stdout] | [INFO] [stdout] 72 | stroke: impl Into, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | self.tessellate_shape(if closed { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 83 | | points.pop(); [INFO] [stdout] 84 | | Shape::closed_line(points, stroke.into()) [INFO] [stdout] 85 | | } else { [INFO] [stdout] 86 | | Shape::line(points, stroke.into()) [INFO] [stdout] 87 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shape.rs:103:31 [INFO] [stdout] | [INFO] [stdout] 98 | stroke: impl Into, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 103 | self.tessellate_shape(Shape::convex_polygon(points, color, stroke.into())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shape.rs:122:31 [INFO] [stdout] | [INFO] [stdout] 110 | stroke: impl Into, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 122 | self.tessellate_shape(Shape::LineSegment { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 123 | | points, [INFO] [stdout] 124 | | stroke: stroke.into(), [INFO] [stdout] 125 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shape.rs:133:31 [INFO] [stdout] | [INFO] [stdout] 128 | pub(crate) fn arrow(&self, from: DVec3, to: DVec3, stroke: impl Into) -> Mesh { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 133 | self.tessellate_shape(if let Some((start, end)) = arrow_start.zip(arrow_end) { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 134 | | let cross = (end - start).normalized().rot90() * stroke.width / 2.0; [INFO] [stdout] 135 | | [INFO] [stdout] 136 | | Shape::convex_polygon( [INFO] [stdout] ... | [INFO] [stdout] 142 | | Shape::Noop [INFO] [stdout] 143 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shape.rs:157:31 [INFO] [stdout] | [INFO] [stdout] 149 | fill: impl Into, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 150 | stroke: impl Into, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 157 | self.tessellate_shape(if points.len() > 2 { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 158 | | Shape::convex_polygon(points, fill, stroke) [INFO] [stdout] 159 | | } else { [INFO] [stdout] 160 | | Shape::Noop [INFO] [stdout] 161 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shape.rs:170:31 [INFO] [stdout] | [INFO] [stdout] 164 | pub(crate) fn polyline(&self, points: &[DVec3], stroke: impl Into) -> Mesh { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 170 | self.tessellate_shape(if points.len() > 1 { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 171 | | Shape::line(points, stroke) [INFO] [stdout] 172 | | } else { [INFO] [stdout] 173 | | Shape::Noop [INFO] [stdout] 174 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shape.rs:223:31 [INFO] [stdout] | [INFO] [stdout] 182 | fill: impl Into, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 183 | stroke: impl Into, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 223 | self.tessellate_shape(Shape::convex_polygon(points, fill, stroke)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `transform-gizmo` (lib) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shape.rs:82:31 [INFO] [stdout] | [INFO] [stdout] 72 | stroke: impl Into, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | self.tessellate_shape(if closed { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 83 | | points.pop(); [INFO] [stdout] 84 | | Shape::closed_line(points, stroke.into()) [INFO] [stdout] 85 | | } else { [INFO] [stdout] 86 | | Shape::line(points, stroke.into()) [INFO] [stdout] 87 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shape.rs:103:31 [INFO] [stdout] | [INFO] [stdout] 98 | stroke: impl Into, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 103 | self.tessellate_shape(Shape::convex_polygon(points, color, stroke.into())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shape.rs:122:31 [INFO] [stdout] | [INFO] [stdout] 110 | stroke: impl Into, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 122 | self.tessellate_shape(Shape::LineSegment { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 123 | | points, [INFO] [stdout] 124 | | stroke: stroke.into(), [INFO] [stdout] 125 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shape.rs:133:31 [INFO] [stdout] | [INFO] [stdout] 128 | pub(crate) fn arrow(&self, from: DVec3, to: DVec3, stroke: impl Into) -> Mesh { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 133 | self.tessellate_shape(if let Some((start, end)) = arrow_start.zip(arrow_end) { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 134 | | let cross = (end - start).normalized().rot90() * stroke.width / 2.0; [INFO] [stdout] 135 | | [INFO] [stdout] 136 | | Shape::convex_polygon( [INFO] [stdout] ... | [INFO] [stdout] 142 | | Shape::Noop [INFO] [stdout] 143 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shape.rs:157:31 [INFO] [stdout] | [INFO] [stdout] 149 | fill: impl Into, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 150 | stroke: impl Into, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 157 | self.tessellate_shape(if points.len() > 2 { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 158 | | Shape::convex_polygon(points, fill, stroke) [INFO] [stdout] 159 | | } else { [INFO] [stdout] 160 | | Shape::Noop [INFO] [stdout] 161 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shape.rs:170:31 [INFO] [stdout] | [INFO] [stdout] 164 | pub(crate) fn polyline(&self, points: &[DVec3], stroke: impl Into) -> Mesh { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 170 | self.tessellate_shape(if points.len() > 1 { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 171 | | Shape::line(points, stroke) [INFO] [stdout] 172 | | } else { [INFO] [stdout] 173 | | Shape::Noop [INFO] [stdout] 174 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shape.rs:223:31 [INFO] [stdout] | [INFO] [stdout] 182 | fill: impl Into, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 183 | stroke: impl Into, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 223 | self.tessellate_shape(Shape::convex_polygon(points, fill, stroke)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `transform-gizmo` (lib test) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "47ff93190f6d3751c44be45856a45f4efad3d9e2b4cfd870e7e1b2386fbb9a6a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "47ff93190f6d3751c44be45856a45f4efad3d9e2b4cfd870e7e1b2386fbb9a6a", kill_on_drop: false }` [INFO] [stdout] 47ff93190f6d3751c44be45856a45f4efad3d9e2b4cfd870e7e1b2386fbb9a6a