[INFO] fetching crate trane 0.22.0... [INFO] checking trane-0.22.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate trane 0.22.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate trane 0.22.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate trane 0.22.0 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate trane 0.22.0 [INFO] tweaked toml for crates.io crate trane 0.22.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 196 packages to latest compatible versions [INFO] [stderr] Adding fs4 v0.8.4 (latest: v0.9.1) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding itertools v0.12.1 (latest: v0.13.0) [INFO] [stderr] Adding libsqlite3-sys v0.28.0 (latest: v0.30.1) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding r2d2_sqlite v0.24.0 (latest: v0.25.0) [INFO] [stderr] Adding rusqlite v0.31.0 (latest: v0.32.1) [INFO] [stderr] Adding rustc-hash v1.1.0 (latest: v2.0.0) [INFO] [stderr] Adding sketches-ddsketch v0.2.2 (latest: v0.3.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f3d0f1eb03edf839e910b3ef6a6c42c0890a4308f4e6b4534a33a2b3d6628f61 [INFO] running `Command { std: "docker" "start" "-a" "f3d0f1eb03edf839e910b3ef6a6c42c0890a4308f4e6b4534a33a2b3d6628f61", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f3d0f1eb03edf839e910b3ef6a6c42c0890a4308f4e6b4534a33a2b3d6628f61", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f3d0f1eb03edf839e910b3ef6a6c42c0890a4308f4e6b4534a33a2b3d6628f61", kill_on_drop: false }` [INFO] [stdout] f3d0f1eb03edf839e910b3ef6a6c42c0890a4308f4e6b4534a33a2b3d6628f61 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b51c63336a56646a43cbc3ca58758099b533c416acf20f6f02efa2c4523f52f3 [INFO] running `Command { std: "docker" "start" "-a" "b51c63336a56646a43cbc3ca58758099b533c416acf20f6f02efa2c4523f52f3", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling zstd-sys v2.0.13+zstd.1.5.6 [INFO] [stderr] Compiling libz-sys v1.1.20 [INFO] [stderr] Compiling openssl-sys v0.9.103 [INFO] [stderr] Checking ahash v0.8.11 [INFO] [stderr] Compiling crunchy v0.2.2 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Compiling zstd-safe v7.2.1 [INFO] [stderr] Checking ownedbytes v0.7.0 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Compiling libsqlite3-sys v0.28.0 [INFO] [stderr] Compiling libssh2-sys v0.3.0 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Checking bitpacking v0.9.2 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Checking utf8-ranges v1.0.5 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking tantivy-fst v0.5.0 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking hashlink v0.9.1 [INFO] [stderr] Checking tantivy-bitpacker v0.6.0 [INFO] [stderr] Checking rand_distr v0.4.3 [INFO] [stderr] Compiling libgit2-sys v0.17.0+1.8.1 [INFO] [stderr] Checking fallible-iterator v0.3.0 [INFO] [stderr] Checking murmurhash32 v0.3.1 [INFO] [stderr] Checking fallible-streaming-iterator v0.1.9 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking scheduled-thread-pool v0.2.7 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking instant v0.1.13 [INFO] [stderr] Compiling rusqlite_migration v1.2.0 [INFO] [stderr] Compiling termcolor v1.4.1 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Checking fastrand v2.1.1 [INFO] [stderr] Checking downcast-rs v1.2.1 [INFO] [stderr] Checking fastdivide v0.4.1 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Checking tantivy-query-grammar v0.22.0 [INFO] [stderr] Compiling ts-rs-macros v9.0.1 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking tantivy-tokenizer-api v0.3.0 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking sketches-ddsketch v0.2.2 [INFO] [stderr] Checking rust-stemmers v1.2.0 [INFO] [stderr] Checking measure_time v0.8.3 [INFO] [stderr] Checking fs4 v0.8.4 [INFO] [stderr] Checking tantivy-common v0.7.0 [INFO] [stderr] Checking r2d2 v0.8.10 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking lru v0.12.4 [INFO] [stderr] Checking tantivy-stacker v0.3.0 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking memmap2 v0.9.4 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking oneshot v0.1.8 [INFO] [stderr] Checking htmlescape v0.3.1 [INFO] [stderr] Checking levenshtein_automata v0.2.1 [INFO] [stderr] Checking lz4_flex v0.11.3 [INFO] [stderr] Checking census v0.4.2 [INFO] [stderr] Checking arc-swap v1.7.1 [INFO] [stderr] Checking ustr v1.0.0 [INFO] [stderr] Checking ts-rs v9.0.1 [INFO] [stderr] Checking mantra-miner v0.1.1 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking fs_extra v1.3.0 [INFO] [stderr] Compiling indoc v2.0.5 [INFO] [stderr] Checking zstd v0.13.2 [INFO] [stderr] Checking tantivy-sstable v0.3.0 [INFO] [stderr] Checking rusqlite v0.31.0 [INFO] [stderr] Checking tantivy-columnar v0.3.0 [INFO] [stderr] Checking r2d2_sqlite v0.24.0 [INFO] [stderr] Checking tantivy v0.22.0 [INFO] [stderr] Checking git2 v0.19.0 [INFO] [stderr] Checking trane v0.22.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:294:12 [INFO] [stdout] | [INFO] [stdout] 247 | let preferences_manager = Arc::new(RwLock::new(LocalPreferencesManager { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 253 | let course_library = Arc::new(RwLock::new(LocalCourseLibrary::new( [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 258 | let transcription_downloader = Arc::new(RwLock::new(LocalTranscriptionDownloader { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 262 | let unit_graph = course_library.write().get_unit_graph(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 263 | let practice_stats = Arc::new(RwLock::new(LocalPracticeStats::new_from_disk( [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 266 | let blacklist = Arc::new(RwLock::new(LocalBlacklist::new_from_disk( [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 269 | let review_list = Arc::new(RwLock::new(LocalReviewList::new_from_disk( [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 272 | let filter_manager = Arc::new(RwLock::new(LocalFilterManager::new( [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 275 | let study_sessions_manager = Arc::new(RwLock::new(LocalStudySessionManager::new( [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 278 | let repo_manager = Arc::new(RwLock::new(LocalRepositoryManager::new(library_root)?)); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 279 | let mut mantra_miner = TraneMantraMiner::default(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 283 | let scheduler_data = SchedulerData { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 294 | Ok(Trane { [INFO] [stdout] | ____________^ [INFO] [stdout] 295 | | blacklist, [INFO] [stdout] 296 | | course_library, [INFO] [stdout] 297 | | filter_manager, [INFO] [stdout] ... | [INFO] [stdout] 308 | | mantra_miner, [INFO] [stdout] 309 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/course_builder/knowledge_base_builder.rs:398:9 [INFO] [stdout] | [INFO] [stdout] 357 | let mut short_ids = HashSet::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 395 | let mut manifest_file = fs::File::create(&manifest_path).context(format!( [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 398 | / manifest_file [INFO] [stdout] 399 | | .write_all(serde_json::to_string_pretty(&self.manifest)?.as_bytes()) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |________________________________________________________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/course_library.rs:191:9 [INFO] [stdout] | [INFO] [stdout] 189 | let file = File::open(path).context(format!("cannot open manifest file {display}"))?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 190 | let reader = BufReader::new(file); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 191 | serde_json::from_reader(reader).context(format!("cannot parse manifest file {display}")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data/course_generator/knowledge_base.rs:106:9 [INFO] [stdout] | [INFO] [stdout] 103 | let file = [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | File::open(path).context(format!("cannot open knowledge base file {display}"))?; [INFO] [stdout] 105 | let reader = BufReader::new(file); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | serde_json::from_reader(reader) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data/course_generator/transcription.rs:168:9 [INFO] [stdout] | [INFO] [stdout] 165 | let file = [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 166 | File::open(path).context(format!("cannot open passage file {}", path.display()))?; [INFO] [stdout] 167 | let reader = BufReader::new(file); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 168 | serde_json::from_reader(reader) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/practice_stats.rs:95:9 [INFO] [stdout] | [INFO] [stdout] 93 | let mut connection = self.pool.get()?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | let migrations = Self::migrations(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | / migrations [INFO] [stdout] 96 | | .to_latest(&mut connection) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_______________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/preferences_manager.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | fs::write(&self.path, pretty_json).context("failed to write user preferences") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/review_list.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 51 | let mut connection = self.pool.get()?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | let migrations = Self::migrations(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | / migrations [INFO] [stdout] 54 | | .to_latest(&mut connection) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_______________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scheduler.rs:154:19 [INFO] [stdout] | [INFO] [stdout] 152 | pub fn new(data: SchedulerData) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 153 | Self { [INFO] [stdout] 154 | data: data.clone(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scheduler.rs:155:26 [INFO] [stdout] | [INFO] [stdout] 152 | pub fn new(data: SchedulerData) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 155 | score_cache: ScoreCache::new(data.clone(), data.options.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scheduler.rs:156:21 [INFO] [stdout] | [INFO] [stdout] 152 | pub fn new(data: SchedulerData) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 156 | filter: CandidateFilter::new(data), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scheduler.rs:194:9 [INFO] [stdout] | [INFO] [stdout] 175 | let mut starting_courses = self.data.unit_graph.read().get_dependency_sinks(); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 194 | / starting_courses [INFO] [stdout] 195 | | .into_iter() [INFO] [stdout] 196 | | .filter(|course_id| { [INFO] [stdout] 197 | | self.data [INFO] [stdout] ... | [INFO] [stdout] 203 | | .all(|id| !self.data.unit_exists(*id).unwrap()) [INFO] [stdout] 204 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scheduler.rs:203:32 [INFO] [stdout] | [INFO] [stdout] 203 | .all(|id| !self.data.unit_exists(*id).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scheduler.rs:872:64 [INFO] [stdout] | [INFO] [stdout] 872 | .map_err(|e| ExerciseSchedulerError::ScoreExercise(e.into()))?; [INFO] [stdout] | - ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scheduler/cache.rs:59:21 [INFO] [stdout] | [INFO] [stdout] 52 | pub(super) fn new(data: SchedulerData, options: SchedulerOptions) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | scorer: Box::new(SimpleScorer {}), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scheduler/cache.rs:151:9 [INFO] [stdout] | [INFO] [stdout] 147 | let scores: Vec> = valid_exercises [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 151 | / scores [INFO] [stdout] 152 | | .into_iter() [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scheduler/cache.rs:172:30 [INFO] [stdout] | [INFO] [stdout] 172 | .filter_map(|id| self.get_unit_score(*id).unwrap_or_default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scheduler/data.rs:170:34 [INFO] [stdout] | [INFO] [stdout] 170 | .retain(|dependency| self.unit_graph.read().get_unit_type(*dependency).is_some()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scheduler/data.rs:329:36 [INFO] [stdout] | [INFO] [stdout] 329 | .filter(|exercise_id| !self.blacklisted(*exercise_id).unwrap_or(false)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/testutil.rs:163:12 [INFO] [stdout] | [INFO] [stdout] 130 | let exercise_builders = (0..self.num_exercises) [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 163 | Ok(LessonBuilder { [INFO] [stdout] | ____________^ [INFO] [stdout] 164 | | directory_name: format!("lesson_{}", self.id.1.unwrap()), [INFO] [stdout] 165 | | manifest_closure: Box::new(move |m| { [INFO] [stdout] 166 | | let lesson_id = id_clone.to_ustr(); [INFO] [stdout] ... | [INFO] [stdout] 196 | | ], [INFO] [stdout] 197 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/testutil.rs:241:12 [INFO] [stdout] | [INFO] [stdout] 233 | let lesson_builders = self [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 241 | Ok(CourseBuilder { [INFO] [stdout] | ____________^ [INFO] [stdout] 242 | | directory_name: format!("course_{}", self.id.0), [INFO] [stdout] 243 | | course_manifest: CourseManifest { [INFO] [stdout] 244 | | id: course_id, [INFO] [stdout] ... | [INFO] [stdout] 278 | | ], [INFO] [stdout] 279 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/testutil.rs:521:23 [INFO] [stdout] | [INFO] [stdout] 521 | .map(|course| course.course_builder()?.build(library_root)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 22 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `trane` (lib) due to 23 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:294:12 [INFO] [stdout] | [INFO] [stdout] 247 | let preferences_manager = Arc::new(RwLock::new(LocalPreferencesManager { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 253 | let course_library = Arc::new(RwLock::new(LocalCourseLibrary::new( [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 258 | let transcription_downloader = Arc::new(RwLock::new(LocalTranscriptionDownloader { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 262 | let unit_graph = course_library.write().get_unit_graph(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 263 | let practice_stats = Arc::new(RwLock::new(LocalPracticeStats::new_from_disk( [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 266 | let blacklist = Arc::new(RwLock::new(LocalBlacklist::new_from_disk( [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 269 | let review_list = Arc::new(RwLock::new(LocalReviewList::new_from_disk( [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 272 | let filter_manager = Arc::new(RwLock::new(LocalFilterManager::new( [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 275 | let study_sessions_manager = Arc::new(RwLock::new(LocalStudySessionManager::new( [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 278 | let repo_manager = Arc::new(RwLock::new(LocalRepositoryManager::new(library_root)?)); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 279 | let mut mantra_miner = TraneMantraMiner::default(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 283 | let scheduler_data = SchedulerData { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 294 | Ok(Trane { [INFO] [stdout] | ____________^ [INFO] [stdout] 295 | | blacklist, [INFO] [stdout] 296 | | course_library, [INFO] [stdout] 297 | | filter_manager, [INFO] [stdout] ... | [INFO] [stdout] 308 | | mantra_miner, [INFO] [stdout] 309 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blacklist.rs:217:12 [INFO] [stdout] | [INFO] [stdout] 215 | let connection_manager = SqliteConnectionManager::memory(); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 216 | let blacklist = LocalBlacklist::new(connection_manager)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 217 | Ok(Box::new(blacklist)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/course_builder/knowledge_base_builder.rs:398:9 [INFO] [stdout] | [INFO] [stdout] 357 | let mut short_ids = HashSet::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 395 | let mut manifest_file = fs::File::create(&manifest_path).context(format!( [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 398 | / manifest_file [INFO] [stdout] 399 | | .write_all(serde_json::to_string_pretty(&self.manifest)?.as_bytes()) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |________________________________________________________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/course_library.rs:191:9 [INFO] [stdout] | [INFO] [stdout] 189 | let file = File::open(path).context(format!("cannot open manifest file {display}"))?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 190 | let reader = BufReader::new(file); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 191 | serde_json::from_reader(reader).context(format!("cannot parse manifest file {display}")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data/course_generator/knowledge_base.rs:106:9 [INFO] [stdout] | [INFO] [stdout] 103 | let file = [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | File::open(path).context(format!("cannot open knowledge base file {display}"))?; [INFO] [stdout] 105 | let reader = BufReader::new(file); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | serde_json::from_reader(reader) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data/course_generator/transcription.rs:168:9 [INFO] [stdout] | [INFO] [stdout] 165 | let file = [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 166 | File::open(path).context(format!("cannot open passage file {}", path.display()))?; [INFO] [stdout] 167 | let reader = BufReader::new(file); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 168 | serde_json::from_reader(reader) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/practice_stats.rs:95:9 [INFO] [stdout] | [INFO] [stdout] 93 | let mut connection = self.pool.get()?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | let migrations = Self::migrations(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | / migrations [INFO] [stdout] 96 | | .to_latest(&mut connection) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_______________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/practice_stats.rs:263:12 [INFO] [stdout] | [INFO] [stdout] 261 | let connection_manager = SqliteConnectionManager::memory(); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 262 | let practice_stats = LocalPracticeStats::new(connection_manager)?; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 263 | Ok(Box::new(practice_stats)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/preferences_manager.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | fs::write(&self.path, pretty_json).context("failed to write user preferences") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/review_list.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 51 | let mut connection = self.pool.get()?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | let migrations = Self::migrations(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | / migrations [INFO] [stdout] 54 | | .to_latest(&mut connection) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_______________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/review_list.rs:145:12 [INFO] [stdout] | [INFO] [stdout] 143 | let connection_manager = SqliteConnectionManager::memory(); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 144 | let review_list = LocalReviewList::new(connection_manager)?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 145 | Ok(Box::new(review_list)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scheduler.rs:154:19 [INFO] [stdout] | [INFO] [stdout] 152 | pub fn new(data: SchedulerData) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 153 | Self { [INFO] [stdout] 154 | data: data.clone(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scheduler.rs:155:26 [INFO] [stdout] | [INFO] [stdout] 152 | pub fn new(data: SchedulerData) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 155 | score_cache: ScoreCache::new(data.clone(), data.options.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scheduler.rs:156:21 [INFO] [stdout] | [INFO] [stdout] 152 | pub fn new(data: SchedulerData) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 156 | filter: CandidateFilter::new(data), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scheduler.rs:194:9 [INFO] [stdout] | [INFO] [stdout] 175 | let mut starting_courses = self.data.unit_graph.read().get_dependency_sinks(); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 194 | / starting_courses [INFO] [stdout] 195 | | .into_iter() [INFO] [stdout] 196 | | .filter(|course_id| { [INFO] [stdout] 197 | | self.data [INFO] [stdout] ... | [INFO] [stdout] 203 | | .all(|id| !self.data.unit_exists(*id).unwrap()) [INFO] [stdout] 204 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scheduler.rs:203:32 [INFO] [stdout] | [INFO] [stdout] 203 | .all(|id| !self.data.unit_exists(*id).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scheduler.rs:872:64 [INFO] [stdout] | [INFO] [stdout] 872 | .map_err(|e| ExerciseSchedulerError::ScoreExercise(e.into()))?; [INFO] [stdout] | - ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scheduler/cache.rs:59:21 [INFO] [stdout] | [INFO] [stdout] 52 | pub(super) fn new(data: SchedulerData, options: SchedulerOptions) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | scorer: Box::new(SimpleScorer {}), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scheduler/cache.rs:151:9 [INFO] [stdout] | [INFO] [stdout] 147 | let scores: Vec> = valid_exercises [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 151 | / scores [INFO] [stdout] 152 | | .into_iter() [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scheduler/cache.rs:172:30 [INFO] [stdout] | [INFO] [stdout] 172 | .filter_map(|id| self.get_unit_score(*id).unwrap_or_default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scheduler/data.rs:170:34 [INFO] [stdout] | [INFO] [stdout] 170 | .retain(|dependency| self.unit_graph.read().get_unit_type(*dependency).is_some()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scheduler/data.rs:329:36 [INFO] [stdout] | [INFO] [stdout] 329 | .filter(|exercise_id| !self.blacklisted(*exercise_id).unwrap_or(false)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/testutil.rs:163:12 [INFO] [stdout] | [INFO] [stdout] 130 | let exercise_builders = (0..self.num_exercises) [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 163 | Ok(LessonBuilder { [INFO] [stdout] | ____________^ [INFO] [stdout] 164 | | directory_name: format!("lesson_{}", self.id.1.unwrap()), [INFO] [stdout] 165 | | manifest_closure: Box::new(move |m| { [INFO] [stdout] 166 | | let lesson_id = id_clone.to_ustr(); [INFO] [stdout] ... | [INFO] [stdout] 196 | | ], [INFO] [stdout] 197 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/testutil.rs:241:12 [INFO] [stdout] | [INFO] [stdout] 233 | let lesson_builders = self [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 241 | Ok(CourseBuilder { [INFO] [stdout] | ____________^ [INFO] [stdout] 242 | | directory_name: format!("course_{}", self.id.0), [INFO] [stdout] 243 | | course_manifest: CourseManifest { [INFO] [stdout] 244 | | id: course_id, [INFO] [stdout] ... | [INFO] [stdout] 278 | | ], [INFO] [stdout] 279 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/testutil.rs:521:23 [INFO] [stdout] | [INFO] [stdout] 521 | .map(|course| course.course_builder()?.build(library_root)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 25 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `trane` (lib test) due to 26 previous errors [INFO] running `Command { std: "docker" "inspect" "b51c63336a56646a43cbc3ca58758099b533c416acf20f6f02efa2c4523f52f3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b51c63336a56646a43cbc3ca58758099b533c416acf20f6f02efa2c4523f52f3", kill_on_drop: false }` [INFO] [stdout] b51c63336a56646a43cbc3ca58758099b533c416acf20f6f02efa2c4523f52f3