[INFO] fetching crate trait_variable 0.7.0... [INFO] checking trait_variable-0.7.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate trait_variable 0.7.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate trait_variable 0.7.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate trait_variable 0.7.0 [INFO] finished tweaking crates.io crate trait_variable 0.7.0 [INFO] tweaked toml for crates.io crate trait_variable 0.7.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 26 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 62346c3f3e2a2be21f65b88ab0a25fe54d87270b3c0a98f4c2e7f7d4d4ace667 [INFO] running `Command { std: "docker" "start" "-a" "62346c3f3e2a2be21f65b88ab0a25fe54d87270b3c0a98f4c2e7f7d4d4ace667", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "62346c3f3e2a2be21f65b88ab0a25fe54d87270b3c0a98f4c2e7f7d4d4ace667", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "62346c3f3e2a2be21f65b88ab0a25fe54d87270b3c0a98f4c2e7f7d4d4ace667", kill_on_drop: false }` [INFO] [stdout] 62346c3f3e2a2be21f65b88ab0a25fe54d87270b3c0a98f4c2e7f7d4d4ace667 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d449e62c76a3233c183ec6a8810238d1985d4e2055198dae235c6133e8a4908d [INFO] running `Command { std: "docker" "start" "-a" "d449e62c76a3233c183ec6a8810238d1985d4e2055198dae235c6133e8a4908d", kill_on_drop: false }` [INFO] [stderr] Checking unicode-ident v1.0.12 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Compiling paste v1.0.15 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking proc-macro2 v1.0.86 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking quote v1.0.37 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking syn v2.0.77 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking trait_variable v0.7.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:105:12 [INFO] [stdout] | [INFO] [stdout] 94 | let var_vis: Visibility = input.parse().expect("Failed to Parse to `var_vis`"); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | let var_name: Ident = input.parse().expect("Failed to Parse to `var_name`"); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | let _: Token![:] = input.parse().expect("Failed to Parse to `:`"); [INFO] [stdout] 97 | let type_name: Type = input.parse().expect("Failed to Parse to `type_name`"); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 105 | Ok(TraitVarField { [INFO] [stdout] | ____________^ [INFO] [stdout] 106 | | var_vis, [INFO] [stdout] 107 | | var_name, [INFO] [stdout] 108 | | type_name, [INFO] [stdout] 109 | | type_generics, [INFO] [stdout] 110 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:150:12 [INFO] [stdout] | [INFO] [stdout] 148 | let content; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 149 | [INFO] [stdout] 150 | Ok(TraitInput { [INFO] [stdout] | ____________^ [INFO] [stdout] 151 | | trait_vis: input.parse()?, [INFO] [stdout] 152 | | _trait_token: input.parse()?, [INFO] [stdout] 153 | | trait_name: input.parse()?, [INFO] [stdout] ... | [INFO] [stdout] 199 | | }, [INFO] [stdout] 200 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:407:12 [INFO] [stdout] | [INFO] [stdout] 406 | let ident = input.parse()?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 407 | Ok(AttrArgs(ident)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trait_item.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 11 | pub fn refine_trait_items(trait_items: Vec) -> Vec { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 12 | / trait_items [INFO] [stdout] 13 | | .into_iter() [INFO] [stdout] 14 | | .map(|item| { [INFO] [stdout] 15 | | match item { [INFO] [stdout] ... | [INFO] [stdout] 48 | | } [INFO] [stdout] 49 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trait_utils.rs:80:5 [INFO] [stdout] | [INFO] [stdout] 73 | pub fn parse_assignment_expr(expr: MyAssignExpr, is_method_mut: bool) -> Expr { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 80 | syn::parse_str(&new_expr_str).expect("Failed to parse to expr in fn `parse_assignment_expr`") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `trait_variable` (lib test) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:105:12 [INFO] [stdout] | [INFO] [stdout] 94 | let var_vis: Visibility = input.parse().expect("Failed to Parse to `var_vis`"); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | let var_name: Ident = input.parse().expect("Failed to Parse to `var_name`"); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | let _: Token![:] = input.parse().expect("Failed to Parse to `:`"); [INFO] [stdout] 97 | let type_name: Type = input.parse().expect("Failed to Parse to `type_name`"); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 105 | Ok(TraitVarField { [INFO] [stdout] | ____________^ [INFO] [stdout] 106 | | var_vis, [INFO] [stdout] 107 | | var_name, [INFO] [stdout] 108 | | type_name, [INFO] [stdout] 109 | | type_generics, [INFO] [stdout] 110 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:150:12 [INFO] [stdout] | [INFO] [stdout] 148 | let content; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 149 | [INFO] [stdout] 150 | Ok(TraitInput { [INFO] [stdout] | ____________^ [INFO] [stdout] 151 | | trait_vis: input.parse()?, [INFO] [stdout] 152 | | _trait_token: input.parse()?, [INFO] [stdout] 153 | | trait_name: input.parse()?, [INFO] [stdout] ... | [INFO] [stdout] 199 | | }, [INFO] [stdout] 200 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:407:12 [INFO] [stdout] | [INFO] [stdout] 406 | let ident = input.parse()?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 407 | Ok(AttrArgs(ident)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trait_item.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 11 | pub fn refine_trait_items(trait_items: Vec) -> Vec { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 12 | / trait_items [INFO] [stdout] 13 | | .into_iter() [INFO] [stdout] 14 | | .map(|item| { [INFO] [stdout] 15 | | match item { [INFO] [stdout] ... | [INFO] [stdout] 48 | | } [INFO] [stdout] 49 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trait_utils.rs:80:5 [INFO] [stdout] | [INFO] [stdout] 73 | pub fn parse_assignment_expr(expr: MyAssignExpr, is_method_mut: bool) -> Expr { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 80 | syn::parse_str(&new_expr_str).expect("Failed to parse to expr in fn `parse_assignment_expr`") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `trait_variable` (lib) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "d449e62c76a3233c183ec6a8810238d1985d4e2055198dae235c6133e8a4908d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d449e62c76a3233c183ec6a8810238d1985d4e2055198dae235c6133e8a4908d", kill_on_drop: false }` [INFO] [stdout] d449e62c76a3233c183ec6a8810238d1985d4e2055198dae235c6133e8a4908d