[INFO] fetching crate trait-make 0.1.0... [INFO] checking trait-make-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate trait-make 0.1.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate trait-make 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate trait-make 0.1.0 [INFO] finished tweaking crates.io crate trait-make 0.1.0 [INFO] tweaked toml for crates.io crate trait-make 0.1.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate trait-make 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5977b9e6be3310e8a11f7fe4e4ab9ac19e47db2d6f416459d4d013d8c267658d [INFO] running `Command { std: "docker" "start" "-a" "5977b9e6be3310e8a11f7fe4e4ab9ac19e47db2d6f416459d4d013d8c267658d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5977b9e6be3310e8a11f7fe4e4ab9ac19e47db2d6f416459d4d013d8c267658d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5977b9e6be3310e8a11f7fe4e4ab9ac19e47db2d6f416459d4d013d8c267658d", kill_on_drop: false }` [INFO] [stdout] 5977b9e6be3310e8a11f7fe4e4ab9ac19e47db2d6f416459d4d013d8c267658d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 685bf6b24f36518b1b4e55c11b625ad88725031e590f3d17560afddb4936ccf8 [INFO] running `Command { std: "docker" "start" "-a" "685bf6b24f36518b1b4e55c11b625ad88725031e590f3d17560afddb4936ccf8", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Checking tokio v1.36.0 [INFO] [stderr] Checking quote v1.0.35 [INFO] [stderr] Checking syn v2.0.49 [INFO] [stderr] Checking trait-make v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/variant.rs:113:40 [INFO] [stdout] | [INFO] [stdout] 113 | .map(|b| TypeParamBound::Trait(b.clone())) [INFO] [stdout] | - ^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/variant.rs:178:19 [INFO] [stdout] | [INFO] [stdout] 133 | let (arrow, output) = if sig.asyncness.is_some() { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 134 | let orig = match &sig.output { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 135 | ReturnType::Default => quote! { () }, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 136 | ReturnType::Type(_, ty) => quote! { #ty }, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 137 | }; [INFO] [stdout] 138 | let future = syn::parse2(quote! { ::core::future::Future }).unwrap(); [INFO] [stdout] | ------ ------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | let ty = Type::ImplTrait(TypeImplTrait { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 140 | impl_token: syn::parse2(quote! { impl }).unwrap(), [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 145 | (syn::parse2(quote! { -> }).unwrap(), ty) [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 150 | let ty = Type::ImplTrait(TypeImplTrait { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 162 | let default_impl = fn_item.default.as_ref().map(|default_impl| { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 178 | TraitItem::Fn(TraitItemFn { [INFO] [stdout] | ___________________^ [INFO] [stdout] 179 | | sig: Signature { [INFO] [stdout] 180 | | asyncness: None, [INFO] [stdout] 181 | | output: ReturnType::Type(arrow, Box::new(output)), [INFO] [stdout] ... | [INFO] [stdout] 185 | | ..fn_item.clone() [INFO] [stdout] 186 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `trait-make` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/variant.rs:113:40 [INFO] [stdout] | [INFO] [stdout] 113 | .map(|b| TypeParamBound::Trait(b.clone())) [INFO] [stdout] | - ^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/variant.rs:178:19 [INFO] [stdout] | [INFO] [stdout] 133 | let (arrow, output) = if sig.asyncness.is_some() { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 134 | let orig = match &sig.output { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 135 | ReturnType::Default => quote! { () }, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 136 | ReturnType::Type(_, ty) => quote! { #ty }, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 137 | }; [INFO] [stdout] 138 | let future = syn::parse2(quote! { ::core::future::Future }).unwrap(); [INFO] [stdout] | ------ ------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | let ty = Type::ImplTrait(TypeImplTrait { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 140 | impl_token: syn::parse2(quote! { impl }).unwrap(), [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 145 | (syn::parse2(quote! { -> }).unwrap(), ty) [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 150 | let ty = Type::ImplTrait(TypeImplTrait { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 162 | let default_impl = fn_item.default.as_ref().map(|default_impl| { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 178 | TraitItem::Fn(TraitItemFn { [INFO] [stdout] | ___________________^ [INFO] [stdout] 179 | | sig: Signature { [INFO] [stdout] 180 | | asyncness: None, [INFO] [stdout] 181 | | output: ReturnType::Type(arrow, Box::new(output)), [INFO] [stdout] ... | [INFO] [stdout] 185 | | ..fn_item.clone() [INFO] [stdout] 186 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `trait-make` (lib test) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "685bf6b24f36518b1b4e55c11b625ad88725031e590f3d17560afddb4936ccf8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "685bf6b24f36518b1b4e55c11b625ad88725031e590f3d17560afddb4936ccf8", kill_on_drop: false }` [INFO] [stdout] 685bf6b24f36518b1b4e55c11b625ad88725031e590f3d17560afddb4936ccf8