[INFO] fetching crate tracking-allocator 0.4.0... [INFO] checking tracking-allocator-0.4.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate tracking-allocator 0.4.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate tracking-allocator 0.4.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tracking-allocator 0.4.0 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate tracking-allocator 0.4.0 [INFO] tweaked toml for crates.io crate tracking-allocator 0.4.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate tracking-allocator 0.4.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1560888bf60e0a65f94db6ef7cfe44df55e096e6f0be25a15a568b02474423b6 [INFO] running `Command { std: "docker" "start" "-a" "1560888bf60e0a65f94db6ef7cfe44df55e096e6f0be25a15a568b02474423b6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1560888bf60e0a65f94db6ef7cfe44df55e096e6f0be25a15a568b02474423b6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1560888bf60e0a65f94db6ef7cfe44df55e096e6f0be25a15a568b02474423b6", kill_on_drop: false }` [INFO] [stdout] 1560888bf60e0a65f94db6ef7cfe44df55e096e6f0be25a15a568b02474423b6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 60384c63ba6e9a367bdb09886e3cf43c4f59b215bd5e4ec0f272201ee5504ee8 [INFO] running `Command { std: "docker" "start" "-a" "60384c63ba6e9a367bdb09886e3cf43c4f59b215bd5e4ec0f272201ee5504ee8", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling serde v1.0.130 [INFO] [stderr] Compiling semver v1.0.4 [INFO] [stderr] Compiling crossbeam-utils v0.8.5 [INFO] [stderr] Compiling libc v0.2.103 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Compiling proc-macro2 v1.0.29 [INFO] [stderr] Compiling crossbeam-epoch v0.9.5 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling rayon-core v1.9.1 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Compiling serde_json v1.0.68 [INFO] [stderr] Checking itoa v0.4.8 [INFO] [stderr] Compiling syn v1.0.78 [INFO] [stderr] Checking tracing-core v0.1.21 [INFO] [stderr] Checking unicode-width v0.1.9 [INFO] [stderr] Checking pin-project-lite v0.2.7 [INFO] [stderr] Compiling serde_derive v1.0.130 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking once_cell v1.8.0 [INFO] [stderr] Checking plotters-backend v0.3.2 [INFO] [stderr] Checking itertools v0.10.1 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking sharded-slab v0.1.3 [INFO] [stderr] Compiling memoffset v0.6.4 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling rayon v1.5.1 [INFO] [stderr] Checking plotters-svg v0.3.1 [INFO] [stderr] Checking thread_local v1.1.4 [INFO] [stderr] Checking crossbeam-channel v0.5.1 [INFO] [stderr] Compiling tokio v1.12.0 [INFO] [stderr] Checking half v1.7.1 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking walkdir v2.3.2 [INFO] [stderr] Checking tracing v0.1.28 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Compiling cast v0.2.7 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Checking crossbeam-deque v0.8.1 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking regex v1.5.4 [INFO] [stderr] Checking tracing-subscriber v0.3.7 [INFO] [stderr] Checking criterion-plot v0.4.4 [INFO] [stderr] Checking plotters v0.3.1 [INFO] [stderr] Checking tracking-allocator v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:128:22 [INFO] [stdout] | [INFO] [stdout] 123 | fn from_allocation_tracker(allocation_tracker: T) -> Self [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 128 | tracker: Arc::new(allocation_tracker), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/token.rs:19:47 [INFO] [stdout] | [INFO] [stdout] 19 | LOCAL_ALLOCATION_GROUP_STACK.with(|stack| stack.borrow_mut().push(group)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/token.rs:23:47 [INFO] [stdout] | [INFO] [stdout] 23 | LOCAL_ALLOCATION_GROUP_STACK.with(|stack| stack.borrow_mut().pop()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/token.rs:289:9 [INFO] [stdout] | [INFO] [stdout] 283 | pub(crate) fn with_suspended_allocation_group(f: F) -> R [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 289 | / |stack| { [INFO] [stdout] 290 | | // The crux of avoiding reentrancy is `RefCell:try_borrow_mut`, as `try_borrow_mut` will only let one [INFO] [stdout] 291 | | // mutable borrow happen at a time. As we simply want to ensure that the allocation group is suspended, we [INFO] [stdout] 292 | | // don't care what the return value is: calling `try_borrow_mut` and holding on to the result until the end [INFO] [stdout] ... | [INFO] [stdout] 296 | | f() [INFO] [stdout] 297 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tracking-allocator` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "60384c63ba6e9a367bdb09886e3cf43c4f59b215bd5e4ec0f272201ee5504ee8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "60384c63ba6e9a367bdb09886e3cf43c4f59b215bd5e4ec0f272201ee5504ee8", kill_on_drop: false }` [INFO] [stdout] 60384c63ba6e9a367bdb09886e3cf43c4f59b215bd5e4ec0f272201ee5504ee8