[INFO] fetching crate tracing-timing 0.6.0... [INFO] checking tracing-timing-0.6.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate tracing-timing 0.6.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate tracing-timing 0.6.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tracing-timing 0.6.0 [INFO] finished tweaking crates.io crate tracing-timing 0.6.0 [INFO] tweaked toml for crates.io crate tracing-timing 0.6.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate tracing-timing 0.6.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 09ba3a31fd4c28ebead724ec31dbb548e4fc0838705378076696b359321c3d09 [INFO] running `Command { std: "docker" "start" "-a" "09ba3a31fd4c28ebead724ec31dbb548e4fc0838705378076696b359321c3d09", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "09ba3a31fd4c28ebead724ec31dbb548e4fc0838705378076696b359321c3d09", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "09ba3a31fd4c28ebead724ec31dbb548e4fc0838705378076696b359321c3d09", kill_on_drop: false }` [INFO] [stdout] 09ba3a31fd4c28ebead724ec31dbb548e4fc0838705378076696b359321c3d09 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6574128e2eac8e63ca018d4497107abdfa0521aa0442ae7e2e4fee01c8781edf [INFO] running `Command { std: "docker" "start" "-a" "6574128e2eac8e63ca018d4497107abdfa0521aa0442ae7e2e4fee01c8781edf", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.64 [INFO] [stderr] Compiling crossbeam-utils v0.8.7 [INFO] [stderr] Checking cfg-if v0.1.6 [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling proc-macro2 v1.0.13 [INFO] [stderr] Compiling libm v0.1.4 [INFO] [stderr] Compiling getrandom v0.2.0 [INFO] [stderr] Compiling autocfg v0.1.6 [INFO] [stderr] Compiling cc v1.0.0 [INFO] [stderr] Compiling version_check v0.9.0 [INFO] [stderr] Compiling bitflags v1.2.0 [INFO] [stderr] Compiling minimal-lexical v0.1.2 [INFO] [stderr] Compiling crossbeam-epoch v0.9.5 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Checking tracing-core v0.1.22 [INFO] [stderr] Compiling syn v1.0.27 [INFO] [stderr] Checking once_cell v1.5.2 [INFO] [stderr] Checking log v0.4.0 [INFO] [stderr] Checking ppv-lite86 v0.2.8 [INFO] [stderr] Checking byteorder v1.0.0 [INFO] [stderr] Checking thread_local v1.1.4 [INFO] [stderr] Checking sharded-slab v0.1.0 [INFO] [stderr] Checking raw-cpuid v9.0.0 [INFO] [stderr] Checking atomic-shim v0.1.0 [INFO] [stderr] Checking tracing-log v0.1.2 [INFO] [stderr] Checking ansi_term v0.12.0 [INFO] [stderr] Compiling nom v7.0.0 [INFO] [stderr] Compiling memoffset v0.6.1 [INFO] [stderr] Checking smallvec v1.2.0 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Checking doc-comment v0.3.0 [INFO] [stderr] Checking indexmap v1.0.0 [INFO] [stderr] Checking slab v0.4.1 [INFO] [stderr] Compiling num-traits v0.2.9 [INFO] [stderr] Checking pin-project-lite v0.2.5 [INFO] [stderr] Checking crossbeam-channel v0.5.0 [INFO] [stderr] Checking crossbeam-queue v0.3.0 [INFO] [stderr] Compiling miniz-sys v0.1.10 [INFO] [stderr] Checking memchr v2.0.0 [INFO] [stderr] Checking rand_core v0.6.2 [INFO] [stderr] Compiling quote v1.0.0 [INFO] [stderr] Checking tracing-subscriber v0.3.8 [INFO] [stderr] Checking rand_chacha v0.3.0 [INFO] [stderr] Checking quanta v0.9.0 [INFO] [stderr] Checking crossbeam-deque v0.8.1 [INFO] [stderr] Checking rand v0.8.0 [INFO] [stderr] Checking crossbeam v0.8.0 [INFO] [stderr] Checking flate2 v1.0.3 [INFO] [stderr] Checking rand_distr v0.4.0 [INFO] [stderr] Checking hdrhistogram v7.5.0 [INFO] [stderr] Checking tracing-timing v0.6.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder.rs:145:31 [INFO] [stdout] | [INFO] [stdout] 136 | pub fn build_informed(self, new_histogram: F) -> TimingSubscriber [INFO] [stdout] | ---- ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 144 | let (tx, rx) = crossbeam::channel::unbounded(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 145 | TimingSubscriber::new(Timing { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 146 | | span_group: self.span_group, [INFO] [stdout] 147 | | event_group: self.event_group, [INFO] [stdout] 148 | | time: self.time, [INFO] [stdout] ... | [INFO] [stdout] 162 | | .into(), [INFO] [stdout] 163 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder.rs:175:29 [INFO] [stdout] | [INFO] [stdout] 167 | pub fn build(self, mut new_histogram: F) -> TimingSubscriber [INFO] [stdout] | ---- -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 175 | self.build_informed(move |_: &_, _: &_| (new_histogram)()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder.rs:204:26 [INFO] [stdout] | [INFO] [stdout] 195 | pub fn layer_informed(self, new_histogram: F) -> TimingLayer [INFO] [stdout] | ---- ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 203 | let (tx, rx) = crossbeam::channel::unbounded(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 204 | TimingLayer::new(Timing { [INFO] [stdout] | __________________________^ [INFO] [stdout] 205 | | span_group: self.span_group, [INFO] [stdout] 206 | | event_group: self.event_group, [INFO] [stdout] 207 | | time: self.time, [INFO] [stdout] ... | [INFO] [stdout] 221 | | .into(), [INFO] [stdout] 222 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder.rs:235:29 [INFO] [stdout] | [INFO] [stdout] 227 | pub fn layer(self, mut new_histogram: F) -> TimingLayer [INFO] [stdout] | ---- -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 235 | self.layer_informed(move |_: &_, _: &_| (new_histogram)()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/subscriber.rs:69:20 [INFO] [stdout] | [INFO] [stdout] 66 | pub(crate) fn new(timing: Timing) -> Self { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | spans: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/subscriber.rs:115:50 [INFO] [stdout] | [INFO] [stdout] 115 | .or_else(|| SPAN.with(|current_span| current_span.borrow().last().cloned())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tracing-timing` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "6574128e2eac8e63ca018d4497107abdfa0521aa0442ae7e2e4fee01c8781edf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6574128e2eac8e63ca018d4497107abdfa0521aa0442ae7e2e4fee01c8781edf", kill_on_drop: false }` [INFO] [stdout] 6574128e2eac8e63ca018d4497107abdfa0521aa0442ae7e2e4fee01c8781edf