[INFO] fetching crate tracing-rc 0.1.3... [INFO] checking tracing-rc-0.1.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate tracing-rc 0.1.3 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate tracing-rc 0.1.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tracing-rc 0.1.3 [INFO] finished tweaking crates.io crate tracing-rc 0.1.3 [INFO] tweaked toml for crates.io crate tracing-rc 0.1.3 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate tracing-rc 0.1.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 33c63c45e404cf64cb69c7fb1d24140438fc36b164b615f81a5921c098cf9c80 [INFO] running `Command { std: "docker" "start" "-a" "33c63c45e404cf64cb69c7fb1d24140438fc36b164b615f81a5921c098cf9c80", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "33c63c45e404cf64cb69c7fb1d24140438fc36b164b615f81a5921c098cf9c80", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "33c63c45e404cf64cb69c7fb1d24140438fc36b164b615f81a5921c098cf9c80", kill_on_drop: false }` [INFO] [stdout] 33c63c45e404cf64cb69c7fb1d24140438fc36b164b615f81a5921c098cf9c80 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cd749fdc4b0781406e5d08bb0676cef249ed266daa9e41ccddb1435e3b765015 [INFO] running `Command { std: "docker" "start" "-a" "cd749fdc4b0781406e5d08bb0676cef249ed266daa9e41ccddb1435e3b765015", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.36 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling syn v1.0.84 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Checking fixedbitset v0.4.0 [INFO] [stderr] Checking diff v0.1.12 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking pretty_assertions v1.0.0 [INFO] [stderr] Compiling indexmap v1.7.0 [INFO] [stderr] Compiling quote v1.0.14 [INFO] [stderr] Checking petgraph v0.6.0 [INFO] [stderr] Compiling synstructure v0.12.6 [INFO] [stderr] Compiling tracing-rc-derive v0.1.1 [INFO] [stderr] Checking tracing-rc v0.1.3 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rc/mod.rs:121:18 [INFO] [stdout] | [INFO] [stdout] 119 | pub fn new(data: T) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 120 | Self { [INFO] [stdout] 121 | ptr: Rc::new(Inner { [INFO] [stdout] | __________________^ [INFO] [stdout] 122 | | status: Cell::new(Status::Live), [INFO] [stdout] 123 | | data: RefCell::new(ManuallyDrop::new(data)), [INFO] [stdout] 124 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rc/collector.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 41 | fn try_from(weak: WeakNode) -> Result { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | / weak.upgrade() [INFO] [stdout] 43 | | .map(|strong| StrongNode { inner_ptr: strong }) [INFO] [stdout] | |___________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rc/collector.rs:72:24 [INFO] [stdout] | [INFO] [stdout] 72 | OLD_GEN.with(|old| old.borrow().len()) + YOUNG_GEN.with(|young| young.borrow().len()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rc/collector.rs:72:69 [INFO] [stdout] | [INFO] [stdout] 72 | OLD_GEN.with(|old| old.borrow().len()) + YOUNG_GEN.with(|young| young.borrow().len()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rc/collector.rs:129:17 [INFO] [stdout] | [INFO] [stdout] 128 | .filter_map(|weak| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 129 | / weak.try_into() [INFO] [stdout] 130 | | .ok() [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rc/mod.rs:121:18 [INFO] [stdout] | [INFO] [stdout] 119 | pub fn new(data: T) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 120 | Self { [INFO] [stdout] 121 | ptr: Rc::new(Inner { [INFO] [stdout] | __________________^ [INFO] [stdout] 122 | | status: Cell::new(Status::Live), [INFO] [stdout] 123 | | data: RefCell::new(ManuallyDrop::new(data)), [INFO] [stdout] 124 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rc/collector.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 41 | fn try_from(weak: WeakNode) -> Result { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | / weak.upgrade() [INFO] [stdout] 43 | | .map(|strong| StrongNode { inner_ptr: strong }) [INFO] [stdout] | |___________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rc/collector.rs:72:24 [INFO] [stdout] | [INFO] [stdout] 72 | OLD_GEN.with(|old| old.borrow().len()) + YOUNG_GEN.with(|young| young.borrow().len()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rc/collector.rs:72:69 [INFO] [stdout] | [INFO] [stdout] 72 | OLD_GEN.with(|old| old.borrow().len()) + YOUNG_GEN.with(|young| young.borrow().len()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rc/collector.rs:129:17 [INFO] [stdout] | [INFO] [stdout] 128 | .filter_map(|weak| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 129 | / weak.try_into() [INFO] [stdout] 130 | | .ok() [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tracing-rc` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `tracing-rc` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "cd749fdc4b0781406e5d08bb0676cef249ed266daa9e41ccddb1435e3b765015", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cd749fdc4b0781406e5d08bb0676cef249ed266daa9e41ccddb1435e3b765015", kill_on_drop: false }` [INFO] [stdout] cd749fdc4b0781406e5d08bb0676cef249ed266daa9e41ccddb1435e3b765015