[INFO] fetching crate tracing-loki 0.2.5... [INFO] checking tracing-loki-0.2.5 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate tracing-loki 0.2.5 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate tracing-loki 0.2.5 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tracing-loki 0.2.5 [INFO] finished tweaking crates.io crate tracing-loki 0.2.5 [INFO] tweaked toml for crates.io crate tracing-loki 0.2.5 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate tracing-loki 0.2.5 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ea670de7aa5927565af971408a9e5a17399536ad8a28ac8ce0eba51ac46dce7a [INFO] running `Command { std: "docker" "start" "-a" "ea670de7aa5927565af971408a9e5a17399536ad8a28ac8ce0eba51ac46dce7a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ea670de7aa5927565af971408a9e5a17399536ad8a28ac8ce0eba51ac46dce7a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ea670de7aa5927565af971408a9e5a17399536ad8a28ac8ce0eba51ac46dce7a", kill_on_drop: false }` [INFO] [stdout] ea670de7aa5927565af971408a9e5a17399536ad8a28ac8ce0eba51ac46dce7a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1b68c662f3e0b94425895bd68c5d520c8ffeff3661bfd75244b09bff560e810a [INFO] running `Command { std: "docker" "start" "-a" "1b68c662f3e0b94425895bd68c5d520c8ffeff3661bfd75244b09bff560e810a", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.36 [INFO] [stderr] Compiling syn v1.0.89 [INFO] [stderr] Compiling libc v0.2.120 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Checking bytes v1.1.0 [INFO] [stderr] Checking pin-project-lite v0.2.8 [INFO] [stderr] Compiling pkg-config v0.3.24 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling cc v1.0.73 [INFO] [stderr] Compiling futures-core v0.3.21 [INFO] [stderr] Checking itoa v1.0.1 [INFO] [stderr] Compiling serde_derive v1.0.136 [INFO] [stderr] Checking tracing-core v0.1.23 [INFO] [stderr] Compiling futures-task v0.3.21 [INFO] [stderr] Checking once_cell v1.10.0 [INFO] [stderr] Compiling indexmap v1.8.0 [INFO] [stderr] Compiling openssl v0.10.38 [INFO] [stderr] Compiling serde v1.0.136 [INFO] [stderr] Compiling futures-util v0.3.21 [INFO] [stderr] Compiling anyhow v1.0.56 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Compiling futures-channel v0.3.21 [INFO] [stderr] Checking matches v0.1.9 [INFO] [stderr] Compiling either v1.6.1 [INFO] [stderr] Checking futures-sink v0.3.21 [INFO] [stderr] Compiling httparse v1.6.0 [INFO] [stderr] Compiling native-tls v0.2.8 [INFO] [stderr] Checking tinyvec v1.5.1 [INFO] [stderr] Checking percent-encoding v2.1.0 [INFO] [stderr] Checking slab v0.4.5 [INFO] [stderr] Checking try-lock v0.2.3 [INFO] [stderr] Compiling itertools v0.10.3 [INFO] [stderr] Checking http v0.2.6 [INFO] [stderr] Compiling encoding_rs v0.8.30 [INFO] [stderr] Checking want v0.3.0 [INFO] [stderr] Checking form_urlencoded v1.0.1 [INFO] [stderr] Checking httpdate v1.0.2 [INFO] [stderr] Checking tower-service v0.3.1 [INFO] [stderr] Checking ryu v1.0.9 [INFO] [stderr] Checking unicode-bidi v0.3.7 [INFO] [stderr] Compiling snap v1.0.5 [INFO] [stderr] Compiling serde_json v1.0.79 [INFO] [stderr] Checking mio v0.8.2 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Compiling quote v1.0.16 [INFO] [stderr] Checking socket2 v0.4.4 [INFO] [stderr] Checking unicode-normalization v0.1.19 [INFO] [stderr] Checking tracing-log v0.1.2 [INFO] [stderr] Checking thread_local v1.1.4 [INFO] [stderr] Checking smallvec v1.8.0 [INFO] [stderr] Checking base64 v0.13.0 [INFO] [stderr] Checking mime v0.3.16 [INFO] [stderr] Checking ipnet v2.4.0 [INFO] [stderr] Compiling openssl-sys v0.9.72 [INFO] [stderr] Checking tracing-subscriber v0.3.9 [INFO] [stderr] Checking idna v0.2.3 [INFO] [stderr] Checking http-body v0.4.4 [INFO] [stderr] Checking url v2.2.2 [INFO] [stderr] Compiling tokio-macros v1.7.0 [INFO] [stderr] Compiling tracing-attributes v0.1.20 [INFO] [stderr] Compiling prost-derive v0.9.0 [INFO] [stderr] Checking tokio v1.17.0 [INFO] [stderr] Checking tracing v0.1.32 [INFO] [stderr] Checking prost v0.9.0 [INFO] [stderr] Checking prost-types v0.9.0 [INFO] [stderr] Checking loki-api v0.1.2 [INFO] [stderr] Checking tokio-util v0.6.9 [INFO] [stderr] Checking tokio-native-tls v0.3.0 [INFO] [stderr] Checking tokio-stream v0.1.8 [INFO] [stderr] Checking h2 v0.3.12 [INFO] [stderr] Checking hyper v0.14.17 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking tracing-serde v0.1.3 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking reqwest v0.11.10 [INFO] [stderr] Checking tracing-loki v0.2.5 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:462:12 [INFO] [stdout] | [INFO] [stdout] 458 | http_headers: reqwest::header::HeaderMap, [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 459 | receiver: mpsc::Receiver>, [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 462 | Ok(BackgroundTask { [INFO] [stdout] | ____________^ [INFO] [stdout] 463 | | receiver: ReceiverStream::new(receiver), [INFO] [stdout] 464 | | loki_url: loki_url [INFO] [stdout] 465 | | .join("loki/api/v1/push") [INFO] [stdout] ... | [INFO] [stdout] 489 | | send_task: None, [INFO] [stdout] 490 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder.rs:23:17 [INFO] [stdout] | [INFO] [stdout] 17 | let mut http_headers = reqwest::header::HeaderMap::new(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 23 | labels: FormattedLabels::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder.rs:162:12 [INFO] [stdout] | [INFO] [stdout] 160 | pub fn build_url(self, loki_url: Url) -> Result<(Layer, BackgroundTask), Error> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 161 | let (sender, receiver) = event_channel(); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 162 | Ok(( [INFO] [stdout] | ____________^ [INFO] [stdout] 163 | | Layer { [INFO] [stdout] 164 | | sender, [INFO] [stdout] 165 | | extra_fields: self.extra_fields, [INFO] [stdout] 166 | | }, [INFO] [stdout] 167 | | BackgroundTask::new(loki_url, self.http_headers, receiver, &self.labels)?, [INFO] [stdout] 168 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder.rs:193:12 [INFO] [stdout] | [INFO] [stdout] 189 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 192 | let (sender, receiver) = event_channel(); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 193 | Ok(( [INFO] [stdout] | ____________^ [INFO] [stdout] 194 | | Layer { [INFO] [stdout] 195 | | sender: sender.clone(), [INFO] [stdout] 196 | | extra_fields: self.extra_fields, [INFO] [stdout] ... | [INFO] [stdout] 199 | | BackgroundTask::new(loki_url, self.http_headers, receiver, &self.labels)?, [INFO] [stdout] 200 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/level_map.rs:24:18 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn from_fn T>(mut f: F) -> LevelMap { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | LevelMap { [INFO] [stdout] 24 | map: [ [INFO] [stdout] | __________________^ [INFO] [stdout] 25 | | f(Level::TRACE), [INFO] [stdout] 26 | | f(Level::DEBUG), [INFO] [stdout] 27 | | f(Level::INFO), [INFO] [stdout] 28 | | f(Level::WARN), [INFO] [stdout] 29 | | f(Level::ERROR), [INFO] [stdout] 30 | | ], [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/log_support.rs:27:37 [INFO] [stdout] | [INFO] [stdout] 26 | fn new(serializer: S) -> SerdeMapVisitorStrippingLog { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | SerdeMapVisitorStrippingLog(SerdeMapVisitor::new(serializer)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tracing-loki` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:462:12 [INFO] [stdout] | [INFO] [stdout] 458 | http_headers: reqwest::header::HeaderMap, [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 459 | receiver: mpsc::Receiver>, [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 462 | Ok(BackgroundTask { [INFO] [stdout] | ____________^ [INFO] [stdout] 463 | | receiver: ReceiverStream::new(receiver), [INFO] [stdout] 464 | | loki_url: loki_url [INFO] [stdout] 465 | | .join("loki/api/v1/push") [INFO] [stdout] ... | [INFO] [stdout] 489 | | send_task: None, [INFO] [stdout] 490 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder.rs:23:17 [INFO] [stdout] | [INFO] [stdout] 17 | let mut http_headers = reqwest::header::HeaderMap::new(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 23 | labels: FormattedLabels::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder.rs:162:12 [INFO] [stdout] | [INFO] [stdout] 160 | pub fn build_url(self, loki_url: Url) -> Result<(Layer, BackgroundTask), Error> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 161 | let (sender, receiver) = event_channel(); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 162 | Ok(( [INFO] [stdout] | ____________^ [INFO] [stdout] 163 | | Layer { [INFO] [stdout] 164 | | sender, [INFO] [stdout] 165 | | extra_fields: self.extra_fields, [INFO] [stdout] 166 | | }, [INFO] [stdout] 167 | | BackgroundTask::new(loki_url, self.http_headers, receiver, &self.labels)?, [INFO] [stdout] 168 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder.rs:193:12 [INFO] [stdout] | [INFO] [stdout] 189 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 192 | let (sender, receiver) = event_channel(); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 193 | Ok(( [INFO] [stdout] | ____________^ [INFO] [stdout] 194 | | Layer { [INFO] [stdout] 195 | | sender: sender.clone(), [INFO] [stdout] 196 | | extra_fields: self.extra_fields, [INFO] [stdout] ... | [INFO] [stdout] 199 | | BackgroundTask::new(loki_url, self.http_headers, receiver, &self.labels)?, [INFO] [stdout] 200 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/level_map.rs:24:18 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn from_fn T>(mut f: F) -> LevelMap { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | LevelMap { [INFO] [stdout] 24 | map: [ [INFO] [stdout] | __________________^ [INFO] [stdout] 25 | | f(Level::TRACE), [INFO] [stdout] 26 | | f(Level::DEBUG), [INFO] [stdout] 27 | | f(Level::INFO), [INFO] [stdout] 28 | | f(Level::WARN), [INFO] [stdout] 29 | | f(Level::ERROR), [INFO] [stdout] 30 | | ], [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/log_support.rs:27:37 [INFO] [stdout] | [INFO] [stdout] 26 | fn new(serializer: S) -> SerdeMapVisitorStrippingLog { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | SerdeMapVisitorStrippingLog(SerdeMapVisitor::new(serializer)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tracing-loki` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "1b68c662f3e0b94425895bd68c5d520c8ffeff3661bfd75244b09bff560e810a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1b68c662f3e0b94425895bd68c5d520c8ffeff3661bfd75244b09bff560e810a", kill_on_drop: false }` [INFO] [stdout] 1b68c662f3e0b94425895bd68c5d520c8ffeff3661bfd75244b09bff560e810a