[INFO] fetching crate tracing-indicatif 0.3.6... [INFO] checking tracing-indicatif-0.3.6 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate tracing-indicatif 0.3.6 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate tracing-indicatif 0.3.6 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tracing-indicatif 0.3.6 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate tracing-indicatif 0.3.6 [INFO] tweaked toml for crates.io crate tracing-indicatif 0.3.6 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate tracing-indicatif 0.3.6 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2ebc637d2ec3ce4be86a2d7a6c59d60ba512ef62d33ec6e9e5ea2110e4113fbd [INFO] running `Command { std: "docker" "start" "-a" "2ebc637d2ec3ce4be86a2d7a6c59d60ba512ef62d33ec6e9e5ea2110e4113fbd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2ebc637d2ec3ce4be86a2d7a6c59d60ba512ef62d33ec6e9e5ea2110e4113fbd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2ebc637d2ec3ce4be86a2d7a6c59d60ba512ef62d33ec6e9e5ea2110e4113fbd", kill_on_drop: false }` [INFO] [stdout] 2ebc637d2ec3ce4be86a2d7a6c59d60ba512ef62d33ec6e9e5ea2110e4113fbd [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 46d22ab26f6def418a3f73465eef10ed5cfdaf186fc1cceb9fb84feba45e108d [INFO] running `Command { std: "docker" "start" "-a" "46d22ab26f6def418a3f73465eef10ed5cfdaf186fc1cceb9fb84feba45e108d", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.70 [INFO] [stderr] Compiling libc v0.2.151 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Compiling futures-core v0.3.29 [INFO] [stderr] Checking smallvec v1.11.2 [INFO] [stderr] Compiling futures-channel v0.3.29 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Compiling futures-task v0.3.29 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking arrayvec v0.7.4 [INFO] [stderr] Compiling parking_lot_core v0.9.9 [INFO] [stderr] Compiling futures-util v0.3.29 [INFO] [stderr] Checking futures-sink v0.3.29 [INFO] [stderr] Compiling rustix v0.38.28 [INFO] [stderr] Compiling portable-atomic v1.6.0 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Checking bitflags v2.4.1 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Compiling thiserror v1.0.50 [INFO] [stderr] Checking linux-raw-sys v0.4.12 [INFO] [stderr] Checking futures-io v0.3.29 [INFO] [stderr] Compiling syn v2.0.40 [INFO] [stderr] Checking console v0.15.7 [INFO] [stderr] Checking getrandom v0.2.11 [INFO] [stderr] Compiling vte_generate_state_changes v0.1.1 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking thread_local v1.1.7 [INFO] [stderr] Checking fastrand v2.0.1 [INFO] [stderr] Checking vte v0.11.1 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking number_prefix v0.4.0 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking socket2 v0.5.5 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking mio v0.8.10 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Checking zeroize v1.7.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking shell-words v1.1.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking vt100 v0.15.2 [INFO] [stderr] Checking indicatif v0.17.7 [INFO] [stderr] Checking tempfile v3.8.1 [INFO] [stderr] Compiling futures-macro v0.3.29 [INFO] [stderr] Compiling thiserror-impl v1.0.50 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Checking tokio v1.35.0 [INFO] [stderr] Checking dialoguer v0.11.0 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking tracing-indicatif v0.3.6 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:182:9 [INFO] [stdout] | [INFO] [stdout] 181 | fn add_keys_to_style(&self, style: ProgressStyle) -> ProgressStyle { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 182 | / style [INFO] [stdout] 183 | | .with_key( [INFO] [stdout] 184 | | "span_name", [INFO] [stdout] 185 | | IndicatifProgressKey { [INFO] [stdout] ... | [INFO] [stdout] 193 | | }, [INFO] [stdout] 194 | | ) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:209:63 [INFO] [stdout] | [INFO] [stdout] 209 | .unwrap_or_else(|| self.add_keys_to_style(default_style.clone())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:353:25 [INFO] [stdout] | [INFO] [stdout] 341 | let pb_manager = ProgressBarManager::new( [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 350 | let mp = pb_manager.mp.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 353 | pb_manager: Mutex::new(pb_manager), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:356:29 [INFO] [stdout] | [INFO] [stdout] 341 | let pb_manager = ProgressBarManager::new( [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 350 | let mp = pb_manager.mp.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 356 | progress_style: ProgressStyle::with_template( [INFO] [stdout] | _____________________________^ [INFO] [stdout] 357 | | "{span_child_prefix}{spinner} {span_name}{{{span_fields}}}", [INFO] [stdout] 358 | | ) [INFO] [stdout] 359 | | .unwrap(), [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pb_manager.rs:42:17 [INFO] [stdout] | [INFO] [stdout] 37 | footer_progress_style: Option, [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | ) -> Self { [INFO] [stdout] 39 | let pending_progress_bars = Arc::new(AtomicU64::new(0)); [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | mp: { [INFO] [stdout] | _________________^ [INFO] [stdout] 43 | | let mp = MultiProgress::new(); [INFO] [stdout] 44 | | mp.set_draw_target(ProgressDrawTarget::stderr_with_hz(20)); [INFO] [stdout] ... | [INFO] [stdout] 47 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pb_manager.rs:50:36 [INFO] [stdout] | [INFO] [stdout] 37 | footer_progress_style: Option, [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | ) -> Self { [INFO] [stdout] 39 | let pending_progress_bars = Arc::new(AtomicU64::new(0)); [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | pending_progress_bars: pending_progress_bars.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pb_manager.rs:52:24 [INFO] [stdout] | [INFO] [stdout] 37 | footer_progress_style: Option, [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | ) -> Self { [INFO] [stdout] 39 | let pending_progress_bars = Arc::new(AtomicU64::new(0)); [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | footer_pb: footer_progress_style.map(|style| { [INFO] [stdout] | ________________________^ [INFO] [stdout] 53 | | ProgressBar::hidden().with_style(style.with_key( [INFO] [stdout] 54 | | "pending_progress_bars", [INFO] [stdout] 55 | | move |_: &ProgressState, writer: &mut dyn std::fmt::Write| { [INFO] [stdout] ... | [INFO] [stdout] 62 | | )) [INFO] [stdout] 63 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pb_manager.rs:53:17 [INFO] [stdout] | [INFO] [stdout] 39 | let pending_progress_bars = Arc::new(AtomicU64::new(0)); [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | footer_pb: footer_progress_style.map(|style| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | ProgressBar::hidden().with_style(style.with_key( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pb_manager.rs:53:50 [INFO] [stdout] | [INFO] [stdout] 39 | let pending_progress_bars = Arc::new(AtomicU64::new(0)); [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | footer_pb: footer_progress_style.map(|style| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | ProgressBar::hidden().with_style(style.with_key( [INFO] [stdout] | __________________________________________________^ [INFO] [stdout] 54 | | "pending_progress_bars", [INFO] [stdout] 55 | | move |_: &ProgressState, writer: &mut dyn std::fmt::Write| { [INFO] [stdout] 56 | | let _ = write!( [INFO] [stdout] ... | [INFO] [stdout] 61 | | }, [INFO] [stdout] 62 | | )) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tracing-indicatif` (lib) due to 10 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "46d22ab26f6def418a3f73465eef10ed5cfdaf186fc1cceb9fb84feba45e108d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "46d22ab26f6def418a3f73465eef10ed5cfdaf186fc1cceb9fb84feba45e108d", kill_on_drop: false }` [INFO] [stdout] 46d22ab26f6def418a3f73465eef10ed5cfdaf186fc1cceb9fb84feba45e108d