[INFO] fetching crate tracing-actix-web2 2.0.0... [INFO] checking tracing-actix-web2-2.0.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate tracing-actix-web2 2.0.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate tracing-actix-web2 2.0.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tracing-actix-web2 2.0.0 [INFO] finished tweaking crates.io crate tracing-actix-web2 2.0.0 [INFO] tweaked toml for crates.io crate tracing-actix-web2 2.0.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 148 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding convert_case v0.4.0 (latest: v0.6.0) [INFO] [stderr] Adding cookie v0.16.2 (latest: v0.18.1) [INFO] [stderr] Adding derive_more v0.99.18 (latest: v1.0.0) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding h2 v0.3.26 (latest: v0.4.6) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding http v0.2.12 (latest: v1.1.0) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding uuid v0.8.2 (latest: v1.10.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8b7224a578dec41d7f77e944de7b5e53bd99776b4fa9d79eabbcb3c0d7bd9a69 [INFO] running `Command { std: "docker" "start" "-a" "8b7224a578dec41d7f77e944de7b5e53bd99776b4fa9d79eabbcb3c0d7bd9a69", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8b7224a578dec41d7f77e944de7b5e53bd99776b4fa9d79eabbcb3c0d7bd9a69", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8b7224a578dec41d7f77e944de7b5e53bd99776b4fa9d79eabbcb3c0d7bd9a69", kill_on_drop: false }` [INFO] [stdout] 8b7224a578dec41d7f77e944de7b5e53bd99776b4fa9d79eabbcb3c0d7bd9a69 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] fd111ef672ab0764f782abcc6e5d6d1ec1f6436934e4cb823ab53170fe4073cf [INFO] running `Command { std: "docker" "start" "-a" "fd111ef672ab0764f782abcc6e5d6d1ec1f6436934e4cb823ab53170fe4073cf", kill_on_drop: false }` [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling jobserver v0.1.32 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Compiling zstd-safe v7.2.1 [INFO] [stderr] Checking alloc-no-stdlib v2.0.4 [INFO] [stderr] Checking local-waker v0.1.4 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling bytes v1.7.1 [INFO] [stderr] Compiling pin-project-lite v0.2.14 [INFO] [stderr] Checking powerfmt v0.2.0 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling num-conv v0.1.0 [INFO] [stderr] Compiling time-core v0.1.2 [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Compiling tracing-core v0.1.32 [INFO] [stderr] Checking actix-service v2.0.2 [INFO] [stderr] Checking actix-utils v3.0.1 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking alloc-stdlib v0.2.2 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Checking bytestring v1.3.1 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling cookie v0.16.2 [INFO] [stderr] Checking brotli-decompressor v4.0.1 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Compiling time-macros v0.2.18 [INFO] [stderr] Compiling regex-lite v0.1.6 [INFO] [stderr] Compiling convert_case v0.4.0 [INFO] [stderr] Compiling cc v1.1.15 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking local-channel v0.1.5 [INFO] [stderr] Checking language-tags v0.3.2 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Compiling derive_more v0.99.18 [INFO] [stderr] Compiling actix-macros v0.2.4 [INFO] [stderr] Checking flate2 v1.0.33 [INFO] [stderr] Checking actix-router v0.5.3 [INFO] [stderr] Checking impl-more v0.1.6 [INFO] [stderr] Checking uuid v0.8.2 [INFO] [stderr] Checking brotli v6.0.0 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Compiling zstd-sys v2.0.13+zstd.1.5.6 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Compiling actix-web-codegen v4.3.0 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking actix-rt v2.10.0 [INFO] [stderr] Checking actix-server v2.5.0 [INFO] [stderr] Checking h2 v0.3.26 [INFO] [stderr] Checking actix-codec v0.5.2 [INFO] [stderr] Checking zstd v0.13.2 [INFO] [stderr] Checking actix-http v3.9.0 [INFO] [stderr] Checking actix-web v4.9.0 [INFO] [stderr] Checking tracing-actix-web2 v2.0.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:33:12 [INFO] [stdout] | [INFO] [stdout] 32 | fn new_transform(&self, service: S) -> Self::Future { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | ok(TracerMiddleware { [INFO] [stdout] | ____________^ [INFO] [stdout] 34 | | service: Rc::new(RefCell::new(service)), [INFO] [stdout] 35 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:63:13 [INFO] [stdout] | [INFO] [stdout] 57 | fn call(&self, req: ServiceRequest) -> Self::Future { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | let request_id = Uuid::new_v4().to_string(); [INFO] [stdout] 59 | let root_span = span!(Level::INFO, "HttpRequest", %request_id, method = req.method().as_str(), path = req.path(), query = req.query_string(), remote_ip = req.connection_info().peer_addr().unwrap_or("-"... [INFO] [stdout] | --------- ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | [INFO] [stdout] 61 | let fut = self.service.call(req); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | Box::pin( [INFO] [stdout] 63 | / async move { [INFO] [stdout] 64 | | let mut res = fut.await?; [INFO] [stdout] 65 | | [INFO] [stdout] 66 | | res.headers_mut().insert( [INFO] [stdout] ... | [INFO] [stdout] 73 | | } [INFO] [stdout] 74 | | .instrument(root_span), [INFO] [stdout] | |__________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:33:12 [INFO] [stdout] | [INFO] [stdout] 32 | fn new_transform(&self, service: S) -> Self::Future { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | ok(TracerMiddleware { [INFO] [stdout] | ____________^ [INFO] [stdout] 34 | | service: Rc::new(RefCell::new(service)), [INFO] [stdout] 35 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:63:13 [INFO] [stdout] | [INFO] [stdout] 57 | fn call(&self, req: ServiceRequest) -> Self::Future { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | let request_id = Uuid::new_v4().to_string(); [INFO] [stdout] 59 | let root_span = span!(Level::INFO, "HttpRequest", %request_id, method = req.method().as_str(), path = req.path(), query = req.query_string(), remote_ip = req.connection_info().peer_addr().unwrap_or("-"... [INFO] [stdout] | --------- ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | [INFO] [stdout] 61 | let fut = self.service.call(req); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | Box::pin( [INFO] [stdout] 63 | / async move { [INFO] [stdout] 64 | | let mut res = fut.await?; [INFO] [stdout] 65 | | [INFO] [stdout] 66 | | res.headers_mut().insert( [INFO] [stdout] ... | [INFO] [stdout] 73 | | } [INFO] [stdout] 74 | | .instrument(root_span), [INFO] [stdout] | |__________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tracing-actix-web2` (lib test) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `tracing-actix-web2` (lib) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "fd111ef672ab0764f782abcc6e5d6d1ec1f6436934e4cb823ab53170fe4073cf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fd111ef672ab0764f782abcc6e5d6d1ec1f6436934e4cb823ab53170fe4073cf", kill_on_drop: false }` [INFO] [stdout] fd111ef672ab0764f782abcc6e5d6d1ec1f6436934e4cb823ab53170fe4073cf