[INFO] fetching crate trace-game 1.0.2... [INFO] checking trace-game-1.0.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate trace-game 1.0.2 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate trace-game 1.0.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate trace-game 1.0.2 [INFO] finished tweaking crates.io crate trace-game 1.0.2 [INFO] tweaked toml for crates.io crate trace-game 1.0.2 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate trace-game 1.0.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6fd4774b35619de6ecbde01b8baf83549ce28b28445f8cf8e4737c3b3a2a66f5 [INFO] running `Command { std: "docker" "start" "-a" "6fd4774b35619de6ecbde01b8baf83549ce28b28445f8cf8e4737c3b3a2a66f5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6fd4774b35619de6ecbde01b8baf83549ce28b28445f8cf8e4737c3b3a2a66f5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6fd4774b35619de6ecbde01b8baf83549ce28b28445f8cf8e4737c3b3a2a66f5", kill_on_drop: false }` [INFO] [stdout] 6fd4774b35619de6ecbde01b8baf83549ce28b28445f8cf8e4737c3b3a2a66f5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] eb8f90ff6f4d5383fabf02764f3b008557ada03b36ca58adc4ecfc518d0429a4 [INFO] running `Command { std: "docker" "start" "-a" "eb8f90ff6f4d5383fabf02764f3b008557ada03b36ca58adc4ecfc518d0429a4", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.125 [INFO] [stderr] Compiling proc-macro2 v1.0.38 [INFO] [stderr] Compiling unicode-xid v0.2.3 [INFO] [stderr] Compiling syn v1.0.94 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Compiling lock_api v0.4.7 [INFO] [stderr] Compiling parking_lot_core v0.9.3 [INFO] [stderr] Compiling signal-hook v0.3.13 [INFO] [stderr] Compiling serde_derive v1.0.137 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Compiling serde v1.0.137 [INFO] [stderr] Checking smallvec v1.8.0 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Checking ppv-lite86 v0.2.16 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking unicode-segmentation v1.9.0 [INFO] [stderr] Checking ryu v1.0.10 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Checking cassowary v0.3.0 [INFO] [stderr] Checking unicode-width v0.1.9 [INFO] [stderr] Compiling quote v1.0.18 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking mio v0.8.3 [INFO] [stderr] Checking getrandom v0.2.6 [INFO] [stderr] Checking time v0.1.43 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking parking_lot v0.12.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking signal-hook-mio v0.2.3 [INFO] [stderr] Checking crossterm v0.23.2 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking tui v0.18.0 [INFO] [stderr] Checking bstr v0.2.17 [INFO] [stderr] Checking csv v1.1.6 [INFO] [stderr] Checking trace-game v1.0.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `path::Path` [INFO] [stdout] --> src/windows/practice_window.rs:10:33 [INFO] [stdout] | [INFO] [stdout] 10 | use std::{collections::HashMap, path::Path, rc::Rc}; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `path::Path` [INFO] [stdout] --> src/windows/practice_window.rs:10:33 [INFO] [stdout] | [INFO] [stdout] 10 | use std::{collections::HashMap, path::Path, rc::Rc}; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/windows/practice_window.rs:158:10 [INFO] [stdout] | [INFO] [stdout] 139 | let mut commands = HashMap::from([ [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 158 | Some(Window { [INFO] [stdout] | __________^ [INFO] [stdout] 159 | | ui: practice_window, [INFO] [stdout] 160 | | commands, [INFO] [stdout] 161 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/windows/end_window.rs:155:10 [INFO] [stdout] | [INFO] [stdout] 136 | let mut file = match std::fs::OpenOptions::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 141 | Ok(f) => f, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 142 | Err(_) => { [INFO] [stdout] 143 | let mut file = std::fs::OpenOptions::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 155 | Some(Window { [INFO] [stdout] | __________^ [INFO] [stdout] 156 | | ui: end_window, [INFO] [stdout] 157 | | commands: HashMap::from([ [INFO] [stdout] 158 | | ( [INFO] [stdout] ... | [INFO] [stdout] 181 | | ]), [INFO] [stdout] 182 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/windows/end_window.rs:148:13 [INFO] [stdout] | [INFO] [stdout] 148 | file.write("wpm,accuracy,total_points,seconds".as_bytes()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 148 | let _ = file.write("wpm,accuracy,total_points,seconds".as_bytes()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/windows/end_window.rs:152:5 [INFO] [stdout] | [INFO] [stdout] 152 | file.write(csv.as_bytes()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 152 | let _ = file.write(csv.as_bytes()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/windows/end_window.rs:153:5 [INFO] [stdout] | [INFO] [stdout] 153 | file.flush(); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 153 | let _ = file.flush(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/windows/user_window.rs:73:10 [INFO] [stdout] | [INFO] [stdout] 45 | let mut commands = HashMap::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | Some(Window { [INFO] [stdout] | __________^ [INFO] [stdout] 74 | | ui: user_window, [INFO] [stdout] 75 | | commands, [INFO] [stdout] 76 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `trace-game` (lib test) due to 4 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/windows/practice_window.rs:158:10 [INFO] [stdout] | [INFO] [stdout] 139 | let mut commands = HashMap::from([ [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 158 | Some(Window { [INFO] [stdout] | __________^ [INFO] [stdout] 159 | | ui: practice_window, [INFO] [stdout] 160 | | commands, [INFO] [stdout] 161 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/windows/end_window.rs:155:10 [INFO] [stdout] | [INFO] [stdout] 136 | let mut file = match std::fs::OpenOptions::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 141 | Ok(f) => f, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 142 | Err(_) => { [INFO] [stdout] 143 | let mut file = std::fs::OpenOptions::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 155 | Some(Window { [INFO] [stdout] | __________^ [INFO] [stdout] 156 | | ui: end_window, [INFO] [stdout] 157 | | commands: HashMap::from([ [INFO] [stdout] 158 | | ( [INFO] [stdout] ... | [INFO] [stdout] 181 | | ]), [INFO] [stdout] 182 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/windows/end_window.rs:148:13 [INFO] [stdout] | [INFO] [stdout] 148 | file.write("wpm,accuracy,total_points,seconds".as_bytes()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 148 | let _ = file.write("wpm,accuracy,total_points,seconds".as_bytes()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/windows/end_window.rs:152:5 [INFO] [stdout] | [INFO] [stdout] 152 | file.write(csv.as_bytes()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 152 | let _ = file.write(csv.as_bytes()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/windows/end_window.rs:153:5 [INFO] [stdout] | [INFO] [stdout] 153 | file.flush(); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 153 | let _ = file.flush(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/windows/user_window.rs:73:10 [INFO] [stdout] | [INFO] [stdout] 45 | let mut commands = HashMap::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | Some(Window { [INFO] [stdout] | __________^ [INFO] [stdout] 74 | | ui: user_window, [INFO] [stdout] 75 | | commands, [INFO] [stdout] 76 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `trace-game` (lib) due to 4 previous errors; 4 warnings emitted [INFO] [stdout] error: aborting due to 3 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "eb8f90ff6f4d5383fabf02764f3b008557ada03b36ca58adc4ecfc518d0429a4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "eb8f90ff6f4d5383fabf02764f3b008557ada03b36ca58adc4ecfc518d0429a4", kill_on_drop: false }` [INFO] [stdout] eb8f90ff6f4d5383fabf02764f3b008557ada03b36ca58adc4ecfc518d0429a4