[INFO] fetching crate tpi 1.0.5... [INFO] checking tpi-1.0.5 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate tpi 1.0.5 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate tpi 1.0.5 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tpi 1.0.5 [INFO] finished tweaking crates.io crate tpi 1.0.5 [INFO] tweaked toml for crates.io crate tpi 1.0.5 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate tpi 1.0.5 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3d13d81f6d700b170efc885b022f728aa8202b94ea5984767ea2a8a5d543b0ba [INFO] running `Command { std: "docker" "start" "-a" "3d13d81f6d700b170efc885b022f728aa8202b94ea5984767ea2a8a5d543b0ba", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3d13d81f6d700b170efc885b022f728aa8202b94ea5984767ea2a8a5d543b0ba", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3d13d81f6d700b170efc885b022f728aa8202b94ea5984767ea2a8a5d543b0ba", kill_on_drop: false }` [INFO] [stdout] 3d13d81f6d700b170efc885b022f728aa8202b94ea5984767ea2a8a5d543b0ba [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2c20e6e8b09096e756a15abd3a1a2b0e0829396edae10db12971d10e14b9c85e [INFO] running `Command { std: "docker" "start" "-a" "2c20e6e8b09096e756a15abd3a1a2b0e0829396edae10db12971d10e14b9c85e", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.150 [INFO] [stderr] Compiling proc-macro2 v1.0.69 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Compiling futures-core v0.3.29 [INFO] [stderr] Checking itoa v1.0.9 [INFO] [stderr] Compiling unicase v2.7.0 [INFO] [stderr] Compiling futures-task v0.3.29 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling futures-util v0.3.29 [INFO] [stderr] Compiling rustix v0.38.21 [INFO] [stderr] Checking http v0.2.9 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Checking bitflags v2.4.1 [INFO] [stderr] Compiling futures-channel v0.3.29 [INFO] [stderr] Checking futures-sink v0.3.29 [INFO] [stderr] Compiling rustls v0.21.8 [INFO] [stderr] Compiling serde v1.0.190 [INFO] [stderr] Checking linux-raw-sys v0.4.10 [INFO] [stderr] Compiling httparse v1.8.0 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling syn v2.0.39 [INFO] [stderr] Checking anstyle-parse v0.2.2 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Checking mio v0.8.9 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking socket2 v0.5.5 [INFO] [stderr] Checking getrandom v0.2.10 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Checking anstyle-query v1.0.0 [INFO] [stderr] Checking try-lock v0.2.4 [INFO] [stderr] Compiling parking_lot_core v0.9.9 [INFO] [stderr] Checking anstyle v1.0.4 [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Checking percent-encoding v2.3.0 [INFO] [stderr] Checking anstream v0.6.4 [INFO] [stderr] Checking want v0.3.1 [INFO] [stderr] Checking form_urlencoded v1.2.0 [INFO] [stderr] Checking miniz_oxide v0.7.1 [INFO] [stderr] Checking terminal_size v0.3.0 [INFO] [stderr] Compiling mime_guess v2.0.4 [INFO] [stderr] Checking socket2 v0.4.10 [INFO] [stderr] Checking unicode-normalization v0.1.22 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking http-body v0.4.5 [INFO] [stderr] Checking tower-service v0.3.2 [INFO] [stderr] Compiling portable-atomic v1.5.1 [INFO] [stderr] Checking ryu v1.0.15 [INFO] [stderr] Compiling ring v0.17.5 [INFO] [stderr] Checking smallvec v1.11.1 [INFO] [stderr] Compiling serde_json v1.0.108 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking unicode-bidi v0.3.13 [INFO] [stderr] Checking clap_lex v0.6.0 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking clap_builder v4.4.7 [INFO] [stderr] Checking idna v0.4.0 [INFO] [stderr] Checking flate2 v1.0.28 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Checking base64 v0.21.5 [INFO] [stderr] Compiling anyhow v1.0.75 [INFO] [stderr] Checking rustls-pemfile v1.0.3 [INFO] [stderr] Checking url v2.4.1 [INFO] [stderr] Checking console v0.15.7 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking signal-hook-mio v0.2.3 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking encoding_rs v0.8.33 [INFO] [stderr] Checking webpki-roots v0.25.2 [INFO] [stderr] Checking number_prefix v0.4.0 [INFO] [stderr] Compiling tpi v1.0.5 (/opt/rustwide/workdir) [INFO] [stderr] Checking crossterm v0.24.0 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking platform-info v2.0.2 [INFO] [stderr] Compiling tokio-macros v2.1.0 [INFO] [stderr] Compiling clap_derive v4.4.7 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking tokio v1.33.0 [INFO] [stderr] Checking clap v4.4.7 [INFO] [stderr] Checking clap_complete v4.4.4 [INFO] [stderr] Checking rustls-webpki v0.101.7 [INFO] [stderr] Checking sct v0.7.1 [INFO] [stderr] Checking tokio-util v0.7.10 [INFO] [stderr] Checking tokio-rustls v0.24.1 [INFO] [stderr] Checking async-compression v0.4.4 [INFO] [stderr] Checking indicatif v0.17.7 [INFO] [stderr] Checking h2 v0.3.21 [INFO] [stderr] Checking hyper v0.14.27 [INFO] [stderr] Checking hyper-rustls v0.24.2 [INFO] [stderr] Checking reqwest v0.11.22 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/legacy_handler.rs:83:12 [INFO] [stdout] | [INFO] [stdout] 80 | let request = Request::new(host, version, creds, &user_agent)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | let client = Self::create_client(version)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | [INFO] [stdout] 83 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 84 | | request, [INFO] [stdout] 85 | | client, [INFO] [stdout] 86 | | response_printer: None, [INFO] [stdout] ... | [INFO] [stdout] 89 | | version, [INFO] [stdout] 90 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/legacy_handler.rs:329:15 [INFO] [stdout] | [INFO] [stdout] 320 | let client = self.client.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 321 | let mut req = self.request.clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 329 | spawn(async move { [INFO] [stdout] | _______________^ [INFO] [stdout] 330 | | let mut bar: Option = None; [INFO] [stdout] 331 | | let mut verifying = false; [INFO] [stdout] ... | [INFO] [stdout] 394 | | } [INFO] [stdout] 395 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/request.rs:51:12 [INFO] [stdout] | [INFO] [stdout] 46 | let mut inner = reqwest::Request::new(Method::GET, url); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 52 | | host, [INFO] [stdout] 53 | | ver, [INFO] [stdout] 54 | | creds, [INFO] [stdout] 55 | | inner, [INFO] [stdout] 56 | | multipart: None, [INFO] [stdout] 57 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/request.rs:64:12 [INFO] [stdout] | [INFO] [stdout] 62 | let inner = reqwest::Request::new(Method::POST, url); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | [INFO] [stdout] 64 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 65 | | host: self.host.clone(), [INFO] [stdout] 66 | | ver: self.ver, [INFO] [stdout] 67 | | creds: self.creds.clone(), [INFO] [stdout] 68 | | inner, [INFO] [stdout] 69 | | multipart: None, [INFO] [stdout] 70 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/request.rs:139:24 [INFO] [stdout] | [INFO] [stdout] 129 | let inner = self [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 139 | multipart: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tpi` (bin "tpi") due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/legacy_handler.rs:83:12 [INFO] [stdout] | [INFO] [stdout] 80 | let request = Request::new(host, version, creds, &user_agent)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | let client = Self::create_client(version)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | [INFO] [stdout] 83 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 84 | | request, [INFO] [stdout] 85 | | client, [INFO] [stdout] 86 | | response_printer: None, [INFO] [stdout] ... | [INFO] [stdout] 89 | | version, [INFO] [stdout] 90 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/legacy_handler.rs:329:15 [INFO] [stdout] | [INFO] [stdout] 320 | let client = self.client.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 321 | let mut req = self.request.clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 329 | spawn(async move { [INFO] [stdout] | _______________^ [INFO] [stdout] 330 | | let mut bar: Option = None; [INFO] [stdout] 331 | | let mut verifying = false; [INFO] [stdout] ... | [INFO] [stdout] 394 | | } [INFO] [stdout] 395 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/request.rs:51:12 [INFO] [stdout] | [INFO] [stdout] 46 | let mut inner = reqwest::Request::new(Method::GET, url); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 52 | | host, [INFO] [stdout] 53 | | ver, [INFO] [stdout] 54 | | creds, [INFO] [stdout] 55 | | inner, [INFO] [stdout] 56 | | multipart: None, [INFO] [stdout] 57 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/request.rs:64:12 [INFO] [stdout] | [INFO] [stdout] 62 | let inner = reqwest::Request::new(Method::POST, url); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | [INFO] [stdout] 64 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 65 | | host: self.host.clone(), [INFO] [stdout] 66 | | ver: self.ver, [INFO] [stdout] 67 | | creds: self.creds.clone(), [INFO] [stdout] 68 | | inner, [INFO] [stdout] 69 | | multipart: None, [INFO] [stdout] 70 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/request.rs:139:24 [INFO] [stdout] | [INFO] [stdout] 129 | let inner = self [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 139 | multipart: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tpi` (bin "tpi" test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "2c20e6e8b09096e756a15abd3a1a2b0e0829396edae10db12971d10e14b9c85e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2c20e6e8b09096e756a15abd3a1a2b0e0829396edae10db12971d10e14b9c85e", kill_on_drop: false }` [INFO] [stdout] 2c20e6e8b09096e756a15abd3a1a2b0e0829396edae10db12971d10e14b9c85e