[INFO] fetching crate toy_arena 0.2.0... [INFO] checking toy_arena-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate toy_arena 0.2.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate toy_arena 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate toy_arena 0.2.0 [INFO] finished tweaking crates.io crate toy_arena 0.2.0 [INFO] tweaked toml for crates.io crate toy_arena 0.2.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 6 packages to latest compatible versions [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0b7fa20886986c199b0788c27e6c7dba48ed4eecfb16a85dfb277874bb4404d3 [INFO] running `Command { std: "docker" "start" "-a" "0b7fa20886986c199b0788c27e6c7dba48ed4eecfb16a85dfb277874bb4404d3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0b7fa20886986c199b0788c27e6c7dba48ed4eecfb16a85dfb277874bb4404d3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0b7fa20886986c199b0788c27e6c7dba48ed4eecfb16a85dfb277874bb4404d3", kill_on_drop: false }` [INFO] [stdout] 0b7fa20886986c199b0788c27e6c7dba48ed4eecfb16a85dfb277874bb4404d3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] aa6ea517b0111b0ee4f4e6e9fefa35ed6476b45e56f8218cc9f15ee3f8f7c240 [INFO] running `Command { std: "docker" "start" "-a" "aa6ea517b0111b0ee4f4e6e9fefa35ed6476b45e56f8218cc9f15ee3f8f7c240", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling derivative v2.2.0 [INFO] [stderr] Checking toy_arena v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:340:13 [INFO] [stdout] | [INFO] [stdout] 340 | let mut slot_states = self.slot_states.get_mut(); [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `set_parent` is never used [INFO] [stdout] --> src/tree/link.rs:49:12 [INFO] [stdout] | [INFO] [stdout] 37 | impl Link { [INFO] [stdout] | --------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 49 | pub fn set_parent(&mut self, parent: Option) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/lib.rs:428:13 [INFO] [stdout] | [INFO] [stdout] 428 | drop(slot_states); [INFO] [stdout] | ^^^^^-----------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&mut SlotStates` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_references)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 428 - drop(slot_states); [INFO] [stdout] 428 + let _ = slot_states; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree/iter_mut.rs:44:20 [INFO] [stdout] | [INFO] [stdout] 40 | let mut tree = Tree::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | inner: Rc::new(TreeBindDrop { [INFO] [stdout] | ____________________^ [INFO] [stdout] 45 | | original, [INFO] [stdout] 46 | | tree: UnsafeCell::new(tree), [INFO] [stdout] 47 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `toy_arena` (lib) due to 2 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:340:13 [INFO] [stdout] | [INFO] [stdout] 340 | let mut slot_states = self.slot_states.get_mut(); [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `set_parent` is never used [INFO] [stdout] --> src/tree/link.rs:49:12 [INFO] [stdout] | [INFO] [stdout] 37 | impl Link { [INFO] [stdout] | --------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 49 | pub fn set_parent(&mut self, parent: Option) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/lib.rs:428:13 [INFO] [stdout] | [INFO] [stdout] 428 | drop(slot_states); [INFO] [stdout] | ^^^^^-----------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&mut SlotStates` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_references)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 428 - drop(slot_states); [INFO] [stdout] 428 + let _ = slot_states; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree/iter_mut.rs:44:20 [INFO] [stdout] | [INFO] [stdout] 40 | let mut tree = Tree::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | inner: Rc::new(TreeBindDrop { [INFO] [stdout] | ____________________^ [INFO] [stdout] 45 | | original, [INFO] [stdout] 46 | | tree: UnsafeCell::new(tree), [INFO] [stdout] 47 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `toy_arena` (lib test) due to 2 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "aa6ea517b0111b0ee4f4e6e9fefa35ed6476b45e56f8218cc9f15ee3f8f7c240", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "aa6ea517b0111b0ee4f4e6e9fefa35ed6476b45e56f8218cc9f15ee3f8f7c240", kill_on_drop: false }` [INFO] [stdout] aa6ea517b0111b0ee4f4e6e9fefa35ed6476b45e56f8218cc9f15ee3f8f7c240