[INFO] fetching crate tower-util 0.3.1... [INFO] checking tower-util-0.3.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate tower-util 0.3.1 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate tower-util 0.3.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tower-util 0.3.1 [INFO] finished tweaking crates.io crate tower-util 0.3.1 [INFO] tweaked toml for crates.io crate tower-util 0.3.1 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 23 packages to latest compatible versions [INFO] [stderr] Adding bytes v0.5.6 (latest: v1.7.1) [INFO] [stderr] Adding pin-project v0.4.30 (latest: v1.1.5) [INFO] [stderr] Adding pin-project-internal v0.4.30 (latest: v1.1.5) [INFO] [stderr] Adding pin-project-lite v0.1.12 (latest: v0.2.14) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding tokio v0.2.25 (latest: v1.40.0) [INFO] [stderr] Adding tokio-macros v0.2.6 (latest: v2.4.0) [INFO] [stderr] Adding tokio-test v0.2.1 (latest: v0.4.4) [INFO] [stderr] Adding tower-test v0.3.0 (latest: v0.4.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] df7d9d5b03176ddf6a45ab5a7e0d34648e4ba441ad19ff54594126feb54564fe [INFO] running `Command { std: "docker" "start" "-a" "df7d9d5b03176ddf6a45ab5a7e0d34648e4ba441ad19ff54594126feb54564fe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "df7d9d5b03176ddf6a45ab5a7e0d34648e4ba441ad19ff54594126feb54564fe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "df7d9d5b03176ddf6a45ab5a7e0d34648e4ba441ad19ff54594126feb54564fe", kill_on_drop: false }` [INFO] [stdout] df7d9d5b03176ddf6a45ab5a7e0d34648e4ba441ad19ff54594126feb54564fe [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8cd51196940f79538d40d4f99f72829205774f025d8109628a4fbfc600c3bb9e [INFO] running `Command { std: "docker" "start" "-a" "8cd51196940f79538d40d4f99f72829205774f025d8109628a4fbfc600c3bb9e", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling pin-project-internal v0.4.30 [INFO] [stderr] Checking bytes v0.5.6 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking pin-project-lite v0.1.12 [INFO] [stderr] Checking tower-service v0.3.3 [INFO] [stderr] Checking tower-layer v0.3.3 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling tokio-macros v0.2.6 [INFO] [stderr] Checking tokio v0.2.25 [INFO] [stderr] Checking pin-project v0.4.30 [INFO] [stderr] Checking tower-util v0.3.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated macro `project`: consider naming projected type by passing `project` argument to #[pin_project] attribute instead, see release note for details [INFO] [stdout] --> src/either.rs:69:7 [INFO] [stdout] | [INFO] [stdout] 69 | #[project] [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `project`: consider naming projected type by passing `project` argument to #[pin_project] attribute instead, see release note for details [INFO] [stdout] --> src/oneshot.rs:65:7 [INFO] [stdout] | [INFO] [stdout] 65 | #[project] [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `futures_util::stream::FuturesOrdered::::push`: use `push_back` instead [INFO] [stdout] --> src/call_all/ordered.rs:157:25 [INFO] [stdout] | [INFO] [stdout] 157 | FuturesOrdered::push(self, future) [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/boxed/sync.rs:83:18 [INFO] [stdout] | [INFO] [stdout] 82 | fn call(&mut self, request: Request) -> Self::Future { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | Box::pin(self.inner.call(request)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/boxed/unsync.rs:77:18 [INFO] [stdout] | [INFO] [stdout] 76 | fn call(&mut self, request: Request) -> Self::Future { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | Box::pin(self.inner.call(request)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/call_all/common.rs:40:22 [INFO] [stdout] | [INFO] [stdout] 38 | pub(crate) fn new(service: Svc, stream: S, queue: Q) -> CallAll { [INFO] [stdout] | ------------ --------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | CallAll { [INFO] [stdout] 40 | service: Some(service), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/call_all/common.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 48 | pub(crate) fn into_inner(mut self) -> Svc { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | self.service.take().expect("Service already taken") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/call_all/common.rs:63:38 [INFO] [stdout] | [INFO] [stdout] 60 | pub(crate) fn unordered(mut self) -> super::CallAllUnordered { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | super::CallAllUnordered::new(self.service.take().unwrap(), self.stream) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/call_all/ordered.rs:102:20 [INFO] [stdout] | [INFO] [stdout] 100 | pub fn new(service: Svc, stream: S) -> CallAll { [INFO] [stdout] | ------------ --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 101 | CallAll { [INFO] [stdout] 102 | inner: common::CallAll::new(service, stream, FuturesOrdered::new()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/call_all/unordered.rs:42:20 [INFO] [stdout] | [INFO] [stdout] 40 | pub fn new(service: Svc, stream: S) -> CallAllUnordered { [INFO] [stdout] | ------------ --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | CallAllUnordered { [INFO] [stdout] 42 | inner: common::CallAll::new(service, stream, FuturesUnordered::new()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/oneshot.rs:54:20 [INFO] [stdout] | [INFO] [stdout] 52 | pub fn new(svc: S, req: Req) -> Self { [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | Oneshot { [INFO] [stdout] 54 | state: State::NotReady(Some((svc, req))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ready.rs:29:20 [INFO] [stdout] | [INFO] [stdout] 27 | pub fn new(service: T) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | Self { [INFO] [stdout] 29 | inner: Some(service), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ready.rs:130:21 [INFO] [stdout] | [INFO] [stdout] 129 | let _ = ready!(Pin::new(&mut self.0).poll(cx)); [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 130 | Poll::Ready(Ok(())) [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tower-util` (lib) due to 11 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "8cd51196940f79538d40d4f99f72829205774f025d8109628a4fbfc600c3bb9e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8cd51196940f79538d40d4f99f72829205774f025d8109628a4fbfc600c3bb9e", kill_on_drop: false }` [INFO] [stdout] 8cd51196940f79538d40d4f99f72829205774f025d8109628a4fbfc600c3bb9e