[INFO] fetching crate tower-spawn-ready 0.3.0... [INFO] checking tower-spawn-ready-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate tower-spawn-ready 0.3.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate tower-spawn-ready 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tower-spawn-ready 0.3.0 [INFO] finished tweaking crates.io crate tower-spawn-ready 0.3.0 [INFO] tweaked toml for crates.io crate tower-spawn-ready 0.3.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 23 packages to latest compatible versions [INFO] [stderr] Adding bytes v0.5.6 (latest: v1.7.1) [INFO] [stderr] Adding pin-project v0.4.30 (latest: v1.1.5) [INFO] [stderr] Adding pin-project-internal v0.4.30 (latest: v1.1.5) [INFO] [stderr] Adding pin-project-lite v0.1.12 (latest: v0.2.14) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding tokio v0.2.25 (latest: v1.40.0) [INFO] [stderr] Adding tokio-macros v0.2.6 (latest: v2.4.0) [INFO] [stderr] Adding tokio-test v0.2.1 (latest: v0.4.4) [INFO] [stderr] Adding tower-test v0.3.0 (latest: v0.4.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f22ffee21f9634e5553ea1fee72706f7d8691c7bbd2b4e9d6eef98898cd79daa [INFO] running `Command { std: "docker" "start" "-a" "f22ffee21f9634e5553ea1fee72706f7d8691c7bbd2b4e9d6eef98898cd79daa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f22ffee21f9634e5553ea1fee72706f7d8691c7bbd2b4e9d6eef98898cd79daa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f22ffee21f9634e5553ea1fee72706f7d8691c7bbd2b4e9d6eef98898cd79daa", kill_on_drop: false }` [INFO] [stdout] f22ffee21f9634e5553ea1fee72706f7d8691c7bbd2b4e9d6eef98898cd79daa [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 74f4ff3d436fe0087eb1dc69833418da19a86cd2f75b0177a9eff05f462a4aaf [INFO] running `Command { std: "docker" "start" "-a" "74f4ff3d436fe0087eb1dc69833418da19a86cd2f75b0177a9eff05f462a4aaf", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Compiling pin-project-internal v0.4.30 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking pin-project-lite v0.1.12 [INFO] [stderr] Checking bytes v0.5.6 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Checking tower-layer v0.3.3 [INFO] [stderr] Checking tower-service v0.3.3 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling tokio-macros v0.2.6 [INFO] [stderr] Checking tokio v0.2.25 [INFO] [stderr] Checking pin-project v0.4.30 [INFO] [stderr] Checking tokio-test v0.2.1 [INFO] [stderr] Checking tower-spawn-ready v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/future.rs:58:23 [INFO] [stdout] | [INFO] [stdout] 58 | .map(|()| this.service.take().expect("illegal state")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/make.rs:46:20 [INFO] [stdout] | [INFO] [stdout] 44 | fn call(&mut self, target: Target) -> Self::Future { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | MakeFuture { [INFO] [stdout] 46 | inner: self.inner.call(target), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/make.rs:61:21 [INFO] [stdout] | [INFO] [stdout] 59 | let inner = ready!(this.inner.poll(cx))?; [INFO] [stdout] | ----- --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | let svc = SpawnReady::new(inner); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | Poll::Ready(Ok(svc)) [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/service.rs:30:20 [INFO] [stdout] | [INFO] [stdout] 28 | pub fn new(service: T) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | Self { [INFO] [stdout] 30 | inner: Inner::Service(Some(service)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tower-spawn-ready` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "74f4ff3d436fe0087eb1dc69833418da19a86cd2f75b0177a9eff05f462a4aaf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "74f4ff3d436fe0087eb1dc69833418da19a86cd2f75b0177a9eff05f462a4aaf", kill_on_drop: false }` [INFO] [stdout] 74f4ff3d436fe0087eb1dc69833418da19a86cd2f75b0177a9eff05f462a4aaf