[INFO] fetching crate tower-duplex 0.1.1... [INFO] checking tower-duplex-0.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate tower-duplex 0.1.1 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate tower-duplex 0.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-5-tc2/source/rust-toolchain [INFO] started tweaking crates.io crate tower-duplex 0.1.1 [INFO] finished tweaking crates.io crate tower-duplex 0.1.1 [INFO] tweaked toml for crates.io crate tower-duplex 0.1.1 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 95 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding bit-set v0.5.3 (latest: v0.8.0) [INFO] [stderr] Adding bit-vec v0.6.3 (latest: v0.8.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding quick-error v1.2.3 (latest: v2.0.1) [INFO] [stderr] Adding tower v0.4.13 (latest: v0.5.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e906a8c780bc6e4105e7f163968e4689c36a68a5ef54b5e9db684591c1852a0a [INFO] running `Command { std: "docker" "start" "-a" "e906a8c780bc6e4105e7f163968e4689c36a68a5ef54b5e9db684591c1852a0a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e906a8c780bc6e4105e7f163968e4689c36a68a5ef54b5e9db684591c1852a0a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e906a8c780bc6e4105e7f163968e4689c36a68a5ef54b5e9db684591c1852a0a", kill_on_drop: false }` [INFO] [stdout] e906a8c780bc6e4105e7f163968e4689c36a68a5ef54b5e9db684591c1852a0a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 16ca87c936e2b0920f4ca9d36385167103a7865e553c8153062e07d114ab1395 [INFO] running `Command { std: "docker" "start" "-a" "16ca87c936e2b0920f4ca9d36385167103a7865e553c8153062e07d114ab1395", kill_on_drop: false }` [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking tower-service v0.3.3 [INFO] [stderr] Checking tower-layer v0.3.3 [INFO] [stderr] Checking bit-vec v0.6.3 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking unarray v0.1.4 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking bit-set v0.5.3 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking proptest v1.5.0 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking tokio-stream v0.1.15 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking tower-duplex v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated method `futures::stream::FuturesOrdered::::push`: use `push_back` instead [INFO] [stdout] --> src/lib.rs:219:26 [INFO] [stdout] | [INFO] [stdout] 219 | send_fut.push(do_send(to_send, sender.take())); [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `futures::stream::FuturesOrdered::::push`: use `push_back` instead [INFO] [stdout] --> src/lib.rs:219:26 [INFO] [stdout] | [INFO] [stdout] 219 | send_fut.push(do_send(to_send, sender.take())); [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:163:13 [INFO] [stdout] | [INFO] [stdout] 159 | pub fn new_pair(service: S) -> (Self, DuplexClient) { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 160 | let load = Arc::new(AtomicUsize::new(0)); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 161 | let (calls_sender, calls) = mpsc::unbounded_channel(); [INFO] [stdout] | ------------ ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 162 | ( [INFO] [stdout] 163 | / DuplexService { [INFO] [stdout] 164 | | calls, [INFO] [stdout] 165 | | service, [INFO] [stdout] 166 | | load: load.clone(), [INFO] [stdout] 167 | | _p: Default::default(), [INFO] [stdout] 168 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:169:13 [INFO] [stdout] | [INFO] [stdout] 159 | pub fn new_pair(service: S) -> (Self, DuplexClient) { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 160 | let load = Arc::new(AtomicUsize::new(0)); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 161 | let (calls_sender, calls) = mpsc::unbounded_channel(); [INFO] [stdout] | ------------ ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 169 | / DuplexClient { [INFO] [stdout] 170 | | sender: calls_sender, [INFO] [stdout] 171 | | load, [INFO] [stdout] 172 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:236:62 [INFO] [stdout] | [INFO] [stdout] 235 | ... let fut = service.call(req); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 236 | ... pending_calls.push(async move { (fut.await, tag) }); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tower-duplex` (lib) due to 4 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: use of deprecated method `futures::stream::FuturesOrdered::::push`: use `push_back` instead [INFO] [stdout] --> src/test.rs:101:12 [INFO] [stdout] | [INFO] [stdout] 101 | c1.push(client1.call(Req1(i.to_string()))); [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `futures::stream::FuturesOrdered::::push`: use `push_back` instead [INFO] [stdout] --> src/test.rs:102:12 [INFO] [stdout] | [INFO] [stdout] 102 | c2.push(client2.do_call(Req2(i))); [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:163:13 [INFO] [stdout] | [INFO] [stdout] 159 | pub fn new_pair(service: S) -> (Self, DuplexClient) { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 160 | let load = Arc::new(AtomicUsize::new(0)); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 161 | let (calls_sender, calls) = mpsc::unbounded_channel(); [INFO] [stdout] | ------------ ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 162 | ( [INFO] [stdout] 163 | / DuplexService { [INFO] [stdout] 164 | | calls, [INFO] [stdout] 165 | | service, [INFO] [stdout] 166 | | load: load.clone(), [INFO] [stdout] 167 | | _p: Default::default(), [INFO] [stdout] 168 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:169:13 [INFO] [stdout] | [INFO] [stdout] 159 | pub fn new_pair(service: S) -> (Self, DuplexClient) { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 160 | let load = Arc::new(AtomicUsize::new(0)); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 161 | let (calls_sender, calls) = mpsc::unbounded_channel(); [INFO] [stdout] | ------------ ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 169 | / DuplexClient { [INFO] [stdout] 170 | | sender: calls_sender, [INFO] [stdout] 171 | | load, [INFO] [stdout] 172 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:236:62 [INFO] [stdout] | [INFO] [stdout] 235 | ... let fut = service.call(req); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 236 | ... pending_calls.push(async move { (fut.await, tag) }); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test.rs:73:18 [INFO] [stdout] | [INFO] [stdout] 65 | fn call(&mut self, req: Request) -> Self::Future { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | let delay = tokio::time::sleep(std::time::Duration::from_millis((y % 2048) as _)); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | [INFO] [stdout] 73 | Box::pin(async move { [INFO] [stdout] | __________________^ [INFO] [stdout] 74 | | delay.await; [INFO] [stdout] 75 | | Ok(req.into()) [INFO] [stdout] 76 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test.rs:75:16 [INFO] [stdout] | [INFO] [stdout] 65 | fn call(&mut self, req: Request) -> Self::Future { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | let delay = tokio::time::sleep(std::time::Duration::from_millis((y % 2048) as _)); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | Ok(req.into()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test.rs:85:24 [INFO] [stdout] | [INFO] [stdout] 85 | .map(|(a, b)| (a.into_split(), b.into_split())) [INFO] [stdout] | ------ ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test.rs:85:40 [INFO] [stdout] | [INFO] [stdout] 85 | .map(|(a, b)| (a.into_split(), b.into_split())) [INFO] [stdout] | ------ ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tower-duplex` (lib test) due to 8 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "16ca87c936e2b0920f4ca9d36385167103a7865e553c8153062e07d114ab1395", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "16ca87c936e2b0920f4ca9d36385167103a7865e553c8153062e07d114ab1395", kill_on_drop: false }` [INFO] [stdout] 16ca87c936e2b0920f4ca9d36385167103a7865e553c8153062e07d114ab1395