[INFO] fetching crate total-space 0.1.1... [INFO] checking total-space-0.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate total-space 0.1.1 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate total-space 0.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate total-space 0.1.1 [INFO] finished tweaking crates.io crate total-space 0.1.1 [INFO] tweaked toml for crates.io crate total-space 0.1.1 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate total-space 0.1.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9abe23dcf9dd98cd36a8e2f5e564ce1bfe936af7af08968c51a81e89664c163c [INFO] running `Command { std: "docker" "start" "-a" "9abe23dcf9dd98cd36a8e2f5e564ce1bfe936af7af08968c51a81e89664c163c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9abe23dcf9dd98cd36a8e2f5e564ce1bfe936af7af08968c51a81e89664c163c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9abe23dcf9dd98cd36a8e2f5e564ce1bfe936af7af08968c51a81e89664c163c", kill_on_drop: false }` [INFO] [stdout] 9abe23dcf9dd98cd36a8e2f5e564ce1bfe936af7af08968c51a81e89664c163c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6d4b8cb950571014910ea768aa627911e21be70587b4dfaf9048281fa6554bdf [INFO] running `Command { std: "docker" "start" "-a" "6d4b8cb950571014910ea768aa627911e21be70587b4dfaf9048281fa6554bdf", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.24 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling syn v1.0.60 [INFO] [stderr] Compiling libc v0.2.86 [INFO] [stderr] Compiling serde_derive v1.0.123 [INFO] [stderr] Compiling serde v1.0.123 [INFO] [stderr] Compiling getrandom v0.2.2 [INFO] [stderr] Compiling version_check v0.9.3 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling unicode-segmentation v1.7.1 [INFO] [stderr] Checking once_cell v1.7.2 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling serde_json v1.0.64 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Checking siphasher v0.3.3 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Compiling escargot v0.5.2 [INFO] [stderr] Checking precomputed-hash v0.1.1 [INFO] [stderr] Checking itoa v0.4.7 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking new_debug_unreachable v1.0.4 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking phf_shared v0.8.0 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling ahash v0.7.2 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling heck v0.3.2 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Compiling strum_macros v0.20.1 [INFO] [stderr] Checking strum v0.20.0 [INFO] [stderr] Checking string_cache v0.8.1 [INFO] [stderr] Checking total-space v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/models.rs:1160:9 [INFO] [stdout] | [INFO] [stdout] 1160 | mut context: &mut ::Context, [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/models.rs:3959:9 [INFO] [stdout] | [INFO] [stdout] 3959 | mut sequence_state: &mut ::SequenceState, [INFO] [stdout] | ----^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/agents.rs:217:21 [INFO] [stdout] | [INFO] [stdout] 186 | prev_agent_type: Option>>, [INFO] [stdout] | ------------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 201 | let mut states = Memoize::new(StateId::invalid().to_usize()); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 217 | states: RefCell::new(states), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/agents.rs:218:26 [INFO] [stdout] | [INFO] [stdout] 186 | prev_agent_type: Option>>, [INFO] [stdout] | ------------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 201 | let mut states = Memoize::new(StateId::invalid().to_usize()); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 218 | first_index: prev_agent_type [INFO] [stdout] | __________________________^ [INFO] [stdout] 219 | | .clone() [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/agents.rs:292:30 [INFO] [stdout] | [INFO] [stdout] 288 | part_type: Rc>, [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 289 | prev_type: Rc>, [INFO] [stdout] | ---------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 292 | agent_type_data: AgentTypeData::new(name, instances, Some(prev_type)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/agents.rs:317:30 [INFO] [stdout] | [INFO] [stdout] 312 | part1_type: Rc>, [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 313 | part2_type: Rc>, [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 314 | prev_type: Rc>, [INFO] [stdout] | ---------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 317 | agent_type_data: AgentTypeData::new(name, instances, Some(prev_type)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/claps.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 13 | pub fn add_clap<'a, 'b>(app: App<'a, 'b>) -> App<'a, 'b> { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 14 | / app.arg( [INFO] [stdout] 15 | | Arg::with_name("progress") [INFO] [stdout] 16 | | .short("p") [INFO] [stdout] 17 | | .long("progress-every") [INFO] [stdout] ... | [INFO] [stdout] 74 | | )), [INFO] [stdout] 75 | | ) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/claps.rs:77:9 [INFO] [stdout] | [INFO] [stdout] 13 | pub fn add_clap<'a, 'b>(app: App<'a, 'b>) -> App<'a, 'b> { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | / SubCommand::with_name("states") [INFO] [stdout] 78 | | .about("generate a GraphViz dot diagrams for the states of a specific agent") [INFO] [stdout] 79 | | .arg( [INFO] [stdout] 80 | | Arg::with_name("AGENT") [INFO] [stdout] ... | [INFO] [stdout] 105 | | .help("most condensed graph (implies --names-only, --merge-instances and --final-replaced)"), [INFO] [stdout] 106 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `total-space` (lib) due to 7 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "6d4b8cb950571014910ea768aa627911e21be70587b4dfaf9048281fa6554bdf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6d4b8cb950571014910ea768aa627911e21be70587b4dfaf9048281fa6554bdf", kill_on_drop: false }` [INFO] [stdout] 6d4b8cb950571014910ea768aa627911e21be70587b4dfaf9048281fa6554bdf